public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: soc@kernel.org, arm@kernel.org, Shawn Guo <shawnguo@kernel.org>,
	 Fabio Estevam <festevam@gmail.com>,
	kernel@pengutronix.de, imx@lists.linux.dev,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL 1/4] i.MX arm64 dts changes for v7.1
Date: Sat, 4 Apr 2026 16:34:37 +0200	[thread overview]
Message-ID: <20260404-practical-purple-jackal-8e250d@quoll> (raw)
In-Reply-To: <20260330141444.3789193-2-Frank.Li@nxp.com>

On Mon, Mar 30, 2026 at 10:14:37AM -0400, Frank Li wrote:
> From: Frank.Li@nxp.com
> 
> The following changes since commit 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f:
> 
>   Linux 7.0-rc1 (2026-02-22 13:18:59 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frank.li/linux.git tags/imx-dt64-7.1
> 
> for you to fetch changes up to 825b8c7e1d2918d89eb378b761530d1e51dba82e:
> 
>   arm64: dts: imx8qxp-mek: switch Type-C connector power-role to dual (2026-03-27 09:53:32 -0400)
> 
> ----------------------------------------------------------------
> i.MX arm64 device tree changes for 7.1:
> 
> - New Board Support
>   S32N79-RDB, Variscite DART-MX95, DART-MX91 with Sonata carrier boards,
>   Verdin iMX95 with multiple carrier boards (Yavia, Mallow, Ivy, Dahlia)
>   TQMa93xx/MBa93xxLA-MINI, SolidRun i.MX8MP HummingBoard IIoT,
>   SolidRun i.MX8MM SOM and EVB, SolidRun SolidSense-N8 board
>   Ka-Ro Electronics tx8m-1610 COM, GOcontroll Moduline IV and Moduline Mini,
>   NXP FRDM-IMX91S board, i.MX93 Wireless EVK board with Wireless SiP,
>   NXP i.MX8MP audio board v2.

You do not have any bindings for these.

I found them in driver bindings (!!!) pull request so completely
different branch. This is wrong. Bindings come with the user. Who is the
user of board bindings? Not a driver, but exactly this pull request.

This makes this branch full of warnings which is completely unnecessary.
Plus this will spawn multiple checkpatch warnings if tested. It must
have also cause warnings in your case, so probably you do not test your
tree enough.

...

> Marco Felsch (1):
>       arm64: dts: imx93: Add parallel display output nodes
> 
> Martin Schmiedel (2):
>       arm64: dts: freescale: add initial device tree for TQMa93xx/MBa93xxLA-MINI
>       arm64: dts: freescale: imx93-tqma9352-mba93xxla-mini: Add WLAN/BT overlay
> 
> Maud Spierings (4):
>       arm64: dts: imx8mm: Add pinctrl config definitions
>       arm64: dts: freescale: add Ka-Ro Electronics tx8m-1610 COM
>       arm64: dts: freescale: Add the GOcontroll Moduline IV
>       arm64: dts: freescale: Add the GOcontroll Moduline Mini
> 
> Nora Schiffer (1):
>       arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing
> 
> Peng Fan (4):
>       arm64: dts: imx94: Add V2X/ELE mailbox nodes
>       arm64: dts: imx94: Add SCMI sensor/lmm/cpu nodes
>       arm64: dts: imx943-evk: Add nxp,ctrl-ids for scmi_misc
>       arm64: dts: imx943-evk: Add pf09/53 thermal zone
> 
> Primoz Fiser (1):
>       arm64: dts: freescale: imx93-phy{core,board}: Add i2c bus recovery
> 
> Ranjani Vaidyanathan (1):
>       arm64: dts: imx94: Update pin headers
> 
> Rob Herring (Arm) (1):
>       arm64: dts: freescale: imx93: Add Ethos-U65 NPU and SRAM nodes
> 
> Shengjiu Wang (7):
>       arm64: dts: imx8mm-evk: correct the spdif compatible string

This breaks users of DTS and explains nothing about impact or why this
should be changed (corrected). It should not pass review of two people.
Also I could not find explanation of the impact in the tag message.

Device was apparently working fine, so it should have been made
compatible. I know that 10 years ago we did not care that much about
DTS users, but that changes for a few years already.

I am merging this but next time I would postpone the pull till some
clarifications are provided. Please pay attention to OF_UPSTREAM and
other users impact next time.

Best regards,
Krzysztof



  reply	other threads:[~2026-04-04 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 14:14 [GIT PULL 3/4] i.MX dt binding changes for v7.1 Frank Li
2026-03-30 14:14 ` [GIT PULL 1/4] i.MX arm64 dts " Frank Li
2026-04-04 14:34   ` Krzysztof Kozlowski [this message]
2026-04-06  1:31     ` Frank Li
2026-03-30 14:14 ` [GIT PULL 2/4] i.MX arm " Frank Li
2026-04-04 14:47   ` Krzysztof Kozlowski
2026-03-30 14:14 ` [GIT PULL 4/4] i.MX drivers/soc " Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260404-practical-purple-jackal-8e250d@quoll \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=arm@kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox