From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: soc@kernel.org, arm@kernel.org, Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
kernel@pengutronix.de, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL 2/4] i.MX arm dts changes for v7.1
Date: Sat, 4 Apr 2026 16:47:16 +0200 [thread overview]
Message-ID: <20260404-thoughtful-placid-boobook-da26da@quoll> (raw)
In-Reply-To: <20260330141444.3789193-3-Frank.Li@nxp.com>
On Mon, Mar 30, 2026 at 10:14:38AM -0400, Frank Li wrote:
> Frank Li (24):
> ARM: dts: imx35: rename emi to emi-bus to fix CHECK_DTBS warning
> ARM: dts: imx35: rename i2c clock-names to ipg
> ARM: dts: imx35: remove simple-bus 'usbphy'
> ARM: dts: imx51-ts4800: rename fpga@0 to fpga@0,0
> ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1
> ARM: dts: imx53: drop fallback compatible "dlg,da9052"
This, just like arm64 pull, breaks users without explanation. You use
incorrect terms in that commit msg which might mean you did not perform
proper analysis of compatibility. Commit claims compatibility string is
not comaptible and as proof brings dtbs_check warning. So the sole
reason is the binding. What if binding is wrong?
Commit msg must explain that.
I looked at the drivers and it looks 100% compatible, so commit msg is
clearly wrong and this might affect users of DTS.
Please resend pull without this commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-04 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 14:14 [GIT PULL 3/4] i.MX dt binding changes for v7.1 Frank Li
2026-03-30 14:14 ` [GIT PULL 1/4] i.MX arm64 dts " Frank Li
2026-04-04 14:34 ` Krzysztof Kozlowski
2026-04-06 1:31 ` Frank Li
2026-03-30 14:14 ` [GIT PULL 2/4] i.MX arm " Frank Li
2026-04-04 14:47 ` Krzysztof Kozlowski [this message]
2026-03-30 14:14 ` [GIT PULL 4/4] i.MX drivers/soc " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260404-thoughtful-placid-boobook-da26da@quoll \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=arm@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox