Re: [PATCH v1 2/3] arm64: dts: mediatek: mt7988a-bpi-r4pro: update gpio-leds

Daniel Golle
2026-04-09T13:36:17Z

On Thu, Apr 09, 2026 at 03:17:50PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> On the official case the red LED is named ERR, the blue LED is named ACT.​​​​​​​​​​​​​​​​
> Reflect these labels in function and set them default off.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
> index 759f608d1081..7f770a76775a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
> @@ -61,14 +61,16 @@ gpio-leds {
>
> led_red: sys-led-red {
> color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_FAULT;
> gpios = <&pca9555 15 GPIO_ACTIVE_HIGH>;
> - default-state = "on";
> + default-state = "off";

Just drop 'default-state' entirely from both nodes.

> };
>
> led_blue: sys-led-blue {
> color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_ACTIVITY;
> gpios = <&pca9555 14 GPIO_ACTIVE_HIGH>;
> - default-state = "on";
> + default-state = "off";
> };
> };
>
> --
> 2.43.0
>