From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32084F36B9A for ; Fri, 10 Apr 2026 00:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vWOxWIGu7N6pJTZUHOoiOeTmwWaWLSSicKatc+knzaM=; b=jIekygojhkQF3U1ou4IhVAx3Zl Eul4OBKyam6+bK/UXIG4bwQBBMl+wANW68NG2LFaDYE0Kc9sk3woCCMWNTUos1DKnct7vTRz9CaQP f0YceBujchzfy0V0o59lbOlPKPnAKQtksLukPAy0de+SmWeCpfqLngzeCCd9WR4kHT/R4afnUgXYm 1G9o3CwouOg0dOMRDoqw72GHsZz93zjnCEZN17Bn8WEUqcOqQXS77sPvb0zwKtic2PEoHVcM2rW3I loeccqU+VlWPrkn3bmzfOZHxlUaUXtIpVzlOMCAbkHKlk9JyUYi56u/jeFcpsrex9aLjMKv3gQ0Xn lA95nDLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAzbQ-0000000BMgK-3Nf4; Fri, 10 Apr 2026 00:20:04 +0000 Received: from mail-westcentralusazlp170100005.outbound.protection.outlook.com ([2a01:111:f403:c112::5] helo=CY7PR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAzbO-0000000BMfx-19Pd for linux-arm-kernel@lists.infradead.org; Fri, 10 Apr 2026 00:20:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UKULn7uY+Ed5Q7RuxypD2IFsbvOb1jC4xWYBpakCqceV5e8akEY1PVeu7fqLjaTx+BMC/Kxok5FtXP6qB4aF8jBxDVLIwivbQFQUTyllzS5nCFHoyQIGuhAZNKsMpMuQPY3dDqF8C3Wieea198DCAPudTc7wD5UEo9ZKkfsWbjmDMZ6glLqVmJkkEHWQEVg40H23XZYwTt9bGKCjsxyQKl9xTGidoO5qGLxh7SDKwiwv9Mjtj2GwcRXsPqAWR0IGkV4Yv52vXewNOk4Ihdh6u/o5hv2H0+czs1BMfxCJyk/JLC/v4yucUAbW5hrmot74S2kTgYlYVqCVRaifonARIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vWOxWIGu7N6pJTZUHOoiOeTmwWaWLSSicKatc+knzaM=; b=LynAa3cXK7zI5mREbUeUuBo6jSgYHsbkpctvxGHzWJV24QL6wncDgu2UuTgPzb2ghVOBlQNHTcZCoUoaEkidFhLGb/ehRvlKkvG35EWHak6tEji0GLaXMGnhkHN82U9JETjBlZNPLApYzrdcg+nkk1zej557z0Rh0coOTVO9uBzdWN/lvHugjiNRT+NaNHj2KKUApg/1CnJsDZydmMyHb9amb2l4eEBcUXQBiCbskX4hkvWD1TOSN0YECBoxNyZu4qr1Wf+9rC8JKq2R14puYceNj3UejSAtNvmIoK4Xx7PQFUqVqt8ZwVJIpF9BKseuxmzM+H8LopSS52mX328HEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vWOxWIGu7N6pJTZUHOoiOeTmwWaWLSSicKatc+knzaM=; b=hAWO+cpIWcPUseeROoR9jcQnf30x1hhjfKNMP3JiF6OSI6y+juKFD2Wz298ITsFPpQnXNxDuU7jDotya3ZFcp2jUX7K3P9VPi4U0kXmgaGzZ5QxVVajVi0p17gr47D88PylMEy2S+n2SiSKCS253wECb8dXgu4EIqxrt/kO9OrC1vuL8quS4oO8cve9C6UegrWSvnInXEEor7tM3AahyotRbD+giIyGvupPh2Lr6IazKNeRydeCksfEUAqnw2N2Ni1BZKqqJFvWIMgl8q0iKzyfhyYZMKviFPC5DfjrIHD037aGnDPf8u4niSb1nhhb/5cTZrWKXOrMyqUURmJYmkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by BN7PPF9C6E5285F.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6db) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.42; Fri, 10 Apr 2026 00:19:55 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9791.032; Fri, 10 Apr 2026 00:19:54 +0000 Date: Thu, 9 Apr 2026 21:19:53 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jpb@kernel.org, praan@google.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, jonathan.cameron@huawei.com Subject: Re: [PATCH v4 08/10] iommu/arm-smmu-v3: Allocate INV_TYPE_S2_VMID_VSMMU in arm_vsmmu_init Message-ID: <20260410001953.GB3357077@nvidia.com> References: <05dd00dcb2f0d077f59bcbccac1820534ad7b5cf.1773949042.git.nicolinc@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05dd00dcb2f0d077f59bcbccac1820534ad7b5cf.1773949042.git.nicolinc@nvidia.com> X-ClientProxiedBy: MN2PR19CA0072.namprd19.prod.outlook.com (2603:10b6:208:19b::49) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|BN7PPF9C6E5285F:EE_ X-MS-Office365-Filtering-Correlation-Id: 042d193c-bf4b-4066-63d7-08de9696e3f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|3613699012|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ztxRitG/OfpEr0YdbZH2Gq4PGq0ZxdpTnpZbaecXT43IBnYxW9qhNtoJ6stsKZVMpae9HBq7NuR+NsgIgygWzivo2isEfQjGPuHce9RuZVjl952F6vS5ywFDjlZiUeTrwWn9ZlX1hSJh3CVLvIlaGycDhOtKyN4FkvvfwSrrpqeG6otq7aY3yojC8ArlzZtrcOnGTEstu5tZhi8FEIxzQuLnNWa2CVrkJCvvwbyfEjfha+bivSeCcn3uitz08f3+xpIr9LroA4L++yaC1UFSdu7Z8L6w0rCMJ176J+IwmeURYqKUd/j0JIuT6fEFTzCf294Sccq9Xm+a5WDaNI5GNqVspk46+739GAtJnI+VwVVtBCORGsg+kq4U4oBhgzRZaByBTZUOfGZl4ZmljIFfHmwQVOLi/utX5yN66AtGFOd1G6z00niQBQXbi4clrGteJLz+xaWJ+BVItKNCMmUs5M8pOijpi+BMDj3wMrkxxcXOPSRuO78EkOPcHjeqUY9n5GCZLuOFdAdvGjCz0i4hQYmq5hdynfZinu/eOVyfBETA28rVmDIQ2STmT2namW7B0yklDVDESSvwjjvwNXi0HopaLruKheEWNqPwy1HcMSXjwGmAOCrS9qNCrxl339o/fo1Nbw6qCEC4a5hPWT57e829x2WLCsT/nBmeDwbMW29nFdNRfPItb7ZFS+FwZTYST1cPhZFPLJ5dKx8cz5P+Dlz4G8O+O1rfmyshPwbqZGMqkcAgVBDqY1GGu49Uf9v2vTq17H6M0XjRXeftHly5rQjzXBU0f1irWVOcLDALDaE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(3613699012)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Eb9Lqcdxa6444ntevo9cOIYnMyE4c0P6MYk98yCoJb/8jteisfDBMJvi1lxU?= =?us-ascii?Q?LWAwMKFul9iw1WF8BA0+t/8bDjzwbidzxetlgOK0fbU+VFWPjAG4+/P13XBF?= =?us-ascii?Q?P6t8C+VMqV0vvtlwDGYJpPRlyRVizvAZwmcqiwl9/tiwiLAfQviitK2cvHDW?= =?us-ascii?Q?QjSqbBA8HLM8tKrqJvRLAt5V5mu38aJ+IlOF6HIBOcQgVpqhWyo/cX3pw5lz?= =?us-ascii?Q?cxPs/UclBO60zGrKMkRM8QcMh4HBISkR+GgwAbwcW6Ohe+Dj9aDZwQJE3E/k?= =?us-ascii?Q?EshgJhjdqDbjnti1hKzpOo/DTyTNHTDuh0tA8Sv+wlwF7eE1zVNOxdzxNOWe?= =?us-ascii?Q?/Z30CTLICWb6aULQavjaRPWSEcmY3xjTHVdMm24NYFqlltbQDIzfgsCI4o3r?= =?us-ascii?Q?WAhYFWF0Ty2fMcBLC0gnmwL0maKrHUrqDkq9youHAgWy/THNSiJ0FxLpxi4v?= =?us-ascii?Q?EB5Cx2sEmk/I40G26gPbxjldPB3rrKP19m0ggOyJDojsW9ksDzcrxHHLjcQ8?= =?us-ascii?Q?2MyxwbJCsgXeagq6Lp/VyzIvlvNqnpqz/4seKiLVTgwtep3TTHYbSZYkf5br?= =?us-ascii?Q?qpIqrwo/sWZKBwWnpvb9q2zYptYGnvpmiGF+Rytgpn9eLSfA2B6B8Y1PqS9U?= =?us-ascii?Q?/7/a1B4BpXcQGRvy9pW2dSbeh/bYrSonWx0wNLOJoC2ZX9FDUewa0G0pMmk5?= =?us-ascii?Q?bT+xlA/ZWSBeS14yjxvfY2H2AWuS3vkEZcliytXi8Covk/oBErsbyRTOdxb7?= =?us-ascii?Q?mZ4rubEsPaOmQNhbzZmEB+2Hj1+Iu+n9kP+DYBBhoQTlEwcm5Exhl4qF84HM?= =?us-ascii?Q?jajVgv4s8ACYKdZqTj+JnYWp9TKWgA9BPIadQGjbW+P2ESwvPlZmi0pdQbBu?= =?us-ascii?Q?aYhQuRDE0PduO7s/aeWG6shFCrv+mx06JuBd/sUPOKlqLWEoEHZEsLoOyFoK?= =?us-ascii?Q?nMb2tq15EbW8iiD5l5HViuIw/6i9u7ovrCSNoEgxl4mPkW0ssf6SDuszeGJc?= =?us-ascii?Q?0JtaIULZgdAr7Ad3t+1rc6oUp8tSkGhI5Nz6cIcR+cqouWdqb906y67yG+D8?= =?us-ascii?Q?HyKOk/bLWM1HdlB/jvsfGthD0wIpRbTZYzBjN2TQ6JauAalp4w/BBxh8UNE9?= =?us-ascii?Q?97W+w1jWYtBRylFMK8Nje/4a+GdWmqv5RiELRpI55ZvLuDO7OBO4+euL8QEA?= =?us-ascii?Q?Y372bWISB5+lgKQKKRPhk3qszrWaU4ppGo1ICZ2J9i+2QWU16R443XRA2/gD?= =?us-ascii?Q?2gM6last/gIFqQkSKJGfAih3xfZLU9FsnDUQUmiXDagHrSN7xPB73KubV6rH?= =?us-ascii?Q?1ZAQ0OIZJw/5MdstVcDNFqOok4RjWJBo7eznf2MIT/lbtyt1r+2zAdukxoUZ?= =?us-ascii?Q?M/XeLY++a2QjGixTqYKXfckQDWKRKQ5b8ce4X3mK/kM+MsSjnw5iFrosKuCL?= =?us-ascii?Q?gFhSDJ3qsx/1E9WWD7qolkNrhsLeAp9P0iMQOL05G7qccnE4iDP1ZYl1JAtL?= =?us-ascii?Q?mkdqyFbmwR00/aJHuuzr3hyscsSsx4gB/ZnVXm7LQi9Gf60P+io1kWs+B7Ew?= =?us-ascii?Q?6hSdkkp3ah0Kxwil60Q7s4m1P/Z9HVu2lfXyHkTSKmcMYP0IKSAe4yfd6ZEk?= =?us-ascii?Q?+c507Fav9+0GBFqsrNVMcm6sYXNnTmdYP/JjQ001Ai6mXvRkZhrTCsGf4cSA?= =?us-ascii?Q?XcfZMoOLhSKXUIGMfPxcAdzgLRzm70U8OqjoEvflZ7m8oZsy?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 042d193c-bf4b-4066-63d7-08de9696e3f4 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2026 00:19:54.9184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a2AHd9UNFAapS9cvavtyU56spzzKjhugbGTodS4bPjt5SsGYd4pO/bhYni2x/zDF X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPF9C6E5285F X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260409_172002_317758_8F5AC978 X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 19, 2026 at 12:51:54PM -0700, Nicolin Chen wrote: > VMID owned by a vSMMU should be allocated in the viommu_init callback for > - a straightforward lifecycle for a VMID used by a vSMMU > - HW like tegra241-cmdqv needs to setup VINTF with the VMID > > Allocate/free a VMID in arm_vsmmu_init/destroy(). This decouples the VMID > owned by vSMMU from the VMID living in the S2 parent domain (s2_cfg.vmid). > > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 + > .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 26 ++++++++++++++++--- > .../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 1 + > 3 files changed, 25 insertions(+), 3 deletions(-) Yeah, this is exactly right now.. The vmid exists for the duration of viommu and gets installed in the invs list when the s2 is actually attached to a device. Reviewed-by: Jason Gunthorpe Jason