public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Rob Clark <robin.clark@oss.qualcomm.com>,
	 Dmitry Baryshkov <lumag@kernel.org>,
	 Abhinav Kumar <abhinav.kumar@linux.dev>,
	 Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 Xinliang Liu <xinliang.liu@linaro.org>,
	Tian Tao <tiantao6@hisilicon.com>,
	 Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	 Sumit Semwal <sumit.semwal@linaro.org>,
	 Yongqin Liu <yongqin.liu@linaro.org>,
	John Stultz <jstultz@google.com>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	 Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	 Michal Simek <michal.simek@amd.com>
Cc: Hui Pu <Hui.Pu@gehealthcare.com>,
	Ian Ray <ian.ray@gehealthcare.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	 linux-arm-kernel@lists.infradead.org,
	 Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: [PATCH 03/10] drm/hisilicon/kirin: switch to of_drm_get_bridge_by_endpoint()
Date: Mon, 13 Apr 2026 15:58:35 +0200	[thread overview]
Message-ID: <20260413-drm-bridge-alloc-getput-panel_or_bridge-v1-3-acd01cd79a1f@bootlin.com> (raw)
In-Reply-To: <20260413-drm-bridge-alloc-getput-panel_or_bridge-v1-0-acd01cd79a1f@bootlin.com>

This driver calls drm_of_find_panel_or_bridge() with a NULL pointer in the
@panel parameter, thus using a reduced feature set of that function.
Replace this call with the simpler of_drm_get_bridge_by_endpoint().

Since of_drm_get_bridge_by_endpoint() increases the refcount of the
returned bridge, ensure it is put on removal. Here the bridge pointer is
only stored in a temporary variable, so a cleanup action is enough.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index e80debdc4176..7b2ef5ed2c40 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -778,7 +778,7 @@ static int dsi_host_init(struct device *dev, struct dw_dsi *dsi)
 static int dsi_bridge_init(struct drm_device *dev, struct dw_dsi *dsi)
 {
 	struct drm_encoder *encoder = &dsi->encoder;
-	struct drm_bridge *bridge;
+	struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
 	struct device_node *np = dsi->dev->of_node;
 	int ret;
 
@@ -786,7 +786,7 @@ static int dsi_bridge_init(struct drm_device *dev, struct dw_dsi *dsi)
 	 * Get the endpoint node. In our case, dsi has one output port1
 	 * to which the external HDMI bridge is connected.
 	 */
-	ret = drm_of_find_panel_or_bridge(np, 1, 0, NULL, &bridge);
+	ret = of_drm_get_bridge_by_endpoint(np, 1, 0, &bridge);
 	if (ret)
 		return ret;
 

-- 
2.53.0



  parent reply	other threads:[~2026-04-13 13:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 13:58 [PATCH 00/10] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-04-13 13:58 ` [PATCH 01/10] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-04-13 14:58   ` Dmitry Baryshkov
2026-04-13 17:07     ` Luca Ceresoli
2026-04-13 17:56       ` Dmitry Baryshkov
2026-04-14  6:44         ` Luca Ceresoli
2026-04-13 13:58 ` [PATCH 02/10] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-04-13 17:57   ` Dmitry Baryshkov
2026-04-13 18:10     ` Dmitry Baryshkov
2026-04-13 13:58 ` Luca Ceresoli [this message]
2026-04-13 13:58 ` [PATCH 04/10] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-04-13 13:58 ` [PATCH 05/10] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-04-13 18:01   ` Dmitry Baryshkov
2026-04-13 18:12     ` Dmitry Baryshkov
2026-04-13 13:58 ` [PATCH 06/10] drm/bridge: lt9611: " Luca Ceresoli
2026-04-13 18:18   ` Dmitry Baryshkov
2026-04-13 13:58 ` [PATCH 07/10] drm/bridge: adv7511: " Luca Ceresoli
2026-04-13 18:17   ` Dmitry Baryshkov
2026-04-13 13:58 ` [PATCH 08/10] drm/bridge: lt8713sx: " Luca Ceresoli
2026-04-13 18:18   ` Dmitry Baryshkov
2026-04-13 13:58 ` [PATCH 09/10] drm: zynqmp_dp: " Luca Ceresoli
2026-04-13 13:58 ` [PATCH 10/10] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-04-13 18:04   ` Dmitry Baryshkov
2026-04-14  7:02     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260413-drm-bridge-alloc-getput-panel_or_bridge-v1-3-acd01cd79a1f@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=Hui.Pu@gehealthcare.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=ian.ray@gehealthcare.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jesszhan0024@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jstultz@google.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=michal.simek@amd.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tiantao6@hisilicon.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=xinliang.liu@linaro.org \
    --cc=yongqin.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox