From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9775BF34C58 for ; Mon, 13 Apr 2026 14:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=trJIEY67H9uZ+co0EcS63rOb0/v8Mb8n06Fy2pMT2Js=; b=Zys3JptnrvK5JiiHNgFrNizFqR Tos9qviwf+S1lgebtJyPby+Cdpmi9mud9i3S3XHMN804nty6bpoczJjBI6p4QldG3LwPbJJvjWJZ2 s0NoLKeqBumJa0BTiPvYjywr0X5UGU9AVwFRZw/W5mzOA2jmyj+zSHczro29No0jH0blmahnJnif3 a/UxGBFI+J0prRQZoIR9WuGBNjCM4a2SR3dNzdOI37ERkipDursvqidqN3tvBC0HbaUz0RWlkWSK3 JX7k9Vge8Qli8ppT5jOzHHONiN7uKwDais8/dyQPkdOT5BRExHePfzeYUX79UjR9OiVtr6Gs1FFM+ IOTeTaMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCI9C-0000000FqWH-1uBr; Mon, 13 Apr 2026 14:20:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCI97-0000000FqTG-1ECv for linux-arm-kernel@lists.infradead.org; Mon, 13 Apr 2026 14:20:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E796735A2; Mon, 13 Apr 2026 07:20:06 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 136B73F641; Mon, 13 Apr 2026 07:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776090012; bh=5keG86JXaQZH8XK4oeWKSeSq/8yUd4MWcoQDxbVjVG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XRMwA1QV7KmpMr/Ma7d6PEueNWxSAFaL8nBkHis8zTnoxYg+IvlytzK6HVkBFp5Ax 9tDnLo5vo4qbUbFiWYNM6hYvLLnohXfOJh4RcvSWLSUt+U4PWJfAPK48Ex2ZrAGbYf LjdrInm0PMdUR7fVEveBd1d1QRleGUEsDsTh9nCg= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v4 3/9] coresight: etm4x: fix leaked trace id Date: Mon, 13 Apr 2026 15:19:56 +0100 Message-Id: <20260413142003.3549310-4-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413142003.3549310-1-yeoreum.yun@arm.com> References: <20260413142003.3549310-1-yeoreum.yun@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260413_072013_371192_E5F36561 X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(), the trace ID may be leaked because it is not released. To address this, call etm4_release_trace_id() when etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(). Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index 8ebfd3924143..1bc9f13e33f7 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -918,8 +918,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset); if (cfg_hash) { ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset); - if (ret) + if (ret) { + etm4_release_trace_id(drvdata); return ret; + } } raw_spin_lock(&drvdata->spinlock); -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}