From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B51CAF43848 for ; Wed, 15 Apr 2026 16:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SAVDQ1imx7THwEhqS9YZtoYA+llPEvd9D4Nj5Cvx+Lg=; b=hR3bJsfl21dRhGmcJT6D21Ts9a X0lrgYy5btD7nOeG6sihiPnFB4Pz/30M4jGQt9jaqH8NkDSd1dU6HKMLjBSgH973PBBA2dGhwDQhI HKTmnfMVU/Tr1A5P8B3REBMz8WDkfp89YQmWZmCVx5DlRNbD/0sJdnyZvK96Nb2KSa78DH7oyKerg vbrkKc8I437hwMGo4QNVQWtnc6W+pqE6GNCd6WWo/Z3BhSZENlFJ6fo0cRFipbYRol2OrUVM+Bc5F DQgASGSPjVeclZ4Jx1lf6NiR/jYZcYCdcLd5M41EsVA32X9Cbw3ejqE6+tTHHcE+3WMtNcxhsBqOd ITQSIVUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wD3Wd-00000001PTM-24C5; Wed, 15 Apr 2026 16:55:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wD3WY-00000001PS9-3SL3 for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2026 16:55:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CE8B32FB; Wed, 15 Apr 2026 09:55:28 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6950F3F7D8; Wed, 15 Apr 2026 09:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776272134; bh=+h8s2k45gr74tkKaNYCUe+TMlKHAxaWDuG4e1iGbico=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IC17eKADy/X1hdMMm6YM6fdGw6N6LrhFg6SD704r7cS5A3uxF1yD4ildGMbcPnbuF FZeO91sbHf2V8DAVeq4xeV1Y9Vt+hMzX+2vYfT3HoI8e1u6F/2yL7jx/t0zyKWc7Hj gjWKdGJ1nYQwdA+PuypqXwG9UqgHR4njT3IPNgCE= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v5 01/12] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Date: Wed, 15 Apr 2026 17:55:17 +0100 Message-Id: <20260415165528.3369607-2-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260415165528.3369607-1-yeoreum.yun@arm.com> References: <20260415165528.3369607-1-yeoreum.yun@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260415_095534_899034_8D99008A X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to Embedded Trace Macrocell Architecture Specification ETMv4.0 to ETM4.6 [0], TRCSSPCICR is present only if all of the following are true: - TRCIDR4.NUMSSCC > n. - TRCIDR4.NUMPC > 0b0000. - TRCSSCSR.PC == 0b1. Comment for etm4x_sspcicrn_present() is align with the specification. However, the check should use drvdata->nr_pe_cmp to check TRCIDR4.NUMPC not nr_pe. Link: https://developer.arm.com/documentation/ihi0064/latest/ [0] Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index d565a73f0042..74b7063d130e 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -89,7 +89,7 @@ static int etm4_probe_cpu(unsigned int cpu); static bool etm4x_sspcicrn_present(struct etmv4_drvdata *drvdata, int n) { return (n < drvdata->nr_ss_cmp) && - drvdata->nr_pe && + drvdata->nr_pe_cmp && (drvdata->config.ss_status[n] & TRCSSCSRn_PC); } -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}