Re: [PATCH v3 4/6] dt-bindings: soc: mediatek: devapc: Add bindings for MT8189

Krzysztof Kozlowski
2026-04-16T08:57:07Z

On Thu, Apr 16, 2026 at 11:12:07AM +0800, Xiaoshun Xu wrote:
> Extend the devapc device tree bindings to support the MediaTek MT8189
> SoC. This includes:
>
> - Adding "mediatek,mt8189-devapc" to the list of compatible strings.
> - Introducing the "vio-idx-num" property to specify the number of bus
> slaves managed by devapc.
>
> These changes enable proper configuration and integration of devapc on
> MT8189 platforms, ensuring accurate device matching and resource
> allocation in the device tree.

Pointless paragraph. Would you write a commit which does not enable
proper configuration?

>
> Signed-off-by: Xiaoshun Xu <xiaoshun.xu@mediatek.com>
> ---
> .../devicetree/bindings/soc/mediatek/devapc.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml b/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> index 99e2caafeadf..06a096440331 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> @@ -14,13 +14,14 @@ description: |
> analysis and countermeasures.
>
> maintainers:
> - - Neal Liu <neal.liu@mediatek.com>

Your commit said what the change is doing. It's pointless because we see
it in the diff. Except that we don't...

> + - Xiaoshun Xu <xiaoshun.xu@mediatek.com>
>
> properties:
> compatible:
> enum:
> - mediatek,mt6779-devapc
> - mediatek,mt8186-devapc
> + - mediatek,mt8189-devapc
>
> reg:
> description: The base address of devapc register bank
> @@ -30,6 +31,10 @@ properties:
> description: A single interrupt specifier
> maxItems: 1
>
> + vio-idx-num:

Nah, compatible defines it. Please follow standard rules for bindings,
see writing-bindings doc.

> + description: Describe the number of bus slaves controlled by devapc
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> clocks:
> description: Contains module clock source and clock names
> maxItems: 1
> @@ -42,8 +47,6 @@ required:
> - compatible
> - reg
> - interrupts
> - - clocks
> - - clock-names

Why?

This commit explains nothing and makes some random-looking code changes.

Best regards,
Krzysztof