From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F78F94CB3 for ; Tue, 21 Apr 2026 22:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:Mime-Version:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=n45LXp1+vniYlrGp0e6dQKzFc3A3nIm5Tab9EOuG3Yg=; b=a2wOGy739/lH2avJkTbi6KC3k9 zKKqAIAZyyReI6dh5TK+hrVSIsu9V8i3kcwUpgzzZr8A/Al9nxnuT+lZCDNR33MJEE0F5CJQlNXBd f+5JfukFUcYFfltrbZ/HAs+sRTcIh2lDHqPPiqQ8GtOahX/Z4HpHANuYzXd+JRxWjNp/UCIDduFG4 4KSpnzJgkv7NkztzZzaoW/Cv3mo7q/wH7EiIdsj+i68b3UYPjGbhx63x8cWtnVbmo45njCn/6/XQM wN4bf7CAXGO5fD+WZOSr/gQLIG8pjz1DX1MABQyQaPPo1r79UZNhE4nJz7wGQ3k5f9j+1tmkHCFq7 rdBlOLMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFJwy-00000009NL7-2iAC; Tue, 21 Apr 2026 22:52:12 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFJwv-00000009NJg-3UNj for linux-arm-kernel@lists.infradead.org; Tue, 21 Apr 2026 22:52:11 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-2b24e9b4d82so50737645ad.1 for ; Tue, 21 Apr 2026 15:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776811927; x=1777416727; darn=lists.infradead.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=n45LXp1+vniYlrGp0e6dQKzFc3A3nIm5Tab9EOuG3Yg=; b=sdiqkYBE8BS9jEVC7syFXWg5qYd9I2JKMfXY1lAAMEc/jG+MMh5V+fe3Y8/1IaiCtH YDL8VqCYYG4+tQ9rF61/aCVMteqZVZ+OMZ1vT3Mul0j+65wZ+XIbIKDdM5H4ap4ZBECf mQsbYydF64yx3uTY0NfrVls9VDUBXYMgvbeuLTRckQex9dJdOCq9HQjONdlbwiG+WMMB aS8eMXfF+ZHB6YnxDcNdUKvJTH51D39cJYviTKqREYvshk1yJiVLyzwwMLTJmV6A9Mkk xYcpS/Djv/zQrQsPWQZwsR0FsK+0sdkl3Xh6k73MPiKqTg02UZiqovjekdFxe6c/Pxx6 xABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811927; x=1777416727; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=n45LXp1+vniYlrGp0e6dQKzFc3A3nIm5Tab9EOuG3Yg=; b=SEnuUZXfYZzJNA8v5cs04RrifxEQU0T4j0Ic3tNk6jelFxkJBoMN7Ye2wxBYnNxStK SzOReY3dD/018UmPaP1EziDOKoRHWivIEYKwddEmdpUENLK+uyCOGMjERvB8MAynecSp mlSgHb7rOt626hebvI8u8WquQQLsfTEQLAyJQypy2EZfzjAduLoYnSH171Wgd1K1pfi0 IN9D/rd8UC/j6kvRmrRfRXVwzii2XBGPsu6yKi4d6AITC7vfuEEDueU0kxzMLPPx4xKV BF+ZNYyFyFrolD6zXHUu2KLGh2l/baqO4Iw7Zaaga2OkwoIgFQ1VF3urgSvlSKpM18ua p+aQ== X-Forwarded-Encrypted: i=1; AFNElJ8qls2XmQhP86DOmvTcYxy/RKkU/JOqzl33nZemfxei49DX99VAHty4pTDWR06A33ZbIcZIZsAj4vIEj2PAK6nK@lists.infradead.org X-Gm-Message-State: AOJu0YzjM2IqHWgLFJiwOY5+os7WXBtuDulmpc/1aqYg2xEfWW6YjoMh ICdvUfBn+gErxbV6+zUftl/iPzfKzWmPvwHMJnh21RMt7H/mWyQID6OgHPDhHdMkb4LLodDBt9N iMJ12PkfjgwQVE2MqiQxHBFkyTQ== X-Received: from pfna24.prod.google.com ([2002:aa7:80d8:0:b0:82f:5576:285b]) (user=dylanbhatch job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4b01:b0:82f:49b5:cfc3 with SMTP id d2e1a72fcca58-82f8b551df5mr16857789b3a.18.1776811927282; Tue, 21 Apr 2026 15:52:07 -0700 (PDT) Date: Tue, 21 Apr 2026 22:51:52 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.54.0.rc1.555.g9c883467ad-goog Message-ID: <20260421225200.1198447-1-dylanbhatch@google.com> Subject: [PATCH v4 0/8] unwind, arm64: add sframe unwinder for kernel From: Dylan Hatch To: Roman Gushchin , Weinan Liu , Will Deacon , Josh Poimboeuf , Indu Bhagat , Peter Zijlstra , Steven Rostedt , Catalin Marinas , Jiri Kosina , Jens Remus Cc: Dylan Hatch , Mark Rutland , Prasanna Kumar T S M , Puranjay Mohan , Song Liu , joe.lawrence@redhat.com, linux-toolchains@vger.kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Randy Dunlap Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260421_155209_906945_B76FDD2C X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Implement a generic kernel sframe-based [1] unwinder. The main goal is to improve reliable stacktrace on arm64 by unwinding across exception boundaries. On x86, the ORC unwinder provides reliable stacktrace through similar methodology, but arm64 lacks the necessary support from objtool to create ORC unwind tables. Currently, there's already a sframe unwinder proposed for userspace: [2]. To maintain common definitions and algorithms for sframe lookup, a substantial portion of this patch series aims to refactor the sframe lookup code to support both kernel and userspace sframe sections. Currently, only GNU Binutils support sframe. This series relies on the Sframe V3 format, which is supported in binutils 2.46. These patches are based on Steven Rostedt's sframe/core branch [3], which is and aggregation of existing work done for x86 sframe userspace unwind, and contains [2]. This branch is, in turn, based on Linux v7.0-rc3. This full series (applied to the sframe/core branch) is available on github: [4]. Ref: [1]: https://sourceware.org/binutils/docs/sframe-spec.html [2]: https://lore.kernel.org/lkml/20260127150554.2760964-1-jremus@linux.ibm.com/ [3]: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/log/?h=sframe/core [4]: https://github.com/dylanbhatch/linux/tree/sframe-v3-with-v3 Changes since v3: - (Jens) Clean up patch summaries. - (Jens) Rename SFRAME_LOOKUP -> UNWIND_SFRAME_LOOKUP to fit existing naming convention. - (Randy) Correct typo errors in new config options. - (Jens) Move unwind types to a new unwind_types.h to match their usage. - (Jens) Update KERNEL_[COPY|GET] to use label-based error handling like their userspace counterparts. - (Jens) Rename SFRAME_UNWINDER -> HAVE_UNWIND_KERNEL_SFRAME and ARCH_SUPPORTS_SFRAME_UNWINDER -> ARCH_SUPPORTS_UNWIND_KERNEL_SFRAME to match existing naming convention. - (Jens) Move HAVE_UNWIND_KERNEL_SFRAME config option to arch/Kconfig. - (Jens) Rename/move extern definitions of __[start|end]_sframe into include/asm-generic/sections.h. - (Jens) Fix up CFI annotations at kernel entry. - (Jens) Fix error path for unsorted FDE lookup. - (Jens) Zero-out module sframe_section before init. - (Jens) For SFRAME_VALIDATION, use an arch-specific function-address validation helper so that .rodata.text can be correctly handled on arm64 vmlinux. - (Jens) Fixup and better comment kernel stacktrace code. Changes since v2: The biggest change from v2 is the switch from adding a dedicated, in-kernel sframe-lookup library, to refactoring/using the existing library developed by Josh, Jens, and Steve. Consequently, this series now depends on Sframe V3, though this upgrade would likely have been necessary anyway. Below is a full accounting of the changes since v2. - (Josh) Add stricter reliability checks during unwind. - (Puranjay, Indu, Jens) Update to use a common sframe library with userpace unwind, thus resolving the need to support SFRAME_F_FDE_FUNC_START_PCREL, added in binutils 2.45. - (Jens) Add check for sframe V3, thus resolving the prior need for V2 and SFRAME_F_FDE_FUNC_START_PCREL support. - (Will) Add ARCH_SUPPORTS_SFRAME_UNWINDER, remove SFRAME_UNWIND_TABLE - (Indu) add support for unsorted FDE tables, allowing for module sframe lookups. - (Mark) Prefer frame-pointer unwind when possible, for better performance. - Simplify compile-time logic, adding stubbs when necessary. - Add support for in-kernel SFRAME_VALIDATION. - Rebase onto core/sframe (with v7.0-rc3 base) Dylan Hatch (7): sframe: Allow kernelspace sframe sections arm64, unwind: build kernel with sframe V3 info sframe: Provide PC lookup for vmlinux .sframe section sframe: Allow unsorted FDEs arm64/module, sframe: Add sframe support for modules sframe: Introduce in-kernel SFRAME_VALIDATION unwind: arm64: Use sframe to unwind interrupt frames Weinan Liu (1): arm64: entry: add unwind info for various kernel entries MAINTAINERS | 3 +- Makefile | 8 + arch/Kconfig | 27 +- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/module.h | 6 + arch/arm64/include/asm/sections.h | 1 + arch/arm64/include/asm/stacktrace/common.h | 6 + arch/arm64/include/asm/unwind_sframe.h | 29 ++ arch/arm64/kernel/entry.S | 23 + arch/arm64/kernel/module.c | 8 + arch/arm64/kernel/setup.c | 2 + arch/arm64/kernel/stacktrace.c | 246 ++++++++++- arch/arm64/kernel/vdso/Makefile | 2 +- arch/arm64/kernel/vmlinux.lds.S | 2 + .../{unwind_user_sframe.h => unwind_sframe.h} | 6 +- arch/x86/include/asm/unwind_user.h | 12 +- include/asm-generic/sections.h | 4 + include/asm-generic/vmlinux.lds.h | 15 + include/linux/sframe.h | 67 ++- include/linux/unwind_types.h | 46 ++ include/linux/unwind_user_types.h | 41 -- kernel/unwind/Makefile | 2 +- kernel/unwind/sframe.c | 410 ++++++++++++++---- kernel/unwind/user.c | 41 +- 24 files changed, 801 insertions(+), 207 deletions(-) create mode 100644 arch/arm64/include/asm/unwind_sframe.h rename arch/x86/include/asm/{unwind_user_sframe.h => unwind_sframe.h} (50%) create mode 100644 include/linux/unwind_types.h -- 2.54.0.rc1.555.g9c883467ad-goog