From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D62A8FC0342 for ; Thu, 23 Apr 2026 15:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EN4V9UR7DRre5LEE2+ZTpG14TXvnUwqmjv4/QNq2Ugs=; b=3rSS2xE4XkZwG9VXVhceT6OkCd LJ5fcK1OJ3ixvuwyxAXO6jLN/vkV02PWxeMjR08Hboh8Y+HEDhvKp7eQgmlz0rVWdHEGI8+cJjRd4 gN4t0BS7UNeH2sL2uRTS97GXAtLxOxJCD27FWxixvI8qMFde1vXmR6B4rU4dMo3sZU6w1XcSfWgNH FQCo34B93GgWPqm6Fygr+bYyXrK108lGQ4uwJsgoSXqtzivzPbftw4aV3Z1cPxS3fiUiEwLhEEy6e YhCKduFIwKpEqrjmvzsHS3hos7V3TWPzQhCwFDJsmqNdX+wJjWtbUXKDuo0PCsrVBoTWeGbM+5HwM Iu/u4A5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFvtU-0000000BsYT-00EG; Thu, 23 Apr 2026 15:23:08 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFvtP-0000000BsUT-1g1D for linux-arm-kernel@lists.infradead.org; Thu, 23 Apr 2026 15:23:04 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so48847105e9.3 for ; Thu, 23 Apr 2026 08:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776957781; x=1777562581; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EN4V9UR7DRre5LEE2+ZTpG14TXvnUwqmjv4/QNq2Ugs=; b=tC7mL+3/WPssR5PqjHS6P8pP9cWlEu/xB+KgXYaHmi99tj16IA6bvA0d8krTBAOoe1 AkZpFRYilKgWOpVSQuU7uBBX8DWDhW7Zl6fwyfCPDUx9GuD/mJXUFYZYavufb1na4NVY elOwHXcmzjMdpQLfHChg1nqfNzSQCTcY9sQyLB9HS1OneQPWw5zfMrbCcpR50UD62hKq 7DjuXlMLVTpUaIg8cU465vJ/TrANVao2lvEjee+uEevs1RjSxMNMYmvmMFJTLZGjqs/p di3Qqkrtk+GPkspEuGb9gBvVRJClIHmNI5Jl16xWlbTl0EQZhZ0QjkMnpXdC2Ch3KG6N bPig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776957781; x=1777562581; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EN4V9UR7DRre5LEE2+ZTpG14TXvnUwqmjv4/QNq2Ugs=; b=mouhXK/hvXi8tSAFfJdsfd05m/9LLfmJqEaJMMQk6dpcOViTeANv0w+/OBx04YLgUD nZSEmUjIkPV9LNPXNfZHkTPhj7qAJIy6s+yJVxyh03srArVVD01S1xSciPjnEH8yFFCR Gm80DkKFKMyN+bCeYsVZ0RupdclZGXUEu3w3Xpcwmggekt/ntLMTGe0i4xY9/KrfG6Ca ndZnpjL8alBXQVqDqRTBmKG56ef9qxC9hvko+C64fqOFgTOEle31N7bux/SdhfC7vvl+ kiy6Az30RNhq68Kic81Y2jwL5kMqmgjIsMbDTLQ2acb8Wsq/lXkRgUhjrQdVAnoXm4gC aS4w== X-Forwarded-Encrypted: i=1; AFNElJ+sGpp0OH0xU3e7my+m6Nb67npSpNNbCWmZYhaTQSHLZR3Zx7I5gS00MLmhqdn2RD2NqpwZudRJ/6NXZ4IUZd9J@lists.infradead.org X-Gm-Message-State: AOJu0YxqsMkM4N38BxvgGBqR73RzCl7nJBXoUrYQ3PIIBCWgZZWO/87R u+CQNoSdhQkMM2Z/W9z1UXGAyjcEJco9PrqF921+zONRHPNZViO7AjKMqFMy9ZfaJls= X-Gm-Gg: AeBDies5+GwRRJX/Wsx9sUQXFXezUPWx3STkin45350XM4/F7kCd9VusMWaobitw+fO KwRk/W4DWXiSB6ZDEJy3UHb+bgzs40dg44eLdFSRzmX9D3Kf/RYnseN63qcqysnVT/tiedwWSva USTE17aRWk7/cWwBl6ZrE8oJCw2mmWO91Ix5HdaPvf6hebEPIPin4W2vbZDCui3dfJrFRnk4qjV 383q24Znw0mbiDXT9qm7WFCYFN0JAuUj5no4zrAYmwXF1k1MH1gqziASN2o+EuhdBHwjwyTsreD j/M6ZzbBmSoWmxmig/B7pX+LVBTWxW0A4odpwAPgUr6MB06uBu7uMubzN697ObUZ7u0nCd4vp/N GATpGKZH2GTmmD0x8qtimTuEQjI9I2WZRYSd7OTYpN5uIFFIVm+ZPWBQQkyBC4Xje5Oj57ppNTD 9NRxxOs2dAoXgfi7wmDTfpsMuHBYViGY5Oav0Tn/qjr4gbQRgyDz327AKZQnYwLF8lYMjefzH8U A3jdKlw/KU2hFLxCA== X-Received: by 2002:a05:600c:a105:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488fb7786e4mr293834645e9.19.1776957781446; Thu, 23 Apr 2026 08:23:01 -0700 (PDT) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891f98728dsm90550755e9.23.2026.04.23.08.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 08:23:01 -0700 (PDT) From: Tudor Ambarus Date: Thu, 23 Apr 2026 15:22:52 +0000 Subject: [PATCH v4 04/11] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-acpm-tmu-v4-4-8b59f8548634@linaro.org> References: <20260423-acpm-tmu-v4-0-8b59f8548634@linaro.org> In-Reply-To: <20260423-acpm-tmu-v4-0-8b59f8548634@linaro.org> To: "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski , Alim Akhtar , Bartlomiej Zolnierkiewicz , Kees Cook , "Gustavo A. R. Silva" , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Daniel Lezcano , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Lee Jones Cc: willmcvicker@google.com, jyescas@google.com, shin.son@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, linux-clk@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776957778; l=4435; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=6Fhzjxw+vi8XP19sFgBxNUlkscVh4nTSp5CfK4gr45o=; b=m4fvvg7wwQHeVb0yPnYIqHEWlawnheJct73ayBmrt0vkfwIxMaAcSV6BGF7raasQPHx7k6W2Y gg/2Y1LaGpgDZ1YNuIQjhH8k3GmTU4AO/Uu4HrbMnBnxExDYFknXje1 X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_082303_469073_BB125701 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rename the `dvfs_ops` and `pmic_ops` members of `struct acpm_ops` to `dvfs` and `pmic` respectively. Since these members are housed within the `acpm_ops` structure and utilize the `acpm_*_ops` types, the `_ops` suffix on the variable names creates unnecessary redundancy (e.g., `handle.ops.dvfs_ops`). This cleanup removes the stuttering, leading to cleaner consumer code. Signed-off-by: Tudor Ambarus --- drivers/clk/samsung/clk-acpm.c | 8 ++++---- drivers/firmware/samsung/exynos-acpm.c | 4 ++-- drivers/mfd/sec-acpm.c | 6 +++--- include/linux/firmware/samsung/exynos-acpm-protocol.h | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/clk/samsung/clk-acpm.c b/drivers/clk/samsung/clk-acpm.c index d8944160793a..93667777094c 100644 --- a/drivers/clk/samsung/clk-acpm.c +++ b/drivers/clk/samsung/clk-acpm.c @@ -68,8 +68,8 @@ static unsigned long acpm_clk_recalc_rate(struct clk_hw *hw, { struct acpm_clk *clk = to_acpm_clk(hw); - return clk->handle->ops.dvfs_ops.get_rate(clk->handle, - clk->mbox_chan_id, clk->id); + return clk->handle->ops.dvfs.get_rate(clk->handle, clk->mbox_chan_id, + clk->id); } static int acpm_clk_determine_rate(struct clk_hw *hw, @@ -89,8 +89,8 @@ static int acpm_clk_set_rate(struct clk_hw *hw, unsigned long rate, { struct acpm_clk *clk = to_acpm_clk(hw); - return clk->handle->ops.dvfs_ops.set_rate(clk->handle, - clk->mbox_chan_id, clk->id, rate); + return clk->handle->ops.dvfs.set_rate(clk->handle, clk->mbox_chan_id, + clk->id, rate); } static const struct clk_ops acpm_clk_ops = { diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index e5c85d769d0a..a2cd54ee4589 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -627,8 +627,8 @@ static int acpm_channels_init(struct acpm_info *acpm) */ static void acpm_setup_ops(struct acpm_info *acpm) { - struct acpm_dvfs_ops *dvfs_ops = &acpm->handle.ops.dvfs_ops; - struct acpm_pmic_ops *pmic_ops = &acpm->handle.ops.pmic_ops; + struct acpm_dvfs_ops *dvfs_ops = &acpm->handle.ops.dvfs; + struct acpm_pmic_ops *pmic_ops = &acpm->handle.ops.pmic; dvfs_ops->set_rate = acpm_dvfs_set_rate; dvfs_ops->get_rate = acpm_dvfs_get_rate; diff --git a/drivers/mfd/sec-acpm.c b/drivers/mfd/sec-acpm.c index 0e23b9d9f7ee..9e15b260b8df 100644 --- a/drivers/mfd/sec-acpm.c +++ b/drivers/mfd/sec-acpm.c @@ -391,7 +391,7 @@ static int sec_pmic_acpm_bus_write(void *context, const void *data, { struct sec_pmic_acpm_bus_context *ctx = context; struct acpm_handle *acpm = ctx->shared->acpm; - const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic_ops; + const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic; size_t val_count = count - BITS_TO_BYTES(ACPM_ADDR_BITS); const u8 *d = data; const u8 *vals = &d[BITS_TO_BYTES(ACPM_ADDR_BITS)]; @@ -411,7 +411,7 @@ static int sec_pmic_acpm_bus_read(void *context, const void *reg_buf, size_t reg { struct sec_pmic_acpm_bus_context *ctx = context; struct acpm_handle *acpm = ctx->shared->acpm; - const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic_ops; + const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic; const u8 *r = reg_buf; u8 reg; @@ -430,7 +430,7 @@ static int sec_pmic_acpm_bus_reg_update_bits(void *context, unsigned int reg, un { struct sec_pmic_acpm_bus_context *ctx = context; struct acpm_handle *acpm = ctx->shared->acpm; - const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic_ops; + const struct acpm_pmic_ops *pmic_ops = &acpm->ops.pmic; return pmic_ops->update_reg(acpm, ctx->shared->acpm_chan_id, ctx->type, reg & 0xff, ctx->shared->speedy_channel, val, mask); diff --git a/include/linux/firmware/samsung/exynos-acpm-protocol.h b/include/linux/firmware/samsung/exynos-acpm-protocol.h index d4db2796a6fb..b206efa62be6 100644 --- a/include/linux/firmware/samsung/exynos-acpm-protocol.h +++ b/include/linux/firmware/samsung/exynos-acpm-protocol.h @@ -36,8 +36,8 @@ struct acpm_pmic_ops { }; struct acpm_ops { - struct acpm_dvfs_ops dvfs_ops; - struct acpm_pmic_ops pmic_ops; + struct acpm_dvfs_ops dvfs; + struct acpm_pmic_ops pmic; }; /** -- 2.54.0.545.g6539524ca2-goog