From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864EFFDEE43 for ; Thu, 23 Apr 2026 19:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4QFgyuOG5afpYS03fcWAL5CdSy2aihqhs+a6jM8HpD0=; b=wyFyoId0G0X4qVfcu1hjsABeBG rp+L47pRcyE3iFi9clL4nihnkzdvGAIl+seY4UpLTLApOCelsAR3pqcWk+XZrCm/+v4qs3eqlf+k0 780n2CwXHD6MAPL+U8mJBlQgmmOsgyUkD22SS/X0VEn/W6cmzl8OGK5US9kVcRiQiPXPXFF+Sh/Ja dfXdRiHRv1pQrMLKm104MVOYQzeVd5ymSfhOyaucbPrwzxXvXWmD32jklk8D/bx3g5i6mClF4qm35 zvI2oeddXpBadPjvS0ObmbVtLoeQaJqr+gjYc3WTcwHY3rClmBYlzgNiUcKXrncMK0THs9zClKYtE UaTwm9Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFzOv-0000000CCF2-487s; Thu, 23 Apr 2026 19:07:50 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFzOf-0000000CC08-0fMF; Thu, 23 Apr 2026 19:07:42 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1776971172; cv=none; d=zohomail.com; s=zohoarc; b=XzLe6VtS0EwRFd08VAH0a7fOTLXk0yuwDQg7l9F7A6QSkVKo5I9UWI0Yc/Epqb3PKhtjiFImhaxhrWq5CFbrkqtGmg1xe2J+4G1W/Ha25QPn07jozoNyztIp9XwWtBCvjypejie2x0IZ+VX2sLCTh4oJ/smcX/TcDndWciUYy38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776971172; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=4QFgyuOG5afpYS03fcWAL5CdSy2aihqhs+a6jM8HpD0=; b=abLQdNH/CknRTDoBk86JP4kBwI7MSVwVV8QxkzZWfRGYq1l9zEt04n+3ajzIBWmeRsjAaYDzen8L/Ia58WXKIT/mlPMgDw2xg9S/yLiSEDCcAhXwA5Y34XUBSIJiGEuVlQ2dsX6HkYaWMgDwSxJLtsWGwB0PDkGxyRHpjwLC1Io= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776971172; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=4QFgyuOG5afpYS03fcWAL5CdSy2aihqhs+a6jM8HpD0=; b=gMZVe/7aBcolkh+7DZxLovDaGnjImZc84QSBNd13KxdDK6DEsDbs+1dwHSwoq5nh 89xwyZT/nZAxbEQOH340hU4os8xtX0e9mIWHPFd9V0xk4YxEBX3hZOIifvGyCuX2lVx WYfECLZAcBaoTV/LUpkSKxJUxQxt+y7/a1hEYDiE= Received: by mx.zohomail.com with SMTPS id 1776971169865543.3743356543935; Thu, 23 Apr 2026 12:06:09 -0700 (PDT) From: Nicolas Frattaroli Date: Thu, 23 Apr 2026 21:03:41 +0200 Subject: [PATCH v14 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-color-format-v14-18-449a419ccbd4@collabora.com> References: <20260423-color-format-v14-0-449a419ccbd4@collabora.com> In-Reply-To: <20260423-color-format-v14-0-449a419ccbd4@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli , Andy Yan X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_120733_315151_9850C243 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For RK3576 to be able to output YUV422 signals, it first needs to be able to pick the right output mode in the display controller to do so. The RK3576 hardware specifies different output formats depending on the used display protocol. Adjust the written register value based on the SoC and connector, so other users of vcstate->output_mode don't have to care about this. Reviewed-by: Andy Yan Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 59d15bacf023..e76e00f0a530 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1702,6 +1702,22 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA && !(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT)) out_mode = ROCKCHIP_OUT_MODE_P888; + else if (vcstate->output_mode == ROCKCHIP_OUT_MODE_YUV422 && + vop2->version == VOP_VERSION_RK3576) + switch (vcstate->output_type) { + case DRM_MODE_CONNECTOR_DisplayPort: + case DRM_MODE_CONNECTOR_eDP: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_DP; + break; + case DRM_MODE_CONNECTOR_HDMIA: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_HDMI; + break; + default: + drm_err(vop2->drm, "Unknown DRM_MODE_CONNECTOR %d\n", + vcstate->output_type); + vop2_unlock(vop2); + return; + } else out_mode = vcstate->output_mode; -- 2.53.0