public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
To: Michael Riesch <michael.riesch@collabora.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	 Frank Li <Frank.Li@nxp.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Mehdi Djait <mehdi.djait@linux.intel.com>,
	 Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org, imx@lists.linux.dev,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	 Guoniu Zhou <guoniu.zhou@oss.nxp.com>
Subject: [PATCH v2 2/7] media: synopsys: Fix IPI using hardcoded datatype
Date: Thu, 23 Apr 2026 16:22:57 +0800	[thread overview]
Message-ID: <20260423-csi2_imx95-v2-2-934c02f3422a@oss.nxp.com> (raw)
In-Reply-To: <20260423-csi2_imx95-v2-0-934c02f3422a@oss.nxp.com>

The imx93_csi2rx_dphy_ipi_enable() function configures the IPI datatype
using csi2->formats->csi_dt, which is initialized during probe but never
updated in set_fmt(). This causes the IPI to always use the probe-time
default datatype, ignoring the actual media bus format negotiated at
runtime. When userspace requests a different format, the IPI hardware is
configured with the wrong datatype, resulting in incorrect image output.

Fix by updating csi2->formats in the set_fmt callback to reflect the
currently negotiated format, ensuring the IPI configuration matches the
runtime datatype.

Fixes: ec40b431f0ab ("media: synopsys: csi2rx: add i.MX93 support")
Signed-off-by: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
---
Changes in v2:
- New added in v2
---
 drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
index 02eb4a6cafad..b3f90da8b43c 100644
--- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
+++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
@@ -470,6 +470,11 @@ static int dw_mipi_csi2rx_set_fmt(struct v4l2_subdev *sd,
 
 	*src = *sink;
 
+	/* Store the CSIS format descriptor for active formats. */
+	if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
+		csi2->formats = fmt ? :
+			dw_mipi_csi2rx_find_format(csi2, default_format.code);
+
 	return 0;
 }
 

-- 
2.34.1



  parent reply	other threads:[~2026-04-23  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  8:22 [PATCH v2 0/7] media: synopsys: enhancements and i.MX95 support Guoniu Zhou
2026-04-23  8:22 ` [PATCH v2 1/7] media: synopsys: Fix out-of-bounds check in enum_mbus_code Guoniu Zhou
2026-04-24  3:57   ` Frank Li
2026-04-23  8:22 ` Guoniu Zhou [this message]
2026-04-24  3:58   ` [PATCH v2 2/7] media: synopsys: Fix IPI using hardcoded datatype Frank Li
2026-04-23  8:22 ` [PATCH v2 3/7] media: synopsys: Add support for RAW16 Bayer formats Guoniu Zhou
2026-04-24  3:59   ` Frank Li
2026-04-23  8:22 ` [PATCH v2 4/7] media: synopsys: Add support for multiple streams Guoniu Zhou
2026-04-24  4:01   ` Frank Li
2026-04-23  8:23 ` [PATCH v2 5/7] media: synopsys: Add PHY stopstate wait for i.MX93 Guoniu Zhou
2026-04-24  4:02   ` Frank Li
2026-04-23  8:23 ` [PATCH v2 6/7] media: dt-bindings: add NXP i.MX95 compatible string Guoniu Zhou
2026-04-24  4:05   ` Frank Li
2026-04-25  9:50   ` Krzysztof Kozlowski
2026-04-23  8:23 ` [PATCH v2 7/7] media: synopsys: Add support for i.MX95 Guoniu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260423-csi2_imx95-v2-2-934c02f3422a@oss.nxp.com \
    --to=guoniu.zhou@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hverkuil+cisco@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=michael.riesch@collabora.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox