Re: [PATCH v2 6/7] media: dt-bindings: add NXP i.MX95 compatible string

Frank Li
2026-04-24T04:05:25Z

On Thu, Apr 23, 2026 at 04:23:01PM +0800, Guoniu Zhou wrote:
> The i.MX95 CSI-2 controller is nearly identical to i.MX93, with the
> main difference being the data output interface:
>
> i.MX93 use IPI (Image Pixel Interface), which requires:
> - Pixel clock input
> - Software configuration through registers
>
> i.MX95 uses IDI (Image Data Interface), which:
> - Does not require pixel clock
> - Is software transparent (no register configuration needed)

Nit: Remove "Is", just "Software ... "

>
> Due to these differences in register layout and initialization needs,
> the two variants cannot share the same compatible string. The driver
> needs to distinguish between them to handle the interface correctly.
>
> Signed-off-by: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Changes in v2:
> - Add dedicated constraint block for i.MX95 to reflect different clock
> requirements (only per clock needed vs i.MX93 which needs both per
> and pixel clocks)
> - Update commit message to include more details about interface differences
> ---
> .../bindings/media/rockchip,rk3568-mipi-csi2.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> index 4ac4a3b6f406..4e0bc75c2136 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> @@ -18,6 +18,7 @@ properties:
> compatible:
> enum:
> - fsl,imx93-mipi-csi2
> + - fsl,imx95-mipi-csi2
> - rockchip,rk3568-mipi-csi2
>
> reg:
> @@ -135,6 +136,21 @@ allOf:
> clock-names:
> minItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx95-mipi-csi2
> + then:
> + properties:
> + interrupts:
> + maxItems: 1
> + interrupt-names: false
> + clocks:
> + maxItems: 1
> + clock-names:
> + maxItems: 1
> +
> examples:
> - |
> #include <dt-bindings/clock/rk3568-cru.h>
>
> --
> 2.34.1
>