From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25B0DF99362 for ; Thu, 23 Apr 2026 09:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z7tAxn2A+LM9bwTEoO62qUH48d+Pb0dLfk/f5159Clc=; b=QO2j2eh/S20LXyH5T/VTmxpVF7 Kj8nUi0yIaZRvPKmT5CWUzgCeYchhD8K9WBOjHY9CGFi0ihHobUti0VA0q3LbxmHQmcTIZwYp+Pnm kXLpvBw2OOeqqiwamiYRHE+qoQrjXleM53ek4rxmeOHc20VawX6j2flaZjZIzP9gAQWMhDcE3FH67 dlsqs4PRQ65cfqy+vK6ZPF5EASKMWpPMbCZhfYDNyDqRbVt3L7IQoaA7eQxdrixxrqK1LlV7IlEu8 1pgWhft/OWe9FPgpUzKBvuPONEsMkjuO+CHZRNsu/DKSnuTFRaybKBYZoqQECp+0jTsBQeScJMzr8 X2NapGzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFqcK-0000000BPjP-10WN; Thu, 23 Apr 2026 09:45:04 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFqcI-0000000BPi7-1gcj for linux-arm-kernel@lists.infradead.org; Thu, 23 Apr 2026 09:45:03 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 418AA6A83C; Thu, 23 Apr 2026 09:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776937499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7tAxn2A+LM9bwTEoO62qUH48d+Pb0dLfk/f5159Clc=; b=vuXZb/ifT0L6JPhznT2uYlWCWcouL0v8ZMj7PzDqL5UhavaqRgCc6gK/wUKDLxCMssvajt PkK1O7FwtWkAwTDTcCdN7tpVlCApVmDuFr8tymkoM780CpHFpU1v/YHQJL2GSFPlhYu+Bg WDN7/83RfQ0gu98hxjPbgSnRQhCP6Lc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776937499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7tAxn2A+LM9bwTEoO62qUH48d+Pb0dLfk/f5159Clc=; b=bwuyMxM0mZ2ukdmtGwqy8Try3bpjq5wCSK+YsNdhMPIA2NcodYKH7pGShTfjC1qcHjvDUr tijw12SiRxMuvhDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776937499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7tAxn2A+LM9bwTEoO62qUH48d+Pb0dLfk/f5159Clc=; b=vuXZb/ifT0L6JPhznT2uYlWCWcouL0v8ZMj7PzDqL5UhavaqRgCc6gK/wUKDLxCMssvajt PkK1O7FwtWkAwTDTcCdN7tpVlCApVmDuFr8tymkoM780CpHFpU1v/YHQJL2GSFPlhYu+Bg WDN7/83RfQ0gu98hxjPbgSnRQhCP6Lc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776937499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7tAxn2A+LM9bwTEoO62qUH48d+Pb0dLfk/f5159Clc=; b=bwuyMxM0mZ2ukdmtGwqy8Try3bpjq5wCSK+YsNdhMPIA2NcodYKH7pGShTfjC1qcHjvDUr tijw12SiRxMuvhDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB95D593B0; Thu, 23 Apr 2026 09:44:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cFMdOBrq6Wk+QwAAD6G6ig (envelope-from ); Thu, 23 Apr 2026 09:44:58 +0000 From: Thomas Zimmermann To: inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 1/5] drm/exynos: fbdev: Remove offset into screen_buffer Date: Thu, 23 Apr 2026 11:37:46 +0200 Message-ID: <20260423094452.32665-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423094452.32665-1-tzimmermann@suse.de> References: <20260423094452.32665-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[samsung.com,gmail.com,ffwll.ch,lists.freedesktop.org]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[10]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email,infradead.org:email]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_024502_737123_19AE754E X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The screen_buffer field in struct fb_info contains the kernel address of the first byte of framebuffer memory. Do not add the display offset. This offset only describes scrolling during scanout. Signed-off-by: Thomas Zimmermann Fixes: 19c8b8343d9c ("drm/exynos: fixed overlay data updating.") Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: # v3.2+ --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 637927818dfe..d283ded266d5 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -61,17 +61,13 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, struct fb_info *fbi = helper->info; struct drm_framebuffer *fb = helper->fb; unsigned int size = fb->width * fb->height * fb->format->cpp[0]; - unsigned long offset; fbi->fbops = &exynos_drm_fb_ops; drm_fb_helper_fill_info(fbi, helper, sizes); - offset = fbi->var.xoffset * fb->format->cpp[0]; - offset += fbi->var.yoffset * fb->pitches[0]; - fbi->flags |= FBINFO_VIRTFB; - fbi->screen_buffer = exynos_gem->kvaddr + offset; + fbi->screen_buffer = exynos_gem->kvaddr; fbi->screen_size = size; fbi->fix.smem_len = size; -- 2.53.0