From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16AA7F34C45 for ; Fri, 24 Apr 2026 03:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Azk5v8hUMXqdf3vGgU0n3RadxZyfwa8M+/LWpvAomRg=; b=Q8Q2+lMLREU8kJ/O3drYLMtIdK TxAt/tritqxNjRv0Uqv9+28f9AtB/oPjDg1YlkDk8xGCaFtIQdAOj8jdy0qpNwMteJPBMmcTege26 VJX3A5tTbq3aetnH/JdYdZ3mriyltONOxgXAB8BdfUFSih2JT7qMYmkpP9NSc7v8BRc3VH3BNnX/n wSubISXrHMCtnhEIoJX3TIbt2rXYcTXUrNUvp7MHrZ2+XmrsyghEJvmY/ekz8tDPZTiYEf9QzDBA+ KQxSed92MAMjVMx205ekV3+0ggKOa9fSagPRGPXRR3LK6vCcnCKKGg6AnmDesXbxEyVOTZmAIda2K P/CMWv8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wG6rX-0000000CZ55-3Q9I; Fri, 24 Apr 2026 03:05:51 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wG6rQ-0000000CYy5-2Ps0; Fri, 24 Apr 2026 03:05:45 +0000 X-UUID: 7977c79e3f8a11f19e7563141e833ce8-20260423 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=Azk5v8hUMXqdf3vGgU0n3RadxZyfwa8M+/LWpvAomRg=; b=OHKsoJ/MpmzErZq4OJmOV0cgHY9Ro8D2q9ZtPQP8X6AZmML4nedjCExglkJB8mVtRTp2MoxSL8Tb4KrZX0nhM7tw1iwPZV7TOIv7KnEr/7uEMXeZuipFC7IA9KX/IwrMa5nrwTi/3OdrQzu9yDETCc8yva+sgYyCrQzmBlTpjiQ=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:8f643358-6eb4-4b64-9b3a-54fbda42eac2,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:e7bac3a,CLOUDID:8027d48f-6df4-4a3d-a7a4-fbdc42d669ce,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|865|888|898,TC:-5,Cont ent:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 7977c79e3f8a11f19e7563141e833ce8-20260423 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1982678490; Thu, 23 Apr 2026 20:05:40 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 24 Apr 2026 11:05:37 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Fri, 24 Apr 2026 11:05:36 +0800 From: Kyrie Wu To: Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Kyrie Wu , Hans Verkuil , Nicolas Dufresne , Nathan Hebert , Arnd Bergmann , Irui Wang , George Sun , , , , , CC: Neil Armstrong , Andrzej Pietrasiewicz , Yilong Zhou Subject: [PATCH v9 4/9] media: mediatek: vcodec: Add VP9 Probability Size Configuration Date: Fri, 24 Apr 2026 11:05:22 +0800 Message-ID: <20260424030527.10656-5-kyrie.wu@mediatek.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20260424030527.10656-1-kyrie.wu@mediatek.com> References: <20260424030527.10656-1-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_200544_639949_947189F6 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Introduce support for using different probability buffer sizes for different stateless decoders: in particular, the VP9 decoder can use a different size on different SoCs because of different hardware capabilities. Move the hardcoded single probability buffer size value to decoder params, introduce a new VP9_4K_PROB_BUF_SIZE and assign: - VP9_PROB_BUF_SIZE (2560 lines) to legacy SoCs; - VP9_4K_PROB_BUF_SIZE (3840 lines) to newer SoCs (MT8196, MT8189). Signed-off-by: Kyrie Wu Reviewed-by: AngeloGioacchino Del Regno --- .../mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h | 2 ++ .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c | 1 + .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 9 +++++++++ .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 4 ++-- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h index 4ffc0eae855b..43dc0b22fdb0 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h @@ -82,10 +82,12 @@ struct vdec_pic_info { * struct mtk_vcodec_dec_params - decoder supported parameters * @level: decoder supported vcodec level * @profile: decoder supported vcodec profile + * @prob_size: vp9 decoder probability size */ struct mtk_vcodec_dec_params { s64 level; s64 profile; + size_t prob_size; }; /** diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c index 64f32976d15e..5dcbe6550419 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c @@ -630,5 +630,6 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8173_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_0, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = 2560, }, }; diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c index efcd28f5f289..783a988b894a 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c @@ -10,6 +10,9 @@ #include "mtk_vcodec_dec_pm.h" #include "vdec_drv_if.h" +#define VP9_PROB_BUF_SIZE 2560 +#define VP9_4K_PROB_BUF_SIZE 3840 + /** * struct mtk_stateless_control - CID control type * @cfg: control configuration @@ -890,6 +893,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8183_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_0, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -941,6 +945,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8188_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -959,6 +964,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8192_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -977,6 +983,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8195_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -995,6 +1002,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8196_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_2, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_4K_PROB_BUF_SIZE, }, }; @@ -1030,5 +1038,6 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8186_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c index 3f4b70526754..e02dcf81b3cb 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c @@ -22,7 +22,6 @@ #define VP9_RESET_FRAME_CONTEXT_ALL 3 #define VP9_TILE_BUF_SIZE 4096 -#define VP9_PROB_BUF_SIZE 2560 #define VP9_COUNTS_BUF_SIZE 16384 #define HDR_FLAG(x) (!!((hdr)->flags & V4L2_VP9_FRAME_FLAG_##x)) @@ -551,6 +550,7 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i struct vdec_vp9_slice_vsi *vsi) { struct mtk_vcodec_dec_ctx *ctx = instance->ctx; + struct mtk_vcodec_dec_dev *pdev = ctx->dev; enum vdec_vp9_slice_resolution_level level; /* super blocks */ unsigned int max_sb_w; @@ -621,7 +621,7 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i } if (!instance->prob.va) { - instance->prob.size = VP9_PROB_BUF_SIZE; + instance->prob.size = pdev->vdec_pdata->vp9_params.prob_size; if (mtk_vcodec_mem_alloc(ctx, &instance->prob)) goto err; } -- 2.45.2