public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Maninder Singh <maninder1.s@samsung.com>
To: linux@armlinux.org.uk, linus.walleij@linaro.org, ardb@kernel.org,
	ndesaulniers@google.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Maninder Singh <maninder1.s@samsung.com>
Subject: [PATCH 1/1] arm: traps: remove fp underflow checking
Date: Fri, 24 Apr 2026 10:00:29 +0530	[thread overview]
Message-ID: <20260424043029.4101133-1-maninder1.s@samsung.com> (raw)
In-Reply-To: CGME20260424043122epcas5p17e2f88653e398c5a53c0ffa4c1e01bc1@epcas5p1.samsung.com

with IRQSTACKS fp can point outside of thread's stack.
And when there is crash reported from IRQ side, it always report
"frame pointer underflow", which is not real underflow.

Unhandled fault: page domain fault (0x81b) at 0x00000000
..
PC is at handle_irq_desc+0x68/0xa4
LR is at generic_handle_domain_irq+0x18/0x1c
..

Call trace: frame pointer underflow
 handle_irq_desc from generic_handle_domain_irq+0x18/0x1c
 generic_handle_domain_irq from gic_handle_irq+0x78/0x8c
 gic_handle_irq from generic_handle_arch_irq+0x3c/0x4c
..

It is just warning print and there is no decision based on this
to stop backtrack or etc. So it can be removed.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
---
 arch/arm/kernel/traps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index afbd2ebe5c39..47f8c0738399 100644
--- a/arch/arm/kernel/traps.c
+++ b/arch/arm/kernel/traps.c
@@ -243,8 +243,8 @@ void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,
 	} else if (verify_stack(fp)) {
 		pr_cont("invalid frame pointer 0x%08x", fp);
 		ok = 0;
-	} else if (fp < (unsigned long)end_of_stack(tsk))
-		pr_cont("frame pointer underflow");
+	}
+
 	pr_cont("\n");
 
 	if (ok)
-- 
2.34.1



       reply	other threads:[~2026-04-24  4:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260424043122epcas5p17e2f88653e398c5a53c0ffa4c1e01bc1@epcas5p1.samsung.com>
2026-04-24  4:30 ` Maninder Singh [this message]
2026-04-24 12:21   ` [PATCH 1/1] arm: traps: remove fp underflow checking Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424043029.4101133-1-maninder1.s@samsung.com \
    --to=maninder1.s@samsung.com \
    --cc=ardb@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox