From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C161FED3F0 for ; Fri, 24 Apr 2026 16:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dDiMWVTh22vX4UyQOXICvIHOfqKHJx/jp7tqhZt+05s=; b=GjsMcez1xnF+yeXsD8i9gJy+lY juCU9kgYC63WVz8hSNNOTNu/vxDsciKQU5V7TOnJwY6j5HYCt0/mNAR6pfR7U08dashftNXOxqIe3 +e/2XR5Q6iIKd+eyaEUJrfxbcPEJ+/Sr48B5yy2yV0184cA7kARa9Fw9uJdB9UgoE8smBgBQkssDW OstfdDMTLYLwCd6ryXyMfggP/zTs9o429/el5EvsO1rVDPt0RuZgKkUy+UR7UYxiuaPd7n6DVPUGV OcdVO/9ZVM0RuNOXOkXV7gtIyVHCitRz3g2VjiOKq2G/GwYhXj2wIAtqFgcT6pf9xz8TYXD3JSY8t LqEYbQbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGJhq-0000000DTyh-2dee; Fri, 24 Apr 2026 16:48:42 +0000 Received: from mail-dl1-x1249.google.com ([2607:f8b0:4864:20::1249]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGJha-0000000DTgt-2XEr for linux-arm-kernel@lists.infradead.org; Fri, 24 Apr 2026 16:48:32 +0000 Received: by mail-dl1-x1249.google.com with SMTP id a92af1059eb24-12dc3d81736so998663c88.1 for ; Fri, 24 Apr 2026 09:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777049305; x=1777654105; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dDiMWVTh22vX4UyQOXICvIHOfqKHJx/jp7tqhZt+05s=; b=a2xMh0fMPsguAojuhY/I+wyfsmB63BEuUJ+Mkictu3FWiy1g6WtdoP5hGHsDL4Zr57 z3ONf/mZecrZAFEKEfEvju/Y58e79QZFCP7Vdj9RPHyD/8mzoyxLBDuVr75wMmjPxR7R ImRHgzpUPIQo3fBk2pLxv+fdWiVrj9aOh/JwiqwSs/7i/tgSpBB//obgt6+xLQ8hMtyI fd8BK2tGgrJkgvFrYkl5h0LoQYzKzxqRf9EFhimS4ZJp7phHMKr0/Ge6UJeau6I+XQMB 3pdXOS4Pyja0GGVKIY4VdQLkc0j6qzCR+x48gwFRhBp0lqgjSySGD3rN/AU46K3mZuBG IRDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777049305; x=1777654105; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dDiMWVTh22vX4UyQOXICvIHOfqKHJx/jp7tqhZt+05s=; b=fAou6Pl05UZa5IpWJ9haJ7uxInbBRqoZlGAuyffB8XkQAE2N+ey6GDJesU9YSPplQP 72V76VH/Od8DSz0KWCbiCplGt8Rj/IFAK9yE5FabExX4y0RyDMBQfLenzooFnxmmftDT M1U+56d2TlqkAeQjNrFceUIpnqv0DUKsD6KZvcYJjn06quMYp4B5i0GGYBNEuCIo0zIM I3aeQRcoK66mnnvIrhJeqtDfKeAaaP/IBP0oXfIjVSKdTV7+z0QN842k4pgQ2ZnqrdZc vQiTTQYPl0km800qZdeK6f7qFNAyDBrdkoutngEVdkptypUo+jQ3YOGi6Yk45yXJAG6y kr2w== X-Forwarded-Encrypted: i=1; AFNElJ/D5/um9fXNm0mEG4klBVtf3mWxKWpKuxP/ysEToR7nOpmeIp5BRO1+lDFwjhBf6JzQ+DRwnj3FqL65CMXDYdIu@lists.infradead.org X-Gm-Message-State: AOJu0YznWDizHy6JrYoiwcXjZIzqG5Bu/q4azZipQ/kXMNB7ViISat2i JO+hbQmTcJ5jPIz7K5KjlHotFkklwVjVqVqfwSr7li5w+wb4jc5kmGgUIZlX4UGpC6RkN0GOVsG cpkH+tOAozA== X-Received: from dlbrl2.prod.google.com ([2002:a05:7022:f502:b0:12d:c3dd:4fba]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:50d:b0:12a:747e:5b5c with SMTP id a92af1059eb24-12c73fa3af3mr17146956c88.24.1777049304884; Fri, 24 Apr 2026 09:48:24 -0700 (PDT) Date: Fri, 24 Apr 2026 09:46:40 -0700 In-Reply-To: <20260424164721.2229025-1-irogers@google.com> Mime-Version: 1.0 References: <20260423163406.1779809-1-irogers@google.com> <20260424164721.2229025-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260424164721.2229025-19-irogers@google.com> Subject: [PATCH v5 18/58] perf python: Add callchain support From: Ian Rogers To: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, leo.yan@linux.dev, namhyung@kernel.org, tmricht@linux.ibm.com Cc: alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260424_094826_711303_C77BA98A X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Implement pyrf_callchain_node and pyrf_callchain types for lazy iteration over callchain frames. Add callchain property to sample_event. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: 1. Eager Callchain Resolution: Moved the callchain resolution from deferred iteration to eager processing in pyrf_session_tool__sample() . This avoids risks of reading from unmapped memory or following dangling pointers to closed sessions. 2. Cached Callchain: Added a callchain field to struct pyrf_event to store the resolved object. 3. Simplified Access: pyrf_sample_event__get_callchain() now just returns the cached object if available. 4. Avoided Double Free: Handled lazy cleanups properly. --- tools/perf/util/python.c | 237 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 237 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 63ee9bc65721..28961ad47010 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -66,6 +66,8 @@ struct pyrf_event { struct addr_location al; /** @al_resolved: True when machine__resolve been called. */ bool al_resolved; + /** @callchain: Resolved callchain, eagerly computed if requested. */ + PyObject *callchain; /** @event: The underlying perf_event that may be in a file or ring buffer. */ union perf_event event; }; @@ -103,6 +105,7 @@ static void pyrf_event__delete(struct pyrf_event *pevent) { if (pevent->al_resolved) addr_location__exit(&pevent->al); + Py_XDECREF(pevent->callchain); perf_sample__exit(&pevent->sample); Py_TYPE(pevent)->tp_free((PyObject*)pevent); } @@ -621,6 +624,181 @@ static PyObject *pyrf_sample_event__insn(PyObject *self, PyObject *args __maybe_ pevent->sample.insn_len); } +struct pyrf_callchain_node { + PyObject_HEAD + u64 ip; + struct map *map; + struct symbol *sym; +}; + +static void pyrf_callchain_node__delete(struct pyrf_callchain_node *pnode) +{ + map__put(pnode->map); + Py_TYPE(pnode)->tp_free((PyObject*)pnode); +} + +static PyObject *pyrf_callchain_node__get_ip(struct pyrf_callchain_node *pnode, + void *closure __maybe_unused) +{ + return PyLong_FromUnsignedLongLong(pnode->ip); +} + +static PyObject *pyrf_callchain_node__get_symbol(struct pyrf_callchain_node *pnode, + void *closure __maybe_unused) +{ + if (pnode->sym) + return PyUnicode_FromString(pnode->sym->name); + return PyUnicode_FromString("[unknown]"); +} + +static PyObject *pyrf_callchain_node__get_dso(struct pyrf_callchain_node *pnode, + void *closure __maybe_unused) +{ + const char *dsoname = "[unknown]"; + + if (pnode->map) { + struct dso *dso = map__dso(pnode->map); + if (dso) { + if (symbol_conf.show_kernel_path && dso__long_name(dso)) + dsoname = dso__long_name(dso); + else + dsoname = dso__name(dso); + } + } + return PyUnicode_FromString(dsoname); +} + +static PyGetSetDef pyrf_callchain_node__getset[] = { + { .name = "ip", .get = (getter)pyrf_callchain_node__get_ip, }, + { .name = "symbol", .get = (getter)pyrf_callchain_node__get_symbol, }, + { .name = "dso", .get = (getter)pyrf_callchain_node__get_dso, }, + { .name = NULL, }, +}; + +static PyTypeObject pyrf_callchain_node__type = { + PyVarObject_HEAD_INIT(NULL, 0) + .tp_name = "perf.callchain_node", + .tp_basicsize = sizeof(struct pyrf_callchain_node), + .tp_dealloc = (destructor)pyrf_callchain_node__delete, + .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE, + .tp_doc = "perf callchain node object.", + .tp_getset = pyrf_callchain_node__getset, +}; + +struct pyrf_callchain_frame { + u64 ip; + struct map *map; + struct symbol *sym; +}; + +struct pyrf_callchain { + PyObject_HEAD + struct pyrf_event *pevent; + struct pyrf_callchain_frame *frames; + u64 nr_frames; + u64 pos; + bool resolved; +}; + +static void pyrf_callchain__delete(struct pyrf_callchain *pchain) +{ + Py_XDECREF(pchain->pevent); + if (pchain->frames) { + for (u64 i = 0; i < pchain->nr_frames; i++) + map__put(pchain->frames[i].map); + free(pchain->frames); + } + Py_TYPE(pchain)->tp_free((PyObject*)pchain); +} + +static PyObject *pyrf_callchain__next(struct pyrf_callchain *pchain) +{ + struct pyrf_callchain_node *pnode; + + if (!pchain->resolved) { + struct evsel *evsel = pchain->pevent->sample.evsel; + struct evlist *evlist = evsel->evlist; + struct perf_session *session = evlist ? evlist__session(evlist) : NULL; + struct addr_location al; + struct callchain_cursor *cursor; + struct callchain_cursor_node *node; + u64 i; + + if (!session || !pchain->pevent->sample.callchain) + return NULL; + + addr_location__init(&al); + if (machine__resolve(&session->machines.host, &al, &pchain->pevent->sample) < 0) { + addr_location__exit(&al); + return NULL; + } + + cursor = get_tls_callchain_cursor(); + if (thread__resolve_callchain(al.thread, cursor, evsel, + &pchain->pevent->sample, NULL, NULL, + PERF_MAX_STACK_DEPTH) != 0) { + addr_location__exit(&al); + return NULL; + } + callchain_cursor_commit(cursor); + + pchain->nr_frames = cursor->nr; + if (pchain->nr_frames > 0) { + pchain->frames = calloc(pchain->nr_frames, sizeof(*pchain->frames)); + if (!pchain->frames) { + addr_location__exit(&al); + return PyErr_NoMemory(); + } + + for (i = 0; i < pchain->nr_frames; i++) { + node = callchain_cursor_current(cursor); + pchain->frames[i].ip = node->ip; + pchain->frames[i].map = map__get(node->ms.map); + pchain->frames[i].sym = node->ms.sym; + callchain_cursor_advance(cursor); + } + } + pchain->resolved = true; + addr_location__exit(&al); + } + + if (pchain->pos >= pchain->nr_frames) + return NULL; + + pnode = PyObject_New(struct pyrf_callchain_node, &pyrf_callchain_node__type); + if (!pnode) + return NULL; + + pnode->ip = pchain->frames[pchain->pos].ip; + pnode->map = map__get(pchain->frames[pchain->pos].map); + pnode->sym = pchain->frames[pchain->pos].sym; + + pchain->pos++; + return (PyObject *)pnode; +} + +static PyTypeObject pyrf_callchain__type = { + PyVarObject_HEAD_INIT(NULL, 0) + .tp_name = "perf.callchain", + .tp_basicsize = sizeof(struct pyrf_callchain), + .tp_dealloc = (destructor)pyrf_callchain__delete, + .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE, + .tp_doc = "perf callchain object.", + .tp_iter = PyObject_SelfIter, + .tp_iternext = (iternextfunc)pyrf_callchain__next, +}; + +static PyObject *pyrf_sample_event__get_callchain(PyObject *self, void *closure __maybe_unused) +{ + struct pyrf_event *pevent = (void *)self; + + if (!pevent->callchain) + Py_RETURN_NONE; + + Py_INCREF(pevent->callchain); + return pevent->callchain; +} + static PyObject* pyrf_sample_event__getattro(struct pyrf_event *pevent, PyObject *attr_name) { @@ -635,6 +813,12 @@ pyrf_sample_event__getattro(struct pyrf_event *pevent, PyObject *attr_name) } static PyGetSetDef pyrf_sample_event__getset[] = { + { + .name = "callchain", + .get = pyrf_sample_event__get_callchain, + .set = NULL, + .doc = "event callchain.", + }, { .name = "raw_buf", .get = (getter)pyrf_sample_event__get_raw_buf, @@ -803,6 +987,12 @@ static int pyrf_event__setup_types(void) err = PyType_Ready(&pyrf_context_switch_event__type); if (err < 0) goto out; + err = PyType_Ready(&pyrf_callchain_node__type); + if (err < 0) + goto out; + err = PyType_Ready(&pyrf_callchain__type); + if (err < 0) + goto out; out: return err; } @@ -848,6 +1038,7 @@ static PyObject *pyrf_event__new(const union perf_event *event) if (pevent != NULL) { memcpy(&pevent->event, event, event->header.size); pevent->sample.evsel = NULL; + pevent->callchain = NULL; pevent->al_resolved = false; addr_location__init(&pevent->al); } @@ -2810,6 +3001,49 @@ static int pyrf_session_tool__sample(const struct perf_tool *tool, if (pevent->sample.merged_callchain) pevent->sample.callchain = NULL; + if (sample->callchain) { + struct addr_location al; + struct callchain_cursor *cursor; + u64 i; + struct pyrf_callchain *pchain; + + addr_location__init(&al); + if (machine__resolve(&psession->session->machines.host, &al, sample) >= 0) { + cursor = get_tls_callchain_cursor(); + if (thread__resolve_callchain(al.thread, cursor, evsel, sample, + NULL, NULL, PERF_MAX_STACK_DEPTH) == 0) { + callchain_cursor_commit(cursor); + + pchain = PyObject_New(struct pyrf_callchain, &pyrf_callchain__type); + if (pchain) { + pchain->pevent = pevent; + Py_INCREF(pevent); + pchain->nr_frames = cursor->nr; + pchain->pos = 0; + pchain->resolved = true; + pchain->frames = calloc(pchain->nr_frames, + sizeof(*pchain->frames)); + if (pchain->frames) { + struct callchain_cursor_node *node; + + for (i = 0; i < pchain->nr_frames; i++) { + node = callchain_cursor_current(cursor); + pchain->frames[i].ip = node->ip; + pchain->frames[i].map = + map__get(node->ms.map); + pchain->frames[i].sym = node->ms.sym; + callchain_cursor_advance(cursor); + } + pevent->callchain = (PyObject *)pchain; + } else { + Py_DECREF(pchain); + } + } + } + addr_location__exit(&al); + } + } + ret = PyObject_CallFunction(psession->sample, "O", pyevent); if (!ret) { PyErr_Print(); @@ -2900,6 +3134,9 @@ static int pyrf_session__init(struct pyrf_session *psession, PyObject *args, PyO return -1; } + symbol_conf.use_callchain = true; + symbol_conf.show_kernel_path = true; + symbol_conf.inline_name = false; if (symbol__init(perf_session__env(psession->session)) < 0) { perf_session__delete(psession->session); psession->session = NULL; -- 2.54.0.545.g6539524ca2-goog