From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E2D6FF885C for ; Sat, 25 Apr 2026 09:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zjjR8qfnlNpjVgkcXC1r0Kh9aqRf2X8N1AKvVkuz/Xo=; b=otaY5THZ1/fp0dGJNEv0nYEw8C WOr4z6n/EKt9HgAwdEjOjxkaJ8FBOt39/chnlr3djZWLDtRLxBAosC6LjP5sYJGZ6/3DBIPi6KXoc agDNPmsZpEfbvad6WZ5G5lPwi+4bw8mcXMbc1bwPl0Sk+Qk/zFkVzV6gtnylMtHxqV5Di2C6d4vIL Q3dSvDCVxWwrxQR+w3wCWBS1afiikaPjgVLchlhO/oNvczzmH7JzhQdDHSzpjVr2S+q3GQpVbhGvJ QcatmuvZf5G1NPZH9x1JqoOJyismraHPUDXAug1TRebRaio0ndRocjETA29gNHmuHKDwZQClq9x1o lc/dEBbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGZOA-0000000EIe0-1WsL; Sat, 25 Apr 2026 09:33:26 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGZO9-0000000EIdq-1oMH; Sat, 25 Apr 2026 09:33:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8FA5C60052; Sat, 25 Apr 2026 09:33:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89AEDC2BCB0; Sat, 25 Apr 2026 09:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777109604; bh=vTnWUB3963217PH6E98v4MIyJ/E5FD6u2p/ki3Ycw2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kT8Q+d6o6nw+n1KPS+w1ZpJZl3Yc/tDH77v0iMYo8pnCj7XYzNRzqn66o/+5loj06 us0LWHBLCY0Uds+AjizRvxUzdDxpq3OEqzBhXN2rZVTAMXy+1f0/ElBO/GRYjTafII ldWiYfqhzxYU/08LZsfArV9vUlP5cCPZcSqTpvY1DmjbiIjpyE5zlnOTAyKkpa/TEz kYlnNDET7XxapKrMtaUi5ICdwN0WGH4T5M8XKc9kB6tRx9nDKJ6mbKKcGns/l2lZmQ l8DJu3YF8zaf7wa6vfbTLogAeRe1ENAnhvwLfA+/6d+R4wvi/Nmd5X+oNQN7v3KF1Y GNFTzaymKptEA== Date: Sat, 25 Apr 2026 11:33:21 +0200 From: Krzysztof Kozlowski To: lizhi2@eswincomputing.com Cc: devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, pritesh.patel@einfochips.com, weishangjuan@eswincomputing.com, horms@kernel.org Subject: Re: [PATCH net-next v6 3/3] riscv: dts: eswin: eic7700-hifive-premier-p550: enable Ethernet controller Message-ID: <20260425-woodoo-righteous-earthworm-0ed34c@quoll> References: <20260423085501.760-1-lizhi2@eswincomputing.com> <20260423085650.820-1-lizhi2@eswincomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260423085650.820-1-lizhi2@eswincomputing.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 23, 2026 at 04:56:50PM +0800, lizhi2@eswincomputing.com wrote: > From: Zhi Li > > Enable the on-board Gigabit Ethernet controller on the > HiFive Premier P550 development board. > > Signed-off-by: Zhi Li > --- > .../devicetree/bindings/mfd/syscon.yaml | 2 + > .../dts/eswin/eic7700-hifive-premier-p550.dts | 232 ++++++++++++++++++ > arch/riscv/boot/dts/eswin/eic7700.dtsi | 103 ++++++++ > 3 files changed, 337 insertions(+) > Please split the patches. Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof