Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ai Chao <aichao@kylinos.cn>
To: deller@gmx.de, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev,
	linux@armlinux.org.uk, dilinger@queued.net, adaplas@gmail.com,
	James.Bottomley@HansenPartnership.com, FlorianSchandinat@gmx.de,
	alchark@gmail.com, krzk@kernel.org, kees@kernel.org,
	rene@exactco.de, tzimmermann@suse.de, rongqianfeng@vivo.com,
	thorsten.blum@linux.dev, chelsyratnawat2001@gmail.com,
	soci@c64.rulez.org, gregkh@linuxfoundation.org, daniel@thingy.jp,
	linmq006@gmail.com, fourier.thomas@gmail.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-geode@lists.infradead.org, linux-parisc@vger.kernel.org,
	Ai Chao <aichao@kylinos.cn>
Subject: [PATCH 03/35] fbdev: sisfb: Use safer strscpy() instead of strcpy()
Date: Sat, 25 Apr 2026 14:58:54 +0800	[thread overview]
Message-ID: <20260425065926.1091168-4-aichao@kylinos.cn> (raw)
In-Reply-To: <20260425065926.1091168-1-aichao@kylinos.cn>

Use a safer function strscpy() instead of strcpy() for copying to arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Ai Chao <aichao@kylinos.cn>
---
 drivers/video/fbdev/sis/sis_main.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 84567d67f71d..e87fa261f76c 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -205,7 +205,7 @@ static void sisfb_search_mode(char *name, bool quiet)
 	}
 
 	if(strlen(name) <= 19) {
-		strcpy(strbuf1, name);
+		strscpy(strbuf1, name);
 		for(i = 0; i < strlen(strbuf1); i++) {
 			if(strbuf1[i] < '0' || strbuf1[i] > '9') strbuf1[i] = ' ';
 		}
@@ -5947,33 +5947,33 @@ static int sisfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 #ifdef CONFIG_FB_SIS_300
 		case PCI_DEVICE_ID_SI_730:
 			ivideo->chip = SIS_730;
-			strcpy(ivideo->myid, "SiS 730");
+			strscpy(ivideo->myid, "SiS 730");
 			break;
 #endif
 #ifdef CONFIG_FB_SIS_315
 		case PCI_DEVICE_ID_SI_651:
 			/* ivideo->chip is ok */
-			strcpy(ivideo->myid, "SiS 651");
+			strscpy(ivideo->myid, "SiS 651");
 			break;
 		case PCI_DEVICE_ID_SI_740:
 			ivideo->chip = SIS_740;
-			strcpy(ivideo->myid, "SiS 740");
+			strscpy(ivideo->myid, "SiS 740");
 			break;
 		case PCI_DEVICE_ID_SI_661:
 			ivideo->chip = SIS_661;
-			strcpy(ivideo->myid, "SiS 661");
+			strscpy(ivideo->myid, "SiS 661");
 			break;
 		case PCI_DEVICE_ID_SI_741:
 			ivideo->chip = SIS_741;
-			strcpy(ivideo->myid, "SiS 741");
+			strscpy(ivideo->myid, "SiS 741");
 			break;
 		case PCI_DEVICE_ID_SI_760:
 			ivideo->chip = SIS_760;
-			strcpy(ivideo->myid, "SiS 760");
+			strscpy(ivideo->myid, "SiS 760");
 			break;
 		case PCI_DEVICE_ID_SI_761:
 			ivideo->chip = SIS_761;
-			strcpy(ivideo->myid, "SiS 761");
+			strscpy(ivideo->myid, "SiS 761");
 			break;
 #endif
 		default:
-- 
2.34.1



  parent reply	other threads:[~2026-04-25  7:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  6:58 [PATCH 00/35] Use safer strscpy() instead of strcpy() Ai Chao
2026-04-25  6:58 ` [PATCH 01/35] fbdev: matroxfb: " Ai Chao
2026-04-25  6:58 ` [PATCH 02/35] fbdev: i810: " Ai Chao
2026-04-25  6:58 ` Ai Chao [this message]
2026-04-25  8:08   ` [PATCH 03/35] fbdev: sisfb: " Helge Deller
2026-04-25 11:02     ` David Laight
2026-04-25  6:58 ` [PATCH 04/35] fbdev: geode: " Ai Chao
2026-04-25  6:58 ` [PATCH 05/35] fbdev: atafb: " Ai Chao
2026-04-25  6:58 ` [PATCH 06/35] fbdev: tdfxfb: " Ai Chao
2026-04-25  6:58 ` [PATCH 07/35] fbdev: pm2fb: " Ai Chao
2026-04-25  6:58 ` [PATCH 08/35] fbdev: xen-fbfront: " Ai Chao
2026-04-25  6:59 ` [PATCH 09/35] fbdev: controlfb: " Ai Chao
2026-04-25  6:59 ` [PATCH 10/35] fbdev: stifb: " Ai Chao
2026-04-25  6:59 ` [PATCH 11/35] fbdev: fm2fb: " Ai Chao
2026-04-25  6:59 ` [PATCH 12/35] fbdev: arkfb: " Ai Chao
2026-04-25  6:59 ` [PATCH 13/35] fbdev: vt8500lcdfb: " Ai Chao
2026-04-25  6:59 ` [PATCH 14/35] fbdev: vt8623fb: " Ai Chao
2026-04-25  6:59 ` [PATCH 15/35] fbdev: gbefb: " Ai Chao
2026-04-25  6:59 ` [PATCH 16/35] fbdev: wm8505fb: " Ai Chao
2026-04-25  6:59 ` [PATCH 17/35] fbdev: rivafb: " Ai Chao
2026-04-25  6:59 ` [PATCH 18/35] fbdev: sh7760fb: " Ai Chao
2026-04-25  6:59 ` [PATCH 19/35] fbdev: savage: " Ai Chao
     [not found] <20260427090910.1940231-1-aichao@kylinos.cn>
2026-04-27  9:17 ` [PATCH 03/35] fbdev: sisfb: " Helge Deller
2026-04-27 13:05 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260425065926.1091168-4-aichao@kylinos.cn \
    --to=aichao@kylinos.cn \
    --cc=FlorianSchandinat@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adaplas@gmail.com \
    --cc=alchark@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=chelsyratnawat2001@gmail.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=daniel@thingy.jp \
    --cc=deller@gmx.de \
    --cc=dilinger@queued.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fourier.thomas@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linmq006@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nicolas.ferre@microchip.com \
    --cc=rene@exactco.de \
    --cc=rongqianfeng@vivo.com \
    --cc=soci@c64.rulez.org \
    --cc=thorsten.blum@linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox