From: John Madieu <john.madieu@gmail.com>
To: broonie@kernel.org, heiko@sntech.de
Cc: jon.lin@rock-chips.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
John Madieu <john.madieu@gmail.com>
Subject: [PATCH 2/3] spi: rockchip: Drop unused and broken CR0 macros
Date: Sat, 25 Apr 2026 09:29:35 +0000 [thread overview]
Message-ID: <20260425092936.2590132-3-john.madieu@gmail.com> (raw)
In-Reply-To: <20260425092936.2590132-1-john.madieu@gmail.com>
Two CTRLR0 macros are defined but never referenced, and both are wrong:
- CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere
in the tree. The intended symbol is CR0_XFM_OFFSET.
- CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register.
The value is meaningless and the macro is unused.
Drop both. They can be re-introduced correctly when an actual user
appears.
Signed-off-by: John Madieu <john.madieu@gmail.com>
---
drivers/spi/spi-rockchip.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index de39f5da62cb..231fbcf0e7aa 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -98,7 +98,6 @@
#define CR0_FRF_MICROWIRE 0x2
#define CR0_XFM_OFFSET 18
-#define CR0_XFM_MASK (0x03 << SPI_XFM_OFFSET)
#define CR0_XFM_TR 0x0
#define CR0_XFM_TO 0x1
#define CR0_XFM_RO 0x2
@@ -109,8 +108,6 @@
#define CR0_SOI_OFFSET 23
-#define CR0_MTM_OFFSET 0x21
-
/* Bit fields in SER, 2bit */
#define SER_MASK 0x3
--
2.25.1
next prev parent reply other threads:[~2026-04-25 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 9:29 [PATCH 0/3] spi: rockchip: ISR fix and minor cleanups John Madieu
2026-04-25 9:29 ` [PATCH 1/3] spi: rockchip: Read ISR, not IMR, to detect cs-inactive IRQ John Madieu
2026-04-25 9:29 ` John Madieu [this message]
2026-04-25 9:29 ` [PATCH 3/3] spi: rockchip: Drop dead zero-check on fifo_len John Madieu
2026-04-26 20:36 ` Mark Brown
[not found] ` <CAM9Qs9B8SSGXrR47toj9P+_EUHzrwKwHnu9askVhGxm9WFzQCQ@mail.gmail.com>
2026-04-26 21:03 ` Mark Brown
2026-04-26 21:57 ` (subset) [PATCH 0/3] spi: rockchip: ISR fix and minor cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260425092936.2590132-3-john.madieu@gmail.com \
--to=john.madieu@gmail.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox