From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CFE5FF885C for ; Sat, 25 Apr 2026 22:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VNEC1d+XQU6xcwJqo0QpL4AVBd93i989y6KjyJp07QI=; b=kcVz2tCztdqwT+9o5/J3Q1QLZh Ham1QG1l0yb83YNhTv0rLa8iJQMpduiozD6lm55Jb7Z3DNeIQqIiBAy/y5Xd9Udouj902uVRus0gw OxwFEExMiOnK0VkSG0C66SusxpN479NekIIRlpHmUbz2M3SNcUMuIFQDzjgB611ieBPp6h5N0+Z1j 1qkLQNa5+t0CALXdn4surZ/pMmGfhdjOrLY9hatXQ37jTVBHy1visl7nzi219Of+INre1qgdU58n8 +NXxOxIeyz5NFlw9Gha1ukcKWr0gXtybLfNZrNkKeKg1kmZTceRCtGeG/tuvv5pR3B5CxHchaSH5+ ma6DS4jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGliE-0000000Eu9O-3Bjr; Sat, 25 Apr 2026 22:42:58 +0000 Received: from mail-dy1-x134a.google.com ([2607:f8b0:4864:20::134a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGlhg-0000000EtTR-2Dcp for linux-arm-kernel@lists.infradead.org; Sat, 25 Apr 2026 22:42:25 +0000 Received: by mail-dy1-x134a.google.com with SMTP id 5a478bee46e88-2ddd8ef5343so8844131eec.1 for ; Sat, 25 Apr 2026 15:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777156943; x=1777761743; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VNEC1d+XQU6xcwJqo0QpL4AVBd93i989y6KjyJp07QI=; b=p/U2nKM1LG2Z0l7VVMoEjuYj3iIAS3cAqjIZG1WOxnVJhgsFWHmMyYuEOIU2B6rvv+ b7D+1hFVMASX2V5LPMTfvu6tSd5JstjIOZGZRHzfY6uo8+MbIOz3MoE3HIUtbcirOqPY eUmS9QgNQl+zfp2Vj0x3rJxjBD7tlpRmlnLKrj01GtB6jbg/yVTMLhX2h0YXfok7plUI MpKK521aQAxK5dvTUN2gp/VKzRUrEJImYWx2D8yBxpozL3cKQWfTKSlUqMQ8TXoXDvKC 0mufcSECR7cr2TEvJ1rdeHIkFha5vlCDbC+bmDPD4srloonba254HgGrBUz7GSBerA7q 5ENQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777156943; x=1777761743; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VNEC1d+XQU6xcwJqo0QpL4AVBd93i989y6KjyJp07QI=; b=bUd37SmO9t2UTQWoXrO392CVdp0+s1FOq8yzGBIWKr74wykuL0wweyEe8ZD6qLsCjL /wZlxRHFLIBb0WOS69wyxS+uCBzwAdc2tE6TBeVaPpR0xjFLn5i+3WQXCq/dumMOyUSV /vP0d5knt61uhC3x1dl7A36rjtiu7j1ARPQsWazAKoYppLD76UGSfNVJs+VuM0QGvFOo JUPTtgd1e932/z5h5t8aaKXOuZvFAtLCrNXPSRUWwLoWe5SHFASABQT7lIuMvZOb8zm8 NHhkpCFnz9WnTEWyZW7gIlMkgveoL7hGxoQ15zrybXlR1KNjbbWX1P/buxLqNYFsTW/U oeDA== X-Forwarded-Encrypted: i=1; AFNElJ+c/GNBdlnYufBDPH/9EcHyQSoX6Kc9N4rVssrm7uWKxnjwCXR1KVN2DMcR9ho5I1ScxqxhJcEfIHzvxKa8lRZe@lists.infradead.org X-Gm-Message-State: AOJu0YzTtEQlTXN1mjYq54STuCDMFPamvi/6/oqoYyszdag38JVhHrvW UQCePCZuV++n7SdX72PvE4ywZiVb1fw9PK4YPgUJmfcmgC4+hS4rh68rlDd6tO5ezDwueJkDLoM vvHPa8DEQoA== X-Received: from dycqr6.prod.google.com ([2002:a05:7300:ff46:b0:2dd:67ce:b8c5]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:8005:b0:2dd:144b:6c2 with SMTP id 5a478bee46e88-2e478e28c50mr14956952eec.27.1777156943041; Sat, 25 Apr 2026 15:42:23 -0700 (PDT) Date: Sat, 25 Apr 2026 15:40:50 -0700 In-Reply-To: <20260425224125.160890-1-irogers@google.com> Mime-Version: 1.0 References: <20260425174858.3922152-1-irogers@google.com> <20260425224125.160890-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260425224125.160890-26-irogers@google.com> Subject: [PATCH v7 25/59] perf stat-cpi: Port stat-cpi to use python module From: Ian Rogers To: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, leo.yan@linux.dev, namhyung@kernel.org, tmricht@linux.ibm.com Cc: alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260425_154224_582276_C56AFE5E X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Port stat-cpi.py from the legacy framework to a standalone script. Support both file processing mode (using perf.session) and live mode (reading counters directly via perf.parse_events and evsel.read). Use argparse for command line options handling. Calculate and display CPI (Cycles Per Instruction) per interval per CPU/thread. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: 1. Accurate CPI Calculation (Multiplexing Support): - Before: The get() method returned the raw counter value directly, ignoring whether the counter ran for the full interval. - After: The get() method now scales the raw value by the ratio of enabled time to running time ( val * (ena / float(run)) ) when run > 0 . This handles cases where PMU counters are overcommitted and multiplexed. 2. Per-Interval CPI in File Mode: - Before: store() saved absolute counter values as read from PERF_RECORD_STAT . Since these are cumulative from the start of the trace, and data.clear() was called every round, the script computed cumulative CPI rather than per-interval CPI. - After: store() now computes the delta between the current absolute value and the value from the previous interval. It saves this delta in self.data and retains the absolute value in self. prev_data for the next delta computation. 3. Prevention of Dummy Output (Cartesian Product Fix): - Before: self.cpus and self.threads lists accumulated all unique CPUs and threads seen independently. The nested loops in print_interval() then created a Cartesian product of all seen CPUs and threads, querying data for combinations that might never have occurred. - After: Replaced lists with a self.recorded_pairs set that stores (cpu, thread) tuples only when a sample actually records them. The output loop now iterates strictly over these verified pairs. --- tools/perf/python/stat-cpi.py | 151 ++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+) create mode 100755 tools/perf/python/stat-cpi.py diff --git a/tools/perf/python/stat-cpi.py b/tools/perf/python/stat-cpi.py new file mode 100755 index 000000000000..4b1f1f69c94a --- /dev/null +++ b/tools/perf/python/stat-cpi.py @@ -0,0 +1,151 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +"""Calculate CPI from perf stat data or live.""" + +import argparse +import sys +import time +from typing import Any, Optional +import perf + +class StatCpiAnalyzer: + """Accumulates cycles and instructions and calculates CPI.""" + + def __init__(self, args: argparse.Namespace) -> None: + self.args = args + self.data: dict[str, tuple[int, int, int]] = {} + self.prev_data: dict[str, tuple[int, int, int]] = {} + self.recorded_pairs: set[tuple[int, int]] = set() + + def get_key(self, event: str, cpu: int, thread: int) -> str: + """Get key for data dictionary.""" + return f"{event}-{cpu}-{thread}" + + def store_key(self, cpu: int, thread: int) -> None: + """Store CPU and thread IDs.""" + self.recorded_pairs.add((cpu, thread)) + + def store(self, event: str, cpu: int, thread: int, counts: tuple[int, int, int]) -> None: + """Store counter values, computing difference from previous absolute values.""" + self.store_key(cpu, thread) + key = self.get_key(event, cpu, thread) + + val, ena, run = counts + if key in self.prev_data: + prev_val, prev_ena, prev_run = self.prev_data[key] + cur_val = val - prev_val + cur_ena = ena - prev_ena + cur_run = run - prev_run + else: + cur_val = val + cur_ena = ena + cur_run = run + + self.data[key] = (cur_val, cur_ena, cur_run) + self.prev_data[key] = counts # Store absolute value for next time + + def get(self, event: str, cpu: int, thread: int) -> float: + """Get scaled counter value.""" + key = self.get_key(event, cpu, thread) + if key not in self.data: + return 0.0 + val, ena, run = self.data[key] + if run > 0: + return val * (ena / float(run)) + return float(val) + + def process_stat_event(self, event: Any, name: Optional[str] = None) -> None: + """Process PERF_RECORD_STAT and PERF_RECORD_STAT_ROUND events.""" + if event.type == perf.RECORD_STAT: + if name: + if "cycles" in name: + event_name = "cycles" + elif "instructions" in name: + event_name = "instructions" + else: + return + self.store(event_name, event.cpu, event.thread, (event.val, event.ena, event.run)) + elif event.type == perf.RECORD_STAT_ROUND: + timestamp = getattr(event, "time", 0) + self.print_interval(timestamp) + self.data.clear() + self.recorded_pairs.clear() + + def print_interval(self, timestamp: int) -> None: + """Print CPI for the current interval.""" + for cpu, thread in sorted(self.recorded_pairs): + cyc = self.get("cycles", cpu, thread) + ins = self.get("instructions", cpu, thread) + cpi = 0.0 + if ins != 0: + cpi = cyc / float(ins) + t_sec = timestamp / 1000000000.0 + print(f"{t_sec:15f}: cpu {cpu}, thread {thread} -> cpi {cpi:f} ({cyc:.0f}/{ins:.0f})") + + def read_counters(self, evlist: Any) -> None: + """Read counters live.""" + for evsel in evlist: + name = str(evsel) + if "cycles" in name: + event_name = "cycles" + elif "instructions" in name: + event_name = "instructions" + else: + continue + + for cpu in evsel.cpus(): + for thread in evsel.threads(): + try: + counts = evsel.read(cpu, thread) + self.store(event_name, cpu, thread, + (counts.val, counts.ena, counts.run)) + except OSError: + pass + + def run_file(self) -> None: + """Process events from file.""" + session = perf.session(perf.data(self.args.input), stat=self.process_stat_event) + session.process_events() + + def run_live(self) -> None: + """Read counters live.""" + evlist = perf.parse_events("cycles,instructions") + if not evlist: + print("Failed to parse events", file=sys.stderr) + return + try: + evlist.open() + except OSError as e: + print(f"Failed to open events: {e}", file=sys.stderr) + return + + print("Live mode started. Press Ctrl+C to stop.") + try: + while True: + time.sleep(self.args.interval) + timestamp = time.time_ns() + self.read_counters(evlist) + self.print_interval(timestamp) + self.data.clear() + self.recorded_pairs.clear() + except KeyboardInterrupt: + print("\nStopped.") + finally: + evlist.close() + +def main() -> None: + """Main function.""" + ap = argparse.ArgumentParser(description="Calculate CPI from perf stat data or live") + ap.add_argument("-i", "--input", help="Input file name (enables file mode)") + ap.add_argument("-I", "--interval", type=float, default=1.0, + help="Interval in seconds for live mode") + args = ap.parse_args() + + analyzer = StatCpiAnalyzer(args) + if args.input: + analyzer.run_file() + else: + analyzer.run_live() + +if __name__ == "__main__": + main() -- 2.54.0.545.g6539524ca2-goog