From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46B99FF885A for ; Sat, 25 Apr 2026 22:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nQeNxtOSoOXwV2zRr64LvO5u7apubipAzZoDUg3KnRw=; b=BFoufEu/khNhundIJPwCWr2srm p2qgVesxa3SGwiIFcRLEXAcP78g+drMBV5Qm4+BH2Z1B6Jo00MVOuWfG21D4Kt1lPnUV9btuFpqLr I4z9dBBisxrQ1zN/ls1X9SiEJwMH+0DkL+5y+ATqZw4n4/9inK6wmi4SUeGpgRTYiDr2EvKKGeXUb IYW6YiTJ64/fLAvI/l/NU5infml8hahjwidl6fyDQhodbtIfFHrjCoehLvis/ELuAAyqJqCuox2W7 SvPaVlQbBfF6rkwOmBtU+DLuG/rClbkp5taNp841cxhumidFEQW5qlXCTyclMW2eY1j7D/oI4caEg GeN/FBtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGlsK-0000000F1BD-0VzC; Sat, 25 Apr 2026 22:53:24 +0000 Received: from mail-dl1-x124a.google.com ([2607:f8b0:4864:20::124a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGlqo-0000000EzRe-3NAJ for linux-arm-kernel@lists.infradead.org; Sat, 25 Apr 2026 22:52:12 +0000 Received: by mail-dl1-x124a.google.com with SMTP id a92af1059eb24-12c35f2c09dso11363464c88.0 for ; Sat, 25 Apr 2026 15:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777157508; x=1777762308; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nQeNxtOSoOXwV2zRr64LvO5u7apubipAzZoDUg3KnRw=; b=NaLzebipf23PcRp1BAi/W6AvnEszt0/KTllTtlxD9DUD+JW02/c/IBhPIU96EPSgei b+V/qLgpZmD5xJoPwz4cbsqDUuquAQx6G1wa6mFdQz/WR+8AwhLHu0DUirBajGmkMgUL UEwLvZO/2QhnedUvLLYzvA4jJjfj/23AXT3tXa7N6twMi34IrlTdBst0Px1Re/1FLPGr A63CSjyap+4D9cl5+0SCzMlHblCuTC6Lk19sXS8NFHSrgFXiUOD04x8iNUSEzVebhUzl K11Ef4XD3y74zZS0mz3iGqA+4eL6Bz4/gZ9uovJwAV6SU12YnVkD2oSrvU8U20Kmvt1+ COaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777157508; x=1777762308; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nQeNxtOSoOXwV2zRr64LvO5u7apubipAzZoDUg3KnRw=; b=iloOr+hstoPb0hkj0v1QMAy031ar5w0ah9Kw2fECwO2RH32X5Wph3wC3rO65gfjhzp t5maa89hwveH6z5LtsCodGuT7ABS0+1AiiUeWJsIIh63fLAbmjgaT/421YVm4UB+7bGF ahEeBgALE2K691pUsPeYbNYo9sOQMo7CoF/lW5NZfNvsfqzChn57rh+80tst9cX41xjI ILLR+p0jEE2pttdEkLb+VqrIGTU40Q8cYDBdzlqkrNJc+jKVyOnGm+b9D5OnHYJOeRNq 5tZ/1D4XP+QaKZ+g/phAsDyavDKdNWSsBTSA6PlZMGzEDSTdlm9XiOsVmsiMJmYXm/yM Tn2Q== X-Forwarded-Encrypted: i=1; AFNElJ9kB2OTULMOlAH9DtzdBC1xWC+RlsWeEHiKdqeB9drLbcRTGTG3EC+X2n5slgBbb8KvmOBkedsQFxk3DY3blgOe@lists.infradead.org X-Gm-Message-State: AOJu0YwQ6HV+kWl8NCBcNogVd/HHTSj6eiKNeMpv/2UpB3q9280nLzUc ojAJW6f2JyDGL/UCi+V6bgD61mvkzB9rCafp3oaO4dId/YRuHR7XGf2e3roTbLAs+ppr1Ft2LiG Bieb0r5Z6ug== X-Received: from dlam5-n2.prod.google.com ([2002:a05:701b:2085:20b0:12d:bf8b:c653]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:3d87:b0:124:9fd8:4ba9 with SMTP id a92af1059eb24-12c73f6cd01mr20920875c88.12.1777157507662; Sat, 25 Apr 2026 15:51:47 -0700 (PDT) Date: Sat, 25 Apr 2026 15:49:37 -0700 In-Reply-To: <20260425224951.174663-1-irogers@google.com> Mime-Version: 1.0 References: <20260425174858.3922152-1-irogers@google.com> <20260425224951.174663-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260425224951.174663-46-irogers@google.com> Subject: [PATCH v7 45/59] perf stackcollapse: Port stackcollapse to use python module From: Ian Rogers To: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, leo.yan@linux.dev, namhyung@kernel.org, tmricht@linux.ibm.com Cc: alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260425_155150_940142_7D507A10 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Modernize the legacy stackcollapse.py trace script by refactoring it into a class-based architecture (StackCollapseAnalyzer). The script uses perf.session for event processing and aggregates call stacks to produce output suitable for flame graphs. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: - Fixed Callchain Check: Replaced hasattr(sample, "callchain") with getattr(sample, "callchain", None) and checked if it is not None . This avoids attempting to iterate over None when a sample lacks a callchain, which would raise a TypeError. - Fixed Comm Resolution: The code already used self.session.process(sample.sample_pid).comm() to resolve the command name using the session object (if available), avoiding the missing comm attribute on perf.sample_event. - Code Cleanup: Broke a long line in process_event to satisfy pylint. --- tools/perf/python/stackcollapse.py | 126 +++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) create mode 100755 tools/perf/python/stackcollapse.py diff --git a/tools/perf/python/stackcollapse.py b/tools/perf/python/stackcollapse.py new file mode 100755 index 000000000000..996c73246ebc --- /dev/null +++ b/tools/perf/python/stackcollapse.py @@ -0,0 +1,126 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +""" +stackcollapse.py - format perf samples with one line per distinct call stack + +This script's output has two space-separated fields. The first is a semicolon +separated stack including the program name (from the "comm" field) and the +function names from the call stack. The second is a count: + + swapper;start_kernel;rest_init;cpu_idle;default_idle;native_safe_halt 2 + +The file is sorted according to the first field. + +Ported from tools/perf/scripts/python/stackcollapse.py +""" + +import argparse +from collections import defaultdict +import sys +import perf + + +class StackCollapseAnalyzer: + """Accumulates call stacks and prints them collapsed.""" + + def __init__(self, args: argparse.Namespace) -> None: + self.args = args + self.lines: dict[str, int] = defaultdict(int) + + def tidy_function_name(self, sym: str, dso: str) -> str: + """Beautify function names based on options.""" + if sym is None: + sym = "[unknown]" + + sym = sym.replace(";", ":") + if self.args.tidy_java: + # Beautify Java signatures + sym = sym.replace("<", "") + sym = sym.replace(">", "") + if sym.startswith("L") and "/" in sym: + sym = sym[1:] + try: + sym = sym[:sym.index("(")] + except ValueError: + pass + + if self.args.annotate_kernel and dso == "[kernel.kallsyms]": + return sym + "_[k]" + return sym + + def process_event(self, sample: perf.sample_event) -> None: + """Collect call stack for each sample.""" + stack = [] + callchain = getattr(sample, "callchain", None) + if callchain is not None: + for node in callchain: + stack.append(self.tidy_function_name(node.symbol, node.dso)) + else: + # Fallback if no callchain + sym = getattr(sample, "symbol", "[unknown]") + dso = getattr(sample, "dso", "[unknown]") + stack.append(self.tidy_function_name(sym, dso)) + + if self.args.include_comm: + if hasattr(self, 'session') and self.session: + comm = self.session.find_thread(sample.sample_pid).comm() + else: + comm = "Unknown" + comm = comm.replace(" ", "_") + sep = "-" + if self.args.include_pid: + comm = f"{comm}{sep}{getattr(sample, 'sample_pid', 0)}" + sep = "/" + if self.args.include_tid: + comm = f"{comm}{sep}{getattr(sample, 'sample_tid', 0)}" + stack.append(comm) + + stack_string = ";".join(reversed(stack)) + self.lines[stack_string] += 1 + + def print_totals(self) -> None: + """Print sorted collapsed stacks.""" + for stack in sorted(self.lines): + print(f"{stack} {self.lines[stack]}") + + +def main(): + """Main function.""" + ap = argparse.ArgumentParser( + description="Format perf samples with one line per distinct call stack" + ) + ap.add_argument("-i", "--input", default="perf.data", help="Input file name") + ap.add_argument("--include-tid", action="store_true", help="include thread id in stack") + ap.add_argument("--include-pid", action="store_true", help="include process id in stack") + ap.add_argument("--no-comm", dest="include_comm", action="store_false", default=True, + help="do not separate stacks according to comm") + ap.add_argument("--tidy-java", action="store_true", help="beautify Java signatures") + ap.add_argument("--kernel", dest="annotate_kernel", action="store_true", + help="annotate kernel functions with _[k]") + + args = ap.parse_args() + + if args.include_tid and not args.include_comm: + print("requesting tid but not comm is invalid", file=sys.stderr) + sys.exit(1) + if args.include_pid and not args.include_comm: + print("requesting pid but not comm is invalid", file=sys.stderr) + sys.exit(1) + + analyzer = StackCollapseAnalyzer(args) + + try: + session = perf.session(perf.data(args.input), sample=analyzer.process_event) + analyzer.session = session + session.process_events() + except IOError as e: + print(f"Error: {e}", file=sys.stderr) + sys.exit(1) + except KeyboardInterrupt: + pass + + analyzer.print_totals() + + +if __name__ == "__main__": + main() -- 2.54.0.545.g6539524ca2-goog