Re: [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones

Jonathan Cameron
2026-04-27T10:05:59Z

On Mon, 27 Apr 2026 08:42:55 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Sun, 26 Apr 2026 at 23:20, Caio Morais <caiomorais@usp.br> wrote:
> >
> > From: Caio Morais <caiomorais@usp.br>
> >
> > Signed-off-by: Caio Morais <caiomorais@usp.br>
> > ---
>
> You're missing the commit message body. While it's understandable
> what changes you've done in this patch, it's good to expand the idea
> further (what you did, how you did it, why you did it). This goes for all
> of the patches in your series.

Also, why only this file of the several that make up that driver?
Looks like kernel.h is included in xilinx-xadc-core.c as well.

I'd talk about kernel.h specifically in the patch description and
why stopping including that is seen as a nice to have.

>
> > +#include <linux/bitmap.h>
> > +#include <linux/errno.h>
> > +#include <linux/mutex.h>
> > +#include <linux/types.h>
> > +
> > #include <linux/iio/events.h>
> > #include <linux/iio/iio.h>
> > -#include <linux/kernel.h>
> >
> > #include "xilinx-xadc.h"
> >
> > --
> > 2.54.0
> >
> >