Re: [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones

Joshua Crofts
2026-04-27T06:43:14Z

On Sun, 26 Apr 2026 at 23:20, Caio Morais <caiomorais@usp.br> wrote:
>
> From: Caio Morais <caiomorais@usp.br>
>
> Signed-off-by: Caio Morais <caiomorais@usp.br>
> ---

You're missing the commit message body. While it's understandable
what changes you've done in this patch, it's good to expand the idea
further (what you did, how you did it, why you did it). This goes for all
of the patches in your series.

> +#include <linux/bitmap.h>
> +#include <linux/errno.h>
> +#include <linux/mutex.h>
> +#include <linux/types.h>
> +
> #include <linux/iio/events.h>
> #include <linux/iio/iio.h>
> -#include <linux/kernel.h>
>
> #include "xilinx-xadc.h"
>
> --
> 2.54.0
>
>