Re: [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones

Joshua Crofts
2026-04-27T10:00:27Z

On Mon, 27 Apr 2026 at 11:50, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:

> Dunno if it's your first review (congrats in that case!), but I fully agree with.

Yes, this is my first review :)

> We do not accept patches with the empty commit message bodies.
> (*Yes, it used to be okay twenty ears ago, but now.)

I maybe also take issue with the fact that the series (although they are
the same logical change) is composed of changes in different iio
subsystems (adc, buffer and common). Shouldn't these be sent
separately?

--
Kind regards

CJD