From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: airoha: Do not read uninitialized fragment address in airoha_dev_xmit()
Date: Mon, 27 Apr 2026 17:39:35 -0700 [thread overview]
Message-ID: <20260427173935.6a1e36ee@kernel.org> (raw)
In-Reply-To: <aezLa2POvT0It5AA@lore-desk>
On Sat, 25 Apr 2026 16:10:51 +0200 Lorenzo Bianconi wrote:
> - Does the TSO checksum calculation earlier in this function ensure the
> TCP header is in the linear portion of the SKB?
> This issue is not related to the current patch. Moreover, can we have a TSO
> packet where the tcp header is not in the linear area of the skb?
Don't think so.
> - If dma_map_single() fails partway through a multi-fragment packet and
> triggers this goto error_unmap, will it break the Tx ring contiguity?
> This issue is not related to the current patch. Moreover, I guess the hw is
> capable of managing out-of-order descriptors.
>
> - Is it safe to map fragment data using dma_map_single() instead of
> skb_frag_dma_map()?
> This issue is not related to the current patch. I will post a dedicated patch
> for it.
I don't think it's an issue. Unless you support DMABUF zero-copy
the skb_frag helper is just for convenience. I wouldn't bother.
next prev parent reply other threads:[~2026-04-28 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:00 [PATCH net] net: airoha: Do not read uninitialized fragment address in airoha_dev_xmit() Lorenzo Bianconi
2026-04-25 14:10 ` Lorenzo Bianconi
2026-04-28 0:39 ` Jakub Kicinski [this message]
2026-04-28 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427173935.6a1e36ee@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox