From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B65FFF8868 for ; Tue, 28 Apr 2026 09:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Is6xGi5GYWmiEnjrUUIDhp2RdEA1LY4b9Jww/X6p7Fc=; b=oc9SpcWX/6SX0k5nCMuLX0ibaL 1ZT+e5FeuULqUo+p+ALNdET+SLm4VNlEuEq8mGHkg5mV/YLgWkv+HX0JpWrZVYcdjXgOoNrH9FGA4 OR1ykxabI6OsCRBYW17t2vbAWBFMjb1iN13n6tqCshZB3kN3PWMdhXJN7GEL/mA9gMpDdE2/EHKTK EeMUUh8ogf/ZT0ygsvwEdSQS60YROasKbijrbLUBG6cT0k7b4IFrGcqe3eIFkE7sfkbHWGKuc0ZiC wpSsMMKDD/A2lcGObTY7S8Rw8epUpfFrsRN50kmPCUyTDskWOnAcpk5Cght0Z06V6Vs1rF4PTdKpC 8rYAmB4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHeYp-000000013z3-1EKY; Tue, 28 Apr 2026 09:16:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHeYn-000000013wp-0oPp for linux-arm-kernel@bombadil.infradead.org; Tue, 28 Apr 2026 09:16:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=Is6xGi5GYWmiEnjrUUIDhp2RdEA1LY4b9Jww/X6p7Fc=; b=GnzQt+orgHb9kyIGTNs6E1WMq7 mK1WmvzS4coJTCCVP7fGNXixiX1ZbSnuwIJxEXEPSQjh1NkTO6NciEPESAmgq5Qs8n7L53zlbMens SaZkAN9apiPZ2Ii3yw9T4Ni24tJWXz4bkmev/KhG4145LUtr5fUv7cjdLA7YZeMfmgx3xPk1QCDy/ lV1z8lhBLLBwOgl2wShlYPnVMBl+Fms0F4rkALylc8CBS/tKMyFtlfH501gEXzm3Ftts1TACnKWyY 5I0x1iH5PZUhioT04WO5JJV9tYW8aWg4sJkWYMLJNZkEoM19wg5TOB917b3iUb0FuLa2BTBvA++c0 fTFeaO5A==; Received: from smtpout-04.galae.net ([185.171.202.116]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHeYi-00000002Y0R-0tm2 for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2026 09:16:51 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id F0C0DC5CD52; Tue, 28 Apr 2026 09:17:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 64C1E601D0; Tue, 28 Apr 2026 09:16:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E4342107285D0; Tue, 28 Apr 2026 11:16:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777367804; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Is6xGi5GYWmiEnjrUUIDhp2RdEA1LY4b9Jww/X6p7Fc=; b=xjomQkTf5BvzlAO/2ZP6+rVEnI8vsXk5utCNDzsnO7qfn0waLW+pHHmsokAzIcgfPlJLDv GsJauK6RNjVIU6aIFlweNZHiq71xpXzIYCvNhRg9hu9FhfSvY4cWEUwCaW3fSPbXey44hK NLxiFeKGj80QjCelp6JANPzgueMuTnmhepM+OIJU8SO9tXM6OkcXaqTXcrCE83goUFfIw9 bNDYfljLYQ/SamAUTqX/BnxJky96isxtojgHy34r6jFS1ptfE1E/PPyhzVldPYnBYIgV49 8+BiKm3SaApND0VhcBm0f72uEK1oi6uFc8qH1M5rPtuLs1HHZxALEwNSe6Xr8A== From: Luca Ceresoli Date: Tue, 28 Apr 2026 11:15:54 +0200 Subject: [PATCH v2 08/11] drm/bridge: adv7511: switch to of_drm_get_bridge_by_endpoint() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-drm-bridge-alloc-getput-panel_or_bridge-v2-8-4300744a1c47@bootlin.com> References: <20260428-drm-bridge-alloc-getput-panel_or_bridge-v2-0-4300744a1c47@bootlin.com> In-Reply-To: <20260428-drm-bridge-alloc-getput-panel_or_bridge-v2-0-4300744a1c47@bootlin.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tian Tao , Xinwei Kong , Sumit Semwal , John Stultz , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Tomi Valkeinen , Michal Simek Cc: Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Luca Ceresoli X-Mailer: b4 0.15.2 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260428_101648_428672_7877D986 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver calls drm_of_find_panel_or_bridge() with a NULL pointer in the @panel parameter, thus using a reduced feature set of that function. Replace this call with the simpler of_drm_get_bridge_by_endpoint(). Since of_drm_get_bridge_by_endpoint() increases the refcount of the returned bridge, ensure it is put on removal. To achieve this, instead of adding an explicit drm_bridge_put(), migrate to the bridge::next_bridge pointer which is automatically put when the bridge is eventually freed. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 - drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 11 +++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 8be7266fd4f4..12c95198d9a4 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h @@ -354,7 +354,6 @@ struct adv7511 { enum drm_connector_status status; bool powered; - struct drm_bridge *next_bridge; struct drm_display_mode curr_mode; unsigned int f_tmds; diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 6bd76c1fb007..498e38579a0f 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -851,8 +851,8 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge, struct adv7511 *adv = bridge_to_adv7511(bridge); int ret = 0; - if (adv->next_bridge) { - ret = drm_bridge_attach(encoder, adv->next_bridge, bridge, + if (adv->bridge.next_bridge) { + ret = drm_bridge_attach(encoder, adv->bridge.next_bridge, bridge, flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) return ret; @@ -1251,10 +1251,9 @@ static int adv7511_probe(struct i2c_client *i2c) memset(&link_config, 0, sizeof(link_config)); - ret = drm_of_find_panel_or_bridge(dev->of_node, 1, -1, NULL, - &adv7511->next_bridge); - if (ret && ret != -ENODEV) - return ret; + adv7511->bridge.next_bridge = of_drm_get_bridge_by_endpoint(dev->of_node, 1, -1); + if (IS_ERR(adv7511->bridge.next_bridge) && PTR_ERR(adv7511->bridge.next_bridge) != -ENODEV) + return PTR_ERR(adv7511->bridge.next_bridge); if (adv7511->info->link_config) ret = adv7511_parse_dt(dev->of_node, &link_config); -- 2.53.0