Re: [PATCH v3 10/11] drm: zynqmp_dp: switch to of_drm_get_bridge_by_endpoint()

Luca Ceresoli
2026-04-28T16:53:30Z

On Tue Apr 28, 2026 at 5:37 PM CEST, Biju Das wrote:
>> @@ -2461,10 +2459,15 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
>> * Acquire the next bridge in the chain. Ignore errors caused by port@5
>> * not being connected for backward-compatibility with older DTs.
>> */
>> - ret = drm_of_find_panel_or_bridge(dp->dev->of_node, 5, 0, NULL,
>> - &dp->next_bridge);
>> - if (ret < 0 && ret != -ENODEV)
>> - goto err_reset;
>> + dp->bridge.next_bridge = of_drm_get_bridge_by_endpoint(dp->dev->of_node, 5, 0);
>> + if (IS_ERR(dp->bridge.next_bridge)) {
>> + if (PTR_ERR(dp->bridge.next_bridge) == -ENODEV) {
>> + dp->bridge.next_bridge;
>
>
> A warning on this patch
>
> drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_probe’:
> drivers/gpu/drm/xlnx/zynqmp_dp.c:2465:35: warning: statement with no effect [-Wunused-value]
> 2465 | dp->bridge.next_bridge;
> | ~~~~~~~~~~^~~~~~~~~~~~

Ouch. Guess I should have pondered a bit longer before sending, will do
before v4...

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering