From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94144FF8870 for ; Tue, 28 Apr 2026 07:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+1e9d0GFF8QSKEFlq8avcbJMHsTR7P2tC3S887pI/aQ=; b=opNUXyN6OqrQj81GBchn/PrFs0 5buvCxNATM1QAUmrATLCrBl5fCaKcrV63zXHwsmqavYJ5aOWDOUYcyVt/U/8XA3rIdtxi34Ed6QyI 8WmVRqKeS9UW6FEe4kgCtdrj1bKX9YogghqunG8UDDBMmxvPxYaoIcX14XMwvwvvTGGBVTSxTZ8VP VEUqowOq50MRUvR9QG+K1sufksbBnh3NJRbbR95vJM941tvE8i4JZmW/5X1EACD5ELWG3VBBbKAFK 3ZZz1IUTRT+UrJ/v3tDft55f1c+nd7AMxdhwh3Q8wY2dhiqn0rXxoNIjtK1TcQQC8DJUC6bcbIw/U YkSdxKSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHcl8-00000000iU9-05W2; Tue, 28 Apr 2026 07:21:30 +0000 Received: from mail-dl1-x1249.google.com ([2607:f8b0:4864:20::1249]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHckG-00000000hUk-2wEm for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2026 07:20:43 +0000 Received: by mail-dl1-x1249.google.com with SMTP id a92af1059eb24-12c726f4019so14412326c88.1 for ; Tue, 28 Apr 2026 00:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777360836; x=1777965636; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+1e9d0GFF8QSKEFlq8avcbJMHsTR7P2tC3S887pI/aQ=; b=ZRWPhkzSjIWqQardSaq+lsiE0VR9/HTdH7DGUmtp4iZOdPyvCibOvsBxoSanW25wKI lJLsJO8ldLtsHtABS5GTAl+OMYdXkZ1/cJmTYbEJGZSTSNAcMfz8oAqObrwwKs2e8otg I0t+eTAHM5XA27V2xbhCtFArSA3SyPA05AzaTNYXd+1pY0Mr9pQlnRMs/jfc5wvUF/oN nRf4ifnOzTKTcagChH8WWf5LVPu3IPXHAcya5rcWDsl2KmLphlhUeNmZtU7OHl0Y3ltC FQZsW//dUa1FsEezhGEtmQpTjqU+Rc7uSzl69cMHtt6Nq/iAZB3cXZf5f5KoofWPpcWm myVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777360836; x=1777965636; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+1e9d0GFF8QSKEFlq8avcbJMHsTR7P2tC3S887pI/aQ=; b=IpBJSYjRZTipF2QzuEi1wjF3cJnKt9Vl0OZeqolc4SUOidkFcgMh0NDnEctYaMRk9e kE1+mxvijPhV14E+szFYYGhwmMnZznUzrvDOLccG0SxW9SraqhFbDydKCGzj6+96H+aw tbpdADAEfUOJbhKG+iD+6g4jCq5mgH4hVyQBho45D2TvkvarVqV4Dog9liZ5vtggBkIB sgTgTK3rno1vbCWFNNSsAi0Y6mTb//UZ7/MDhyLrSP+xYjP76iHa06dV/QFhBeGpp7FJ IapjAiRcZFEuh2K9XemCqm/Os6T2CMLuqMvfPmciOcSzarhXN500apRusKTDemD44NVk w9kA== X-Forwarded-Encrypted: i=1; AFNElJ/WbHRGeHNr0yDgtaBzWMwHyNqYCmzGrf4cLenPbOiz/cBrBf14KW9B9AZLI7F4Pgdrs4FKsLwtuYfSiM3SSEb9@lists.infradead.org X-Gm-Message-State: AOJu0YzF+eib7Rt3w0QRF1yL/I3bMSHR8dB4j/jmk0xabEj1Ky03jClz vEQeFRymJteiTcb80FFOYDk7duzjWqUis23F1QDQ9Vjcul1PXAysaKTFBE5HCUN3adDP/DBvvrt 5cx8h8ijGjg== X-Received: from dlaf13.prod.google.com ([2002:a05:701b:240d:b0:12d:b8e9:7851]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:927:b0:12d:de3e:86b4 with SMTP id a92af1059eb24-12dde3e8939mr426608c88.36.1777360835574; Tue, 28 Apr 2026 00:20:35 -0700 (PDT) Date: Tue, 28 Apr 2026 00:18:43 -0700 In-Reply-To: <20260428071903.1886173-1-irogers@google.com> Mime-Version: 1.0 References: <20260425224951.174663-1-irogers@google.com> <20260428071903.1886173-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260428071903.1886173-39-irogers@google.com> Subject: [PATCH v8 38/58] perf failed-syscalls-by-pid: Port failed-syscalls-by-pid to use python module From: Ian Rogers To: acme@kernel.org, namhyung@kernel.org Cc: adrian.hunter@intel.com, alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, james.clark@linaro.org, leo.yan@linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, tmricht@linux.ibm.com, Ian Rogers Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260428_002036_770187_EE7DD309 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ported from tools/perf/scripts/python/failed-syscalls-by-pid.py to use the perf Python module API. Key changes: - Used perf.syscall_name() to resolve syscall names instead of legacy Util library. - Used standard collections.defaultdict for nested statistics aggregation. - Used errno.errorcode for resolving error strings. - Supported optional filtering by COMM or PID via command line arguments. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: Fixed Syscall Name Fallback: Handled the case where perf.syscall_name() returns None , falling back to the string representation of the syscall ID to avoid TypeError during string formatting. v7: - Removed dead code (unused self.unhandled dictionary). --- tools/perf/python/failed-syscalls-by-pid.py | 116 ++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100755 tools/perf/python/failed-syscalls-by-pid.py diff --git a/tools/perf/python/failed-syscalls-by-pid.py b/tools/perf/python/failed-syscalls-by-pid.py new file mode 100755 index 000000000000..eecd553cbf8f --- /dev/null +++ b/tools/perf/python/failed-syscalls-by-pid.py @@ -0,0 +1,116 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +""" +Displays system-wide failed system call totals, broken down by pid. +If a [comm] or [pid] arg is specified, only syscalls called by it are displayed. + +Ported from tools/perf/scripts/python/failed-syscalls-by-pid.py +""" + +import argparse +from collections import defaultdict +import errno +from typing import Optional +import perf + + +def strerror(nr: int) -> str: + """Return error string for a given errno.""" + try: + return errno.errorcode[abs(nr)] + except KeyError: + return f"Unknown {nr} errno" + + +class SyscallAnalyzer: + """Analyzes failed syscalls and aggregates counts.""" + + def __init__(self, for_comm: Optional[str] = None, for_pid: Optional[int] = None): + self.for_comm = for_comm + self.for_pid = for_pid + self.session: Optional[perf.session] = None + self.syscalls: dict[tuple[str, int, int, int], int] = defaultdict(int) + + def process_event(self, sample: perf.sample_event) -> None: + """Process a single sample event.""" + event_name = str(sample.evsel) + if "sys_exit" not in event_name: + return + + pid = sample.sample_pid + if hasattr(self, 'session') and self.session: + comm = self.session.find_thread(pid).comm() + else: + comm = "Unknown" + + if self.for_comm and comm != self.for_comm: + return + if self.for_pid and pid != self.for_pid: + return + + ret = getattr(sample, "ret", 0) + if ret < 0: + syscall_id = getattr(sample, "id", -1) + if syscall_id == -1: + syscall_id = getattr(sample, "sys_id", -1) + + if syscall_id != -1: + self.syscalls[(comm, pid, syscall_id, ret)] += 1 + + def print_summary(self) -> None: + """Print aggregated statistics.""" + if self.for_comm is not None: + print(f"\nsyscall errors for {self.for_comm}:\n") + elif self.for_pid is not None: + print(f"\nsyscall errors for PID {self.for_pid}:\n") + else: + print("\nsyscall errors:\n") + + print(f"{'comm [pid]':<30} {'count':>10}") + print(f"{'-' * 30:<30} {'-' * 10:>10}") + + sorted_keys = sorted(self.syscalls.keys(), key=lambda k: (k[0], k[1], k[2])) + current_comm_pid = None + for comm, pid, syscall_id, ret in sorted_keys: + if current_comm_pid != (comm, pid): + print(f"\n{comm} [{pid}]") + current_comm_pid = (comm, pid) + try: + name = perf.syscall_name(syscall_id) or str(syscall_id) + except AttributeError: + name = str(syscall_id) + print(f" syscall: {name:<16}") + err_str = strerror(ret) + count = self.syscalls[(comm, pid, syscall_id, ret)] + print(f" err = {err_str:<20} {count:10d}") + + +if __name__ == "__main__": + ap = argparse.ArgumentParser( + description="Displays system-wide failed system call totals, broken down by pid.") + ap.add_argument("-i", "--input", default="perf.data", + help="Input file name") + ap.add_argument("filter", nargs="?", help="COMM or PID to filter by") + args = ap.parse_args() + + F_COMM = None + F_PID = None + + if args.filter: + try: + F_PID = int(args.filter) + except ValueError: + F_COMM = args.filter + + analyzer = SyscallAnalyzer(F_COMM, F_PID) + + try: + print("Press control+C to stop and show the summary") + session = perf.session(perf.data(args.input), sample=analyzer.process_event) + analyzer.session = session + session.process_events() + analyzer.print_summary() + except KeyboardInterrupt: + analyzer.print_summary() + except Exception as e: + print(f"Error processing events: {e}") -- 2.54.0.545.g6539524ca2-goog