From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31AE2FF886D for ; Tue, 28 Apr 2026 20:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oZddyefkooDQKnc5O6I7CXwcRuSu4lPrXGIxW3LQfo4=; b=uR3sb3KJUllKZDv5EYWYp/CXBL Lg49PZxiqs7Mz0GAxUlihPCuaX3Ln2y7A6bP1ezZyOVyjo70Xy7YeufKyZHn9I9t7AaI0hzOZCWux OxUM70PdmVPpSwsxHjz51kNaPzFGf3dFPIapDMj1fDy7GXCtpdPRyYX9yNka5ScWuyrYyBkArOVnc Ai7ri4jUlGmpD2Kwu18feUAsw29h3L9izKpixXEMchEA2rM2zXl/kMLd7eaPXJZDCPDU4tKhww5lw J6swyOYuGnlhY8riXO+zDWftpmjnTsFzJouoO/GQKvEwxxvJHhc8BVP2dApPRKZaTS03vxRNSBP9i r6dQjoVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHoiY-00000002Cat-3OHF; Tue, 28 Apr 2026 20:07:38 +0000 Received: from mail-dy1-x132c.google.com ([2607:f8b0:4864:20::132c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHoiS-00000002COc-1Fr9 for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2026 20:07:33 +0000 Received: by mail-dy1-x132c.google.com with SMTP id 5a478bee46e88-2d96243c91fso19351316eec.1 for ; Tue, 28 Apr 2026 13:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777406851; x=1778011651; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oZddyefkooDQKnc5O6I7CXwcRuSu4lPrXGIxW3LQfo4=; b=J205qqWu36zwJB1rAMnVc+2OqHgQ7bE8xm1mrzyExt5f4M1ekIrcmYnH8XK2AQuw/4 UToPBemcfkXgUogBc1liYkQkVSak2q5lfmD5DbgtGpV49S7yIiXsBlFc2PY3GBqjwbg/ nnAMoHRT3M1fCSz5lcbBdP25aO0Czu8XZgDCA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777406851; x=1778011651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oZddyefkooDQKnc5O6I7CXwcRuSu4lPrXGIxW3LQfo4=; b=UpAD6B5ngIMxMBOgOb1DzYBsjaUEKAh3U4LchmHg4WL5dHg+uWOXCmiJSVTnQR9WtT a2L34e/gWeIPn3fnXbgHEK/RARU+YT8fhs2yH5EHjWH3juzAqkz8EwbxYFxaMXa25rKi r+BZ/UoeUlbT9G984/0cKpCFXcYIMvPR1HetS/scBZoxXoM27lOmjduKoUYztLv4kcJS Zd/e41wBoJM96J+iIqpsu9X+PUiDhUMuZmhAAIkIDTeIwnljU3eDLXM/J1vgxNhTgMAN +2eDv0vQhY+AeakdEJXvi99e7y80ys4bgi6cLj+YLHv2ClvOCUmtYD++eNPT15C3gcHn lKhw== X-Forwarded-Encrypted: i=1; AFNElJ8EwrkM659NEOHSBrEWnYi41igOxNVTifxWtSjMc6ZaZnja05OtW1KEznI2/LWalbzDZe6VgJz1K2ffchkiXoSM@lists.infradead.org X-Gm-Message-State: AOJu0YzqOlXN00lkafHiT3zSwo4fkXEx5VCc6S9TBOmSdpzhMpTMiDD/ RV08nmpboISS/fSLwz6v4dHLcTB6elhkdyhzEPpHkR2/phu60GaaG1Ud6BNd8afpXw== X-Gm-Gg: AeBDieuMwezN0M33g1Db1hrANLNVyxYkPooGQpcVkbckkF2hdYLBp/NvIEbkJuldIHr 464so/WV0+Z22vxMcHOgzU4pAgEhqi+s0Q1cslvhPPdhAxvP71FnWm3uB81t68lRrUj4kzaJWQd 5CjcAYilODncheN4LWPmMDs4oYpX/gggijZptyyA8EU4pf9meSC66skplWVYIju9DUM+w1AE2tj PT6WTGiC0UbSLjtVHXKYi8R04Fth/LTM+ea9dtQWy4XDbzPNosFFzRAVfR+B4cKoElPOe7qoZ3j BtCtcZjceFxcE9vhLUQYco36Z11vOAyZeSYD4LX45Ga1CiXrxS64g16Kt4MBFe+JOhas4oi5urd vv7KZJbJBugP44XCGxyAKIQhoiETym3Zj8dV4fAkOmeW8I1mYYO2kEdj9AUR0A6qXIHXZcRVMkn E6MMWB89LvNFAjonqWo2q73J/KHHMMxg4arw2TBavC4iceUUCB1jUbjFpFDtBrpRml4dQrMfFy X-Received: by 2002:a05:7300:fd08:b0:2ed:e17:d50b with SMTP id 5a478bee46e88-2ed0e17d6eemr1499097eec.30.1777406851181; Tue, 28 Apr 2026 13:07:31 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:4ff5:9607:c7e5:48f3]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-2ed0a10650esm2873589eec.22.2026.04.28.13.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 13:07:30 -0700 (PDT) From: Brian Norris To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Heiko Stuebner , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio Cc: devicetree@vger.kernel.org, Doug Anderson , linux-arm-kernel@lists.infradead.org, Tzung-Bi Shih , chrome-platform@lists.linux.dev, Brian Norris , linux-rockchip@lists.infradead.org, Julius Werner , Alim Akhtar , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] arm64: dts: rockchip: Add #{address,size}-cells to Chromium-based /firmware Date: Tue, 28 Apr 2026 13:06:53 -0700 Message-ID: <20260428200712.2660635-2-briannorris@chromium.org> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260428200712.2660635-1-briannorris@chromium.org> References: <20260428200712.2660635-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260428_130732_356837_3E79BD32 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Chromium/Depthcharge bootloaders may dynamically add a few device nodes to a system's DTB under a /firmware node. A typical DT looks something like the following: ## From a RK3399 Gru/Kevin Chromebook: # find /sys/firmware/devicetree/base/firmware /sys/firmware/devicetree/base/firmware /sys/firmware/devicetree/base/firmware/coreboot /sys/firmware/devicetree/base/firmware/coreboot/ram-code /sys/firmware/devicetree/base/firmware/coreboot/compatible /sys/firmware/devicetree/base/firmware/coreboot/board-id /sys/firmware/devicetree/base/firmware/coreboot/reg /sys/firmware/devicetree/base/firmware/coreboot/name /sys/firmware/devicetree/base/firmware/chromeos /sys/firmware/devicetree/base/firmware/chromeos/readonly-firmware-version /sys/firmware/devicetree/base/firmware/chromeos/active-ec-firmware /sys/firmware/devicetree/base/firmware/chromeos/firmware-version /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-storage /sys/firmware/devicetree/base/firmware/chromeos/vboot-shared-data /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-size /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-offset /sys/firmware/devicetree/base/firmware/chromeos/hardware-id /sys/firmware/devicetree/base/firmware/chromeos/compatible /sys/firmware/devicetree/base/firmware/chromeos/firmware-type /sys/firmware/devicetree/base/firmware/chromeos/fmap-offset /sys/firmware/devicetree/base/firmware/chromeos/name /sys/firmware/devicetree/base/firmware/ranges /sys/firmware/devicetree/base/firmware/name The /firmware node has an empty 'ranges', but does not have address/size-cells. Commit 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") started requiring #address-cells for a device's parent if we want to use the reg resource in a device node. This leads to errors like the following: [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22 Add appropriate #{address,size}-cells to work around the problem. Note that Google has also patched the Depthcharge bootloader source to add {address,size}-cells [1], but bootloader updates are typically delivered only via Google OS updates. Not all users install Google software updates, and even if they do, Google may not produce updated binaries for all/older devices. [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/ https://crrev.com/c/6051580 ("coreboot: Insert #address-cells and #size-cells for firmware node") Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/ Fixes: 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") Signed-off-by: Brian Norris --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index 7eca1da78cff..2f9e39671efc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -18,6 +18,11 @@ chosen { stdout-path = "serial2:115200n8"; }; + firmware { + #address-cells = <2>; + #size-cells = <2>; + }; + /* * Power Tree * -- 2.54.0.545.g6539524ca2-goog