Re: [PATCH v3 04/15] firmware: arm_scmi: Simplify clock rates exposed interface

Cristian Marussi
2026-05-05T14:36:19Z

On Tue, May 05, 2026 at 02:17:45PM +0200, Geert Uytterhoeven wrote:
> Hi Cristian, Sudeep,

Hi Geert,

Thanks for having a look.

>
> On Tue, 28 Apr 2026 at 22:16, Cristian Marussi <cristian.marussi@arm.com> wrote:
> > Introduce a new internal struct scmi_clock_desc so as to be able to hide,
> > in the future, some of the needlessly public fields currently kept inside
> > scmi_clock_info, while keeping exposed only the two new min_rate and
> > max_rate fields for each clock.
> >
> > No functional change.
> >
> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>
> Thanks for your patch, which is now commit 83fd9d34b6b75be5 ("firmware:
> arm_scmi: Simplify clock rates exposed interface") in scmi/for-linux-next.
>
> > --- a/drivers/firmware/arm_scmi/clock.c
> > +++ b/drivers/firmware/arm_scmi/clock.c
>
> > @@ -457,14 +466,14 @@ iter_clk_describe_update_state(struct scmi_iterator_state *st,
> > flags = le32_to_cpu(r->num_rates_flags);
> > st->num_remaining = NUM_REMAINING(flags);
> > st->num_returned = NUM_RETURNED(flags);
> > - p->clk->rate_discrete = RATE_DISCRETE(flags);
>
> This removes the last setter of scmi_clock_info.rate_discrete.
> However, it is still used until the next commit cd73d1bfaa8d34bb
> ("clk: scmi: Use new simplified per-clock rate properties").
> V2 did now have this issue, as the patches were ordered differently
> in that series.
>
> After both commits, there are no more users of
> scmi_clock_info.rate_discrete, so it can be removed.

Indeed.... good catch, rate_discerte has been moved to scmi_clock_rates
so the old public scmi_clock_info.rate_discrete is stale and no more
updated...I will remove it.

Thanks,
Cristian