public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: florin.leotescu@oss.nxp.com
To: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Shych <michaelsh@nvidia.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: daniel.baluta@nxp.com, viorel.suman@nxp.com,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	festevam@gmail.com, Florin Leotescu <florin.leotescu@nxp.com>
Subject: [PATCH v7 0/3] Support configurable fan PWM at shutdown
Date: Wed, 29 Apr 2026 09:59:52 +0300	[thread overview]
Message-ID: <20260429065955.2113012-1-florin.leotescu@oss.nxp.com> (raw)

From: Florin Leotescu <florin.leotescu@nxp.com>

Hi,

This series adds support for configuring the fan shutdown PWM value
via Device Tree and improves the robustness of the emc2305 driver.

Some platforms require fans to transition to a predefined safe state
during shutdown or reboot handoff until firmware or the next boot stage
reconfigures the controller.

The new optional Device Tree property "fan-shutdown-percent" allows the
shutdown PWM duty cycle to be configured per fan output.

Thanks for the review and apologies for the delay.

Changes in v7:
- Use the DT "reg" property when registering thermal cooling devices
  instead of a sequential child index
- Validate the "reg" value against the number of available PWM channels
  in both DT parsing and probe paths
- Address feedback from Guenter Roeck regarding channel index handling

Changes in v6:
- Split fan channel index validation into a separate patch.
  Validate fan channel index agains the number of available channels.
- Refine dt-binding commit message to refer to PWM duty cycle
  instead of fan speed.
Changes in v5:
- Add fan channel index bound check after reg property read 
  to prevent out-of-bounds access.
- Refine fan-shutdown-percent description.
Changes in v4:
- Initialize pwm_shudown array to EMC2305_PWM_SHUTDOWN_UNSET in probe,
  to avoid treating unconfigured channels as valid and written 0
  during shutdown
Changes in v3:
- Rebased on current upstream
- Dropped already upstreamed of_node_put(child) fix
Changes in v2:
- Address feedback from Guenter Roeck
- Make shutdown behavior configurable via Device Tree
- Add optional fan-shutdown-percent property
- Apply shutdown PWM only for channels defining the property

Florin Leotescu (3):
  hwmon: emc2305: Fix fan channel index handling
  dt-bindings: hwmon: emc2305: Add fan-shutdown-percent property
  hwmon: emc2305: Support configurable fan PWM at shutdown

 .../bindings/hwmon/microchip,emc2305.yaml     |  8 +++
 drivers/hwmon/emc2305.c                       | 54 +++++++++++++++++--
 2 files changed, 59 insertions(+), 3 deletions(-)

-- 
2.34.1



             reply	other threads:[~2026-04-29  6:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  6:59 florin.leotescu [this message]
2026-04-29  6:59 ` [PATCH v7 1/3] hwmon: emc2305: Fix fan channel index handling florin.leotescu
2026-04-30 23:13   ` Guenter Roeck
2026-04-29  6:59 ` [PATCH v7 2/3] dt-bindings: hwmon: emc2305: Add fan-shutdown-percent property florin.leotescu
2026-04-29 18:18   ` Conor Dooley
2026-04-30 12:02     ` Florin Leotescu
2026-04-30 18:53       ` Conor Dooley
2026-04-30 23:14   ` Guenter Roeck
2026-04-29  6:59 ` [PATCH v7 3/3] hwmon: emc2305: Support configurable fan PWM at shutdown florin.leotescu
2026-04-30 23:17   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429065955.2113012-1-florin.leotescu@oss.nxp.com \
    --to=florin.leotescu@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=florin.leotescu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=michaelsh@nvidia.com \
    --cc=robh@kernel.org \
    --cc=viorel.suman@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox