From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90725CD3424 for ; Fri, 1 May 2026 09:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o3ovUkWgYWEpqqlsycCJZaa2Pww05sUjyxsTGBfrzAA=; b=bonJtJBPjYNqeLF1mqYgf0GzI8 cvlh8i5r/eGIU12mUdQHAjikfM5WkHRP2DvMBHxn51dzjNN5LZdT7DyT6CLyD4tU7r9P7s1oExbT0 kMvp0kThIxV++ObA7PGVePew05gDNYEIKm31XDzlcmnu2nPx0sHNxF8hq3hldwOWkH+I45Dzv3BZu jnJzUDNOotJoQXZ2Ln1zspX8N3kOoQ2B0AqKATwzjpFORdPki3VdOLcZrcwstYmV81SAV+89LLKHh pypTzHJRWnJohgUP/De825iFBQDuyEtnNDizKM8Fxfwe3CiF36qbA0IW8BQDVhJVaXVjOrNFC8K23 AOfPiLmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wIkcq-00000006ZHL-3fLa; Fri, 01 May 2026 09:57:36 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wIkco-00000006ZGW-2bJJ for linux-arm-kernel@lists.infradead.org; Fri, 01 May 2026 09:57:35 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-82f8892d4d6so829923b3a.0 for ; Fri, 01 May 2026 02:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777629454; x=1778234254; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o3ovUkWgYWEpqqlsycCJZaa2Pww05sUjyxsTGBfrzAA=; b=GoR5mYHvhs8EIMT4sb6UmGabm0l91VLzFHTtpkeZKrYKYn4EEr5YwM+5F9ouLXaCVB oiixQZcP0qRYj+o39Pvb+DQU6jLHQ7e4ckO+if4SCJk5JtFe5A0g55M1nDC8dgLyfPPk fLNQEZHNVGUPtx9RSWw/ZNufpokyiDdAa4HnlfzfUPuUv9FfhayNvhAxQjEgzbQQpRVM UAG+rqr3SpRrmwPGaUusE4XlKclxhzsGlb64IGyOghzZdWaBAo8uPslWqcpgHWJ2FM72 mRHs8T8V+IOT9RAuvHbcUxV7NNvO0WSiwSoUBLFcmljvtSPTVgNIlLlyY94bMCRIefQS wQxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777629454; x=1778234254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o3ovUkWgYWEpqqlsycCJZaa2Pww05sUjyxsTGBfrzAA=; b=S2zj+5VHEThbLQRmGCcgEvDqaIyhmXfhC/5TbnwWL0MJ+NNEfLLstKBC/FZY/GX70f bhOI+PxyS8khaVZX4eLRrZmkgziAMvDxv3WPRmciOBSEnN8vovLgV80kejlYpujkp/Nr w/PwyhytM9MEt9f5j3bcqDrsCIJQ0FoGcyEjvc1QQ4yX0eBWGBlIuRWS73hkfx3Pf9IN PP1Klu57NvYuet5JayEsL/kKUPkAgk9Ob5KCTE8X3grIpLtFg9EXc2wSPCBTK6eUkNGn RtWnoO4k4RW8qx3ISW72TJCs+nkzszfUFqSSowoKQSe3TobAnmfNr5dDUTdQiJFXDYva E1NQ== X-Forwarded-Encrypted: i=1; AFNElJ9gxV6uylqzJF3oWeDUJSqN7T28qJqYCsmHcbGWiOGEpX0U2IYp+Vlj3T8qaN8iTZDXHHrG4jgRXxcsNxDM1SFD@lists.infradead.org X-Gm-Message-State: AOJu0YzPWq1uwxUZmDkVLea2rmtYCAULHIXDyRtr0rOEXDT3p+oc2204 BGsTWoH2BvaJReWp/YlZeaMofTVtEiTGWKL0uo8td0/IGzso7HSZZ3RN X-Gm-Gg: AeBDievGsh1cniGWSM5ub9v4x25ZTbKZBsiMch+ga1OZcKxwIlczPKaxI6yiN1S2pQ7 0UG/F3II9mMgHDq18/6K/VaJ2gjT7oPDLTlehrQ9lysx2iaf/jcaxWWJOXSiQCfAbwRYjdPLuNt UYPn390a9s1QvhVTLaD0EBgRuvyrXhLMqHXxmuqtuLbiDXyIC4G41TgFC70GxZB4p2vAKlk8lZH t3mBAdQXvjzaV+jaKnWHMhDrWTatAFUUeRsM4fawVlhEHhjyUD8+4QAZzeJGsRdhFS5Zj7WLxJI cs9jNrxMvxZgeMIfklqDlUvDcBCP9YG9vjVklR8uuG0m1mKMdmu1FuHW3dWrA4LW1HGR//Rz7qH vb+hA923MHyKt/XuXuUFKB9tREVt8RQLu4jQOpNUvyI7dvM0QbrhTl7HqRQKZ3W92rDPYicn9uD /b9cjcR5l9EEt8yA== X-Received: by 2002:a05:6a21:6d88:b0:39b:da83:91aa with SMTP id adf61e73a8af0-3a3cf8cbdc5mr7983611637.51.1777629453564; Fri, 01 May 2026 02:57:33 -0700 (PDT) Received: from nuvole ([2409:8a34:5f36:7c14::f7f]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbcac2cfsm1731381a12.32.2026.05.01.02.57.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:57:33 -0700 (PDT) From: Pengyu Luo To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sakari Ailus , Martin Kepplinger-Novakovic , Mauro Carvalho Chehab , Hans Verkuil Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Pengyu Luo Subject: [PATCH v2 2/4] media: hi846: fix link frequency handling Date: Fri, 1 May 2026 17:54:31 +0800 Message-ID: <20260501095433.1609309-3-mitltlatltl@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260501095433.1609309-1-mitltlatltl@gmail.com> References: <20260501095433.1609309-1-mitltlatltl@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260501_025734_669290_7DC51858 X-CRM114-Status: GOOD ( 23.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org link frequency is tied to PLL configuration, lane count, and external clock rate, so use runtime here instead of hardcoding for specific configuration. To implement this, this commit did 1. dropped exposed link freqs as a v4l2_ctrl, since we are runtime now, it is inconvenient and unnecessary to expose it, and hi846_set_ctrl has nothing to do with it. 2. attached pll_cfg_2lane to current mode, and use it with clock, lane count to calculate link frequency, we use 2-lane config as default, but we can halve it easily for 4-lane case. 3. dropped mclk clock rate check. Fixes: e8c0882685f9 ("media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera") Suggested-by: Sakari Ailus Signed-off-by: Pengyu Luo --- drivers/media/i2c/hi846.c | 72 +++++++++++++++++++-------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index 7f069aca0fce..3a0b1e124d9d 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -219,8 +219,8 @@ struct hi846_mode { /* Horizontal timing size */ u32 llp; - /* Link frequency needed for this resolution */ - u8 link_freq_index; + /* PLL configuration for 4-lane link at this resolution */ + u16 pll_cfg_4lane; u16 fps; @@ -1040,13 +1040,6 @@ static const char * const hi846_test_pattern_menu[] = { "Resolution Pattern", }; -#define FREQ_INDEX_640 0 -#define FREQ_INDEX_1280 1 -static const s64 hi846_link_freqs[] = { - [FREQ_INDEX_640] = 80000000, - [FREQ_INDEX_1280] = 200000000, -}; - static const struct hi846_reg_list hi846_init_regs_list_2lane = { .num_of_regs = ARRAY_SIZE(hi846_init_2lane), .regs = hi846_init_2lane, @@ -1061,7 +1054,7 @@ static const struct hi846_mode supported_modes[] = { { .width = 640, .height = 480, - .link_freq_index = FREQ_INDEX_640, + .pll_cfg_4lane = 0x4924, /* HI846_REG_PLL_CFG_MIPI2_H */ .fps = 120, .frame_len = 631, .llp = HI846_LINE_LENGTH, @@ -1086,7 +1079,7 @@ static const struct hi846_mode supported_modes[] = { { .width = 1280, .height = 720, - .link_freq_index = FREQ_INDEX_1280, + .pll_cfg_4lane = 0x4924, /* HI846_REG_PLL_CFG_MIPI2_H */ .fps = 90, .frame_len = 842, .llp = HI846_LINE_LENGTH, @@ -1112,7 +1105,7 @@ static const struct hi846_mode supported_modes[] = { { .width = 1632, .height = 1224, - .link_freq_index = FREQ_INDEX_1280, + .pll_cfg_4lane = 0x4924, /* HI846_REG_PLL_CFG_MIPI2_H */ .fps = 30, .frame_len = 2526, .llp = HI846_LINE_LENGTH, @@ -1161,7 +1154,6 @@ struct hi846 { struct v4l2_ctrl_handler ctrl_handler; u8 nr_lanes; - struct v4l2_ctrl *link_freq; struct v4l2_ctrl *pixel_rate; struct v4l2_ctrl *vblank; struct v4l2_ctrl *hblank; @@ -1192,21 +1184,37 @@ static const struct hi846_datafmt *hi846_find_datafmt(u32 code) return NULL; } -static inline u8 hi846_get_link_freq_index(struct hi846 *hi846) +static u64 +hi846_get_link_freq(struct hi846 *hi846, const struct hi846_mode *cur_mode) { - return hi846->cur_mode->link_freq_index; -} + u16 cfg = cur_mode->pll_cfg_4lane; + u64 mclk = clk_get_rate(hi846->clock); -static u64 hi846_get_link_freq(struct hi846 *hi846) -{ - u8 index = hi846_get_link_freq_index(hi846); + /* NOTE: 6, 7 actually map to 8, 10, but the used won't be that big */ + u8 post_div1 = 1 + FIELD_GET(GENMASK(10, 8), cfg); + u8 post_div2 = 1 << FIELD_GET(GENMASK(12, 11), cfg); + + /* + * HI846_REG_PLL_CFG_MIPI1_H = 0x025a, it is fixed in listed modes + * [11:8]: 0x02 => pre_div = 3 + * [7:0]: 0x5a => multiplier = 90 + */ + u64 link_freq = mclk / 3 * 90 / post_div1 / post_div2; + /* + * for shared modes, since lane count is halved for 2-lane, then getting + * link_freq doubled to match the same data rate. Since 720x480 is + * 2-lane only(i.e. reg_list_4lane.num_of_regs == 0), no pll cfg for + * 4-lane, the pll cfg is actually for 2-lane, so use the cfg as is. + */ + if (hi846->nr_lanes == 2 && cur_mode->reg_list_4lane.num_of_regs) + link_freq *= 2; - return hi846_link_freqs[index]; + return link_freq; } static u64 hi846_calc_pixel_rate(struct hi846 *hi846) { - u64 link_freq = hi846_get_link_freq(hi846); + u64 link_freq = hi846_get_link_freq(hi846, hi846->cur_mode); u64 pixel_rate = link_freq * 2 * hi846->nr_lanes; do_div(pixel_rate, HI846_RGB_DEPTH); @@ -1426,14 +1434,6 @@ static int hi846_init_controls(struct hi846 *hi846) ctrl_hdlr->lock = &hi846->mutex; - hi846->link_freq = - v4l2_ctrl_new_int_menu(ctrl_hdlr, &hi846_ctrl_ops, - V4L2_CID_LINK_FREQ, - ARRAY_SIZE(hi846_link_freqs) - 1, - 0, hi846_link_freqs); - if (hi846->link_freq) - hi846->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; - hi846->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &hi846_ctrl_ops, V4L2_CID_PIXEL_RATE, 0, @@ -1503,10 +1503,10 @@ static int hi846_set_video_mode(struct hi846 *hi846, int fps) u64 frame_length; int ret = 0; int dummy_lines; - u64 link_freq = hi846_get_link_freq(hi846); + u64 link_freq = hi846_get_link_freq(hi846, hi846->cur_mode); dev_dbg(&client->dev, "%s: link freq: %llu\n", __func__, - hi846_get_link_freq(hi846)); + link_freq); do_div(link_freq, fps); frame_length = link_freq; @@ -1749,7 +1749,6 @@ static int hi846_set_format(struct v4l2_subdev *sd, mf->code = HI846_MEDIA_BUS_FORMAT; mf->field = V4L2_FIELD_NONE; - __v4l2_ctrl_s_ctrl(hi846->link_freq, hi846_get_link_freq_index(hi846)); __v4l2_ctrl_s_ctrl_int64(hi846->pixel_rate, hi846_calc_pixel_rate(hi846)); @@ -1950,16 +1949,17 @@ static int hi846_identify_module(struct hi846 *hi846) static s64 hi846_check_link_freqs(struct hi846 *hi846, struct v4l2_fwnode_endpoint *ep) { - const s64 *freqs = hi846_link_freqs; - int freqs_count = ARRAY_SIZE(hi846_link_freqs); + int freqs_count = ARRAY_SIZE(supported_modes); + u64 link_freq; int i, j; for (i = 0; i < freqs_count; i++) { + link_freq = hi846_get_link_freq(hi846, &supported_modes[i]); for (j = 0; j < ep->nr_of_link_frequencies; j++) - if (freqs[i] == ep->link_frequencies[j]) + if (link_freq == ep->link_frequencies[j]) break; if (j == ep->nr_of_link_frequencies) - return freqs[i]; + return link_freq; } return 0; -- 2.54.0