From: John Madieu <john.madieu@gmail.com>
To: broonie@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, carlos.song@nxp.com,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, John Madieu <john.madieu@gmail.com>
Subject: [PATCH 0/3] spi: imx: Three fixes for the i.MX SPI driver
Date: Fri, 1 May 2026 13:59:48 +0000 [thread overview]
Message-ID: <20260501135951.2416527-1-john.madieu@gmail.com> (raw)
Hi All,
This series independent fixes found in the i.MX SPI driver.
These are:
1/3 fixes a precedence bug in spi_imx_dma_max_wml_find() that makes
the watermark-finding logic effectively dead code. The function
currently always returns wml = 1 because of how the !-operator
binds to the modulo expression.
2/3 fixes a missing return on the package-1 failure path in
spi_imx_dma_data_prepare(). The error path frees the
dma_data array and the package-0 buffers, then falls through
to "return 0" - the caller proceeds with a freed pointer.
3/3 makes spi_imx_setupxfer() propagate the prepare_transfer()
return value. Currently a -EINVAL from mx51_ecspi_prepare_transfer
(e.g. on a word_delay overflow) is silently swallowed and the
transfer proceeds with a partially-configured controller.
Regards,
John Madieu (3):
spi: imx: Fix precedence bug in spi_imx_dma_max_wml_find()
spi: imx: Fix UAF on package-1 prepare failure in
spi_imx_dma_data_prepare()
spi: imx: Propagate prepare_transfer() error from spi_imx_setupxfer()
drivers/spi/spi-imx.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.25.1
next reply other threads:[~2026-05-01 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 13:59 John Madieu [this message]
2026-05-01 13:59 ` [PATCH 1/3] spi: imx: Fix precedence bug in spi_imx_dma_max_wml_find() John Madieu
2026-05-02 4:46 ` Frank Li
2026-05-01 13:59 ` [PATCH 2/3] spi: imx: Fix UAF on package-1 prepare failure in spi_imx_dma_data_prepare() John Madieu
2026-05-02 4:49 ` Frank Li
2026-05-01 13:59 ` [PATCH 3/3] spi: imx: Propagate prepare_transfer() error from spi_imx_setupxfer() John Madieu
2026-05-02 4:51 ` Frank Li
2026-05-04 13:22 ` [PATCH 0/3] spi: imx: Three fixes for the i.MX SPI driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501135951.2416527-1-john.madieu@gmail.com \
--to=john.madieu@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=carlos.song@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox