From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43538FF885A for ; Mon, 4 May 2026 16:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cTwBZuBkLaEoXEXlx8lRKjsB6RK7v7MFH7fzcG9R9DI=; b=MvKa1q0UKmw5HxybVpXQ9kqHe+ 2rtqqLKgL1qxgGtxgKiHVBqHwZ0HcnMPedCHlxGu3ijj/woqmxJU4vI3kU04dboU/rPLstVaa9nnb X0A3+lKezIsxKN26fxPfuc5jNeP/46cJYLvBWHTpJjPo+S4Z59x+OW7G8S3sPR88EeaB/6/IHFGNw E+RDhdoVQgG1XiDjHaZ3crIvMOy7AftBpdQX8fSQBL0Qci8XfEc1UPYRLPqF5Nd2d92t52/Tp2yRr tpR9yKP3+IgiDwIBs3DihnYuhDWtjqlGRY3Mn7AmyIA5rs80W/+YKzbmA0EJmRQ/ng1AiwbjqFPhv yuakhPJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wJwFs-0000000DjG9-1D2w; Mon, 04 May 2026 16:34:48 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wJwFo-0000000DjF6-364R for linux-arm-kernel@lists.infradead.org; Mon, 04 May 2026 16:34:46 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A5EF9C; Mon, 4 May 2026 18:34:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1777912481; bh=2OSAeT8an5e3Y+nfCRfDAXE6cwKmFiIVVKAcvn/IUNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vxISDUCuo6b67rdu9OyWQc4v82FFMWzd49PyIU+P5FA58n/pOr24USVXMSVJzhYd2 9LLY/MSJUZJRAKvQ69brP3BXwQwmcOYkm+rI9oCeir5Z2a+F7hIimQPN7mSOZBxz6H TnMUIUFuDNrQ9kdWmO/7opamqlJOvglSdCiRFVTA= Date: Mon, 4 May 2026 19:34:41 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 04/20] drm/atomic: Expand atomic_create_state expectations for drm_private_obj Message-ID: <20260504163441.GI1344263@killaraus.ideasonboard.com> References: <20260424-drm-mode-config-init-v3-0-8b68d9db0d8b@kernel.org> <20260424-drm-mode-config-init-v3-4-8b68d9db0d8b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260424-drm-mode-config-init-v3-4-8b68d9db0d8b@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260504_093444_917358_D9359C20 X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, Thank you for the patch. On Fri, Apr 24, 2026 at 12:18:44PM +0200, Maxime Ripard wrote: > The atomic_create_state callback documentation for planes, CRTCs, and > connectors explicitly states the expected behaviour: the returned > state must not be assigned to the object's state pointer, and hardware > must not be touched. > > The drm_private_state_funcs.atomic_create_state documentation is > missing this clarification. Add it for consistency. > > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > include/drm/drm_atomic.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index f03cd199aee7..f7f9c6c85f3a 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -263,11 +263,14 @@ struct drm_private_state; > struct drm_private_state_funcs { > /** > * @atomic_create_state: > * > * Allocates a pristine, initialized, state for the private > - * object and returns it. > + * object and returns it. This callback must have no side > + * effects: in particular, the returned state must not be > + * assigned to the object's state pointer and it must not affect > + * the hardware state. > * > * RETURNS: > * > * A new, pristine, private state instance or an error pointer > * on failure. -- Regards, Laurent Pinchart