From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rt-devel@lists.linux.dev>
Subject: Re: [PATCH net 2/4] net: sparx5: fix sleep in atomic context in MAC table access
Date: Mon, 4 May 2026 16:52:58 -0700 [thread overview]
Message-ID: <20260504165258.30b81158@kernel.org> (raw)
In-Reply-To: <20260504-misc-fixes-sparx5-lan969x-v1-2-6604306b5743@microchip.com>
On Mon, 4 May 2026 16:43:43 +0200 Daniel Machon wrote:
> sparx5_mact_learn() is called from .ndo_set_rx_mode with
> netif_addr_lock_bh held, but takes sparx5->lock which is a mutex.
> A mutex may block, which is not allowed from atomic context.
Could you try to switch to the recently added ndo_set_rx_mode_async?
We added it exactly because most drivers have to sleep / wait for FW
to do something.
next prev parent reply other threads:[~2026-05-04 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 14:43 [PATCH net 0/4] net: sparx5: misc fixes for sparx5 and lan969x Daniel Machon
2026-05-04 14:43 ` [PATCH net 1/4] net: sparx5: defer VCAP debugfs creation until after netdev registration Daniel Machon
2026-05-04 14:43 ` [PATCH net 2/4] net: sparx5: fix sleep in atomic context in MAC table access Daniel Machon
2026-05-04 16:06 ` Sebastian Andrzej Siewior
2026-05-04 23:52 ` Jakub Kicinski [this message]
2026-05-04 14:43 ` [PATCH net 3/4] net: sparx5: fix wrong chip ids for TSN SKUs Daniel Machon
2026-05-04 14:43 ` [PATCH net 4/4] net: sparx5: configure serdes for 1000BASE-X in sparx5_port_init() Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504165258.30b81158@kernel.org \
--to=kuba@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=bjarni.jonasson@microchip.com \
--cc=clrkwllms@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox