From: Leo Yan <leo.yan@arm.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
mike.leach@arm.com, james.clark@linaro.org,
alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com
Subject: Re: [PATCH v6 02/13] coresight: etm4x: fix underflow for nrseqstate
Date: Tue, 5 May 2026 17:19:05 +0100 [thread overview]
Message-ID: <20260505161905.GA3778514@e132581.arm.com> (raw)
In-Reply-To: <20260422132203.977549-3-yeoreum.yun@arm.com>
On Wed, Apr 22, 2026 at 02:21:52PM +0100, Yeoreum Yun wrote:
> TCRSEQEVR<n> is implemented only when TCRIDR5.NUMSEQSTATE is 0b100,
> in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000.
>
> Therefore, drvdata->nrseqstate should be checked before entering the loop.
Since TRCSEQEVRn (n=0~2), to avoid confusion, we also need to rename
ETM_MAX_SEQ_STATES to ETM_MAX_SEQ_TRANSITIONS and define it as 3:
#define ETM_MAX_SEQ_TRANSITIONS 3
Then we don't allocate 4 items but use only 3 of them.
Thanks,
Leo
next prev parent reply other threads:[~2026-05-05 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 13:21 [PATCH v6 00/13] fix several inconsistencies with sysfs configuration in etmX Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 01/13] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 02/13] coresight: etm4x: fix underflow for nrseqstate Yeoreum Yun
2026-05-05 16:19 ` Leo Yan [this message]
2026-04-22 13:21 ` [PATCH v6 03/13] coresight: etm4x: introduce struct etm4_caps Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 04/13] coresight: etm4x: exclude ss_status from drvdata->config Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 05/13] coresight: etm4x: remove redundant fields in etmv4_save_state Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 06/13] coresight: etm4x: fix leaked trace id Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 07/13] coresight: etm4x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 08/13] coresight: etm4x: remove redundant call etm4_enable_hw() with hotplug Yeoreum Yun
2026-04-22 13:21 ` [PATCH v6 09/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable Yeoreum Yun
2026-04-22 13:22 ` [PATCH v6 10/13] coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t Yeoreum Yun
2026-04-22 13:22 ` [PATCH v6 11/13] coresight: etm3x: introduce struct etm_caps Yeoreum Yun
2026-04-22 13:22 ` [PATCH v6 12/13] coresight: etm3x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-04-22 13:22 ` [PATCH v6 13/13] coresight: etm3x: remove redundant call etm_enable_hw() with hotplug Yeoreum Yun
2026-05-01 12:55 ` [PATCH v6 00/13] fix several inconsistencies with sysfs configuration in etmX Yeoreum Yun
2026-05-01 13:53 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505161905.GA3778514@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox