From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
David Airlie <airlied@gmail.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>, Simona Vetter <simona@ffwll.ch>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: display: renesas,du: Document Renesas R-Car R8A779MD M3Le
Date: Wed, 6 May 2026 01:21:58 +0300 [thread overview]
Message-ID: <20260505222158.GJ1547435@killaraus.ideasonboard.com> (raw)
In-Reply-To: <71b24195-2a3c-46a4-8587-f5055a015eb8@mailbox.org>
On Sat, May 02, 2026 at 11:17:22PM +0200, Marek Vasut wrote:
> On 4/29/26 11:57 AM, Geert Uytterhoeven wrote:
> > On Sun, 19 Apr 2026 at 21:37, Marek Vasut wrote:
> >> Extend the Renesas DU display bindings to support the Renesas R-Car
> >> R8A779MD M3Le SoC. This SoC is similar to R-Car R8A77965 M3-N SoC,
> >> except the HDMI port@1 is not present.
> >
> > "and DU1 is unused." (whatever that may mean...)
>
> Fixed in V2.
>
> >> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> >> @@ -42,6 +42,7 @@ properties:
> >> - renesas,du-r8a779a0 # for R-Car V3U compatible DU
> >> - renesas,du-r8a779g0 # for R-Car V4H compatible DU
> >> - renesas,du-r8a779h0 # for R-Car V4M compatible DU
> >> + - renesas,du-r8a779md # for R-Car M3Le compatible DU
> >
> > I am not sure you need a new compatible value: is the DU really
> > different than on R-Car M3-N, or does it just lack some wiring? ...
>
> It seems the DU is identical to the M3N one, so I will add another entry
> to R8A77965 DU to handle the M3Le one, just like R8A774B1 and R8A774E1
> DUs . I hope that is acceptable, and also addresses the feedback on this
> patch ?
>
> I dumped the VSP and FCP versions on M3N and M3Le and compared them, and
> I also wrote and read-back the CMM registers to confirm CMM IPs are all
> present on both M3N and M3Le:
>
> FCP is identical on M3N and M3Le:
> fe950000.fcp FCP_VCR=0x106
> fe96f000.fcp FCP_VCR=0x106
> fe9af000.fcp FCP_VCR=0x106
> fea27000.fcp FCP_VCR=0x106
> fea2f000.fcp FCP_VCR=0x106
>
> VSP is identical on M3N and M3Le:
> fe960000.vsp IP_VERSION=0x01011504
> fe9a0000.vsp IP_VERSION=0x01011404
> fea20000.vsp IP_VERSION=0x01011904
> fea28000.vsp IP_VERSION=0x01011704
>
> CMMs are present on M3N and M3Le, tested with write of bits 28 and 24
> into CM2_CLU_CTRL and then readback:
> fea40000.cmm CM2_CLU_CTRL readback 0x11000000
> fea50000.cmm CM2_CLU_CTRL readback 0x11000000
> fea70000.cmm CM2_CLU_CTRL readback 0x11000000
>
> And it does indeed look like we do have DOTCLKIN1 .
So the die seems to be the same as M3N, just with some signals not wired
up. We could simply drop the HDMI output port in DT as Geert proposed.
I'm however a bit concerned we would later find differences that require
a specific compatible string.
At this point, I think more testing is needed, with local access to the
board, to check the display output. As that's hard to do right now,
let's start by upstreaming board support without the DU, and add the DU
on top.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-05-05 22:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 19:35 [PATCH 0/7] arm64: dts: renesas: r8a779md: Add support for R-Car M3Le R8A779MD SoC and Geist board Marek Vasut
2026-04-19 19:35 ` [PATCH 1/7] dt-bindings: display: renesas,du: Document Renesas R-Car R8A779MD M3Le Marek Vasut
2026-04-20 16:17 ` Conor Dooley
2026-04-29 9:57 ` Geert Uytterhoeven
2026-05-02 21:17 ` Marek Vasut
2026-05-05 22:21 ` Laurent Pinchart [this message]
2026-05-05 22:30 ` Laurent Pinchart
2026-04-19 19:35 ` [PATCH 2/7] drm/rcar-du: Add support for " Marek Vasut
2026-04-29 10:10 ` Geert Uytterhoeven
2026-05-02 21:25 ` Marek Vasut
2026-04-19 19:35 ` [PATCH 3/7] dt-bindings: clock: cs2000-cp: document CS2500 Marek Vasut
2026-04-20 16:13 ` Conor Dooley
2026-04-20 18:38 ` Stephen Boyd
2026-04-29 11:32 ` Geert Uytterhoeven
2026-05-02 19:23 ` Marek Vasut
2026-04-19 19:35 ` [PATCH 4/7] dt-bindings: soc: renesas: Document Renesas R-Car R8A779MD Geist Marek Vasut
2026-04-20 16:14 ` Conor Dooley
2026-04-29 11:44 ` Geert Uytterhoeven
2026-04-19 19:35 ` [PATCH 5/7] soc: renesas: Identify Renesas R-Car R8A779MD M3Le SoC Marek Vasut
2026-04-29 11:46 ` Geert Uytterhoeven
2026-04-19 19:35 ` [PATCH 6/7] arm64: dts: renesas: r8a779md: Add Renesas R-Car R8A779MD M3Le DTs Marek Vasut
2026-04-29 12:16 ` Geert Uytterhoeven
2026-05-03 0:11 ` Marek Vasut
2026-04-29 22:11 ` Laurent Pinchart
2026-05-02 23:39 ` Marek Vasut
2026-05-05 22:03 ` Laurent Pinchart
2026-04-19 19:35 ` [PATCH 7/7] arm64: dts: renesas: r8a779md: Add support for R-Car M3Le R8A779MD Geist Marek Vasut
2026-04-29 13:59 ` Geert Uytterhoeven
2026-05-03 1:25 ` Marek Vasut
2026-05-04 9:24 ` Geert Uytterhoeven
2026-05-04 22:53 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505222158.GJ1547435@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut@mailbox.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox