From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7464CD342C for ; Wed, 6 May 2026 07:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tq5ILWWoSETLS5KlYSXgYTSUtMBh8DKjfxEb5zqRDyA=; b=kZB4bMPd0BOIhoAKZVySB66osz BHuOTrsG0V11KZKC9uqh0xm3IYtUYn8W3KEpZLK7u5Jp1XCqMHbVXIjlaNEWL/+zONT+hXMzh2feg DnJ6up381Pmc7Eadd0Xrb5DZGXx5IX5U5gYbjjV8k4QVpF6trHRdaqJZcn6xX3pcfZiAquJR3To1z 6t2ThcuoRmfKvmOMHA9neqnraTB6F4di6Hpp13dHzVhMIny6GA6ziu0DtPL7LLdmAtrc6eGXAQA4S e6YAyS7lkaud5N8fY78cySWwd/BR1++4agiQKPCKhiQWF4rCmJLs8zcLUZTb42WlB+bvJLfQTBcm6 rvGR2pow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKWyC-000000004Im-1Fey; Wed, 06 May 2026 07:47:00 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKWy9-000000004I0-35tk for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2026 07:46:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2828543EB5; Wed, 6 May 2026 07:46:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465FDC2BCB8; Wed, 6 May 2026 07:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778053617; bh=yciUWHPmc3SUKaOblSTZmb2mlEapvuIVhX1wWVo+EO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=edw4bWt4BuwT+8VMvdlmmyNkbUfSuCnsn8I47wLVdUe1baqGDMNKtRis/DG6QmF5f uYhcpglQ41NZxUHEoruPxwpCudfhiaExP1H2pS3UhXfd129DiorMM7iW1yyy5QWvrn zJk5CeqZW3FmGUbEyXPcfrESMCnZM1xxu6GuuyzDj9JfqgJdAHbt4NtBV01JSWJeCt sDT5xuaKjgnWxxenMCknvs4XQOfLmM48yj+QYtEJIoYYnPWXVUDPnu0BsRMuOnmXCO xXqTcnDdmkD1PQcrRzKL6g+xA7ZEl0sttFZXG3FHSG1GWlLYAywij/X+la56Bh+AHT w4oE022oeYj8w== Date: Wed, 6 May 2026 08:46:51 +0100 From: Sudeep Holla To: Yeoreum Yun Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Sudeep Holla , jarkko@kernel.org, zohar@linux.ibm.com, roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org Subject: Re: [RFC PATCH 2/3] firmware: arm_ffa: initialise ff-a after finalising pKVM initialisation Message-ID: <20260506-smooth-warthog-of-enthusiasm-e4a9bc@sudeepholla> References: <20260505095409.1948371-1-yeoreum.yun@arm.com> <20260505095409.1948371-3-yeoreum.yun@arm.com> <20260505-super-gecko-of-argument-655030@sudeepholla> <20260505-adaptable-mussel-of-virtuosity-2751db@sudeepholla> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505-adaptable-mussel-of-virtuosity-2751db@sudeepholla> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_004657_825729_BF2EB915 X-CRM114-Status: GOOD ( 29.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 05, 2026 at 05:32:15PM +0100, Sudeep Holla wrote: > On Tue, May 05, 2026 at 04:06:51PM +0100, Yeoreum Yun wrote: > > Hi Sudeep, > > > > > On Tue, May 05, 2026 at 10:54:08AM +0100, Yeoreum Yun wrote: > > > > When pKVM is enabled, the FF-A driver must be initialised after pKVM. > > > > Otherwise, pKVM cannot negotiate the FF-A version or obtain the RX/TX > > > > buffer information, leading to failures in FF-A calls. > > > > > > > > Currently, pKVM initialisation completes at device_initcall_sync, > > > > while ffa_init() runs at the device_initcall level. > > > > > > > > So far, linker deployes kvm_arm_init() before ffa_init(), and SMCs can > > > > still be trapped even before finalise_pkvm() is invoked. > > > > As a result, this issue has not been observed. > > > > > > > > However, relying on above stuff is fragile. > > > > Therefore, when pKVM is enabled, the FF-A infrastructure should be > > > > initialised only after pKVM initialisation has been fully finalised. > > > > > > > > To achieve this, introduce an ffa_root_dev ("arm-ffa") and > > > > a corresponding driver to defer initialisation of the FF-A infrastructure > > > > until pKVM initialisation is complete, and to defer probing of all FF-A devices until then > > > > when pKVM is enabled. > > > > > > > > > > I don't like this whole ffa root device design. > > > Two question for now: > > > 1. Can FF-A be a module on systems with pKVM which removes the need for all > > > this dance done here ? > > > > But this means we reduce the other feature e.x) IMA with TPM over > > FF-A and pKVM feature. Since IMA must be a built-in, we couldn't avoid > > to build FF-A driver with built-in. > > > > > 2. If it is a requirement to have this built-in, I prefer to add a probe > > > and defer it instead of this root ffa device. > > > > But, How? anyway all of FF-A device & driver couldn't be probed unless > > FF-A initialisation is finished and How can we trigger FF-A initailise > > after pKVM finish its initialisation? > > > > The problem is ff-a intiailisation happens before pKVM finish its > > initailasation and to do defer probe, it should use dd-model and > > As we discussed in other thread, notifier couldn't be a soluation. > > > > Could you let me share other way I'm missing? > > > > Will something like below work ? If we add DT bindings, then we can add > of_match_table and drop the platform device creation. Also we can adjust > the parent device the way you have done by a simple change(not done in > this untested/not compiled change). > I have pushed the changes[1], will post once tested and you confirm your use-case also works. -- Regards, Sudeep [1] https://git.kernel.org/sudeep.holla/l/ffa_plat_dev