Re: [PATCH] media: dt-bindings: nxp,imx8mq-mipi-csi2: Fix example endpoint label typo

Laurent Pinchart
2026-05-06T14:22:05Z

On Wed, May 06, 2026 at 03:33:57PM +0200, Krzysztof Kozlowski wrote:
> On 06/05/2026 11:01, Robby Cai wrote:
> > The example in imx8mq-mipi-csi2.yaml uses imx8mm_mipi_csi_{in,out} endpoint
> > labels, which is confusing for an i.MX8MQ binding. Rename the labels to
> > imx8mq_mipi_csi_{in,out} for consistency.
> >
> > Fixes: 37255747ecbd ("media: dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller")
>
> Nothing to fix here. Otherwise explain the bug.
>
> > Signed-off-by: Robby Cai <robby.cai@nxp.com>
> > ---
> > .../devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
> > index 4fcfc4fd3565..71f79651dd96 100644
> > --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
> > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
> > @@ -220,7 +220,7 @@ examples:
> > port@0 {
> > reg = <0>;
> >
> > - imx8mm_mipi_csi_in: endpoint {
> > + imx8mq_mipi_csi_in: endpoint {
>
> Drop the labels instead - they are not used.

I think the label has value, it improves readability of the example by
making the purpose of the endpoints more explicit. I won't fight for it
though, I know it's hard to change your mind.

> This is just churn and for sure not a fix.
>
> NAK

--
Regards,

Laurent Pinchart