From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28710CD342C for ; Wed, 6 May 2026 16:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WIuAv2U9GPnbxnIVXVjoNb4ZlWTbL/WN8NBOiWgDuUA=; b=1QUrX3Co2E6jK1HDc7+7bO8vgC WlVOTEIWASSu55H+q7FNTDzis/plb+XVJDj9CYRRm/6FHMSdM6/ycALuqHeHjrs6Pz5G4wlre3Aqk FhnZnPqYRnaF15nSI15dLRIgVgrELlUy5F+XyE+M0lY0B3pxno50FbUnWWq95umqFB6rIwNq4cSJa PTBnf1M7pmD2iRo4Helxzp7sk+7chbAbGfuCaTfOE/tyLYqLqKEA9dkxovfRos+uYZK/jTDwPmro2 VjeZlfqnWi/lDdjc12dcFsVLSeVcF2duUURRWeH9PxVzQ1Gh/VPOuw9kUjLZ0CDvkcpMV4hh6Gmy9 PhbE7R6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKfNW-00000001Y6Q-3TuX; Wed, 06 May 2026 16:45:42 +0000 Received: from lpdvsmtp12.broadcom.com ([192.19.144.207] helo=relay.smtp-ext.broadcom.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKfNV-00000001Y5n-3NrL; Wed, 06 May 2026 16:45:41 +0000 Received: from mail-lvn-it-01.broadcom.com (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 8BE97C00151E; Wed, 6 May 2026 09:45:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 8BE97C00151E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1778085939; bh=pnx+TK8zeQAG2K101+AcDa+mZC2hhV45wFr99/sXDrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ChRc2cDiV37OxZ98ZHU9hmrv34VJq0ktCbzPQWXBdweKDCHe6omgWTdcEZIz297Wg JUBWpYaONW9TlQ5v479aSutfoXNunrSlKhs0BJO52uGN39YLotMbmFH34Ua0nq3re6 BmGcmoL3AO5Urrcb8qgOKwFbLmLguwn60vtdG0V4= Received: from stbirv-lnx-1.igp.broadcom.net (stbirv-lnx-1.igp.broadcom.net [10.67.48.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail-lvn-it-01.broadcom.com (Postfix) with ESMTPSA id 2D003B70; Wed, 6 May 2026 09:45:39 -0700 (PDT) From: Florian Fainelli To: linux-pci@vger.kernel.org Cc: Florian Fainelli , Dom Cobley , Phil Elwell , Jim Quinlan , Broadcom internal kernel review list , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Hans Zhang <18255117159@163.com>, linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] PCI: brcmstb: Assign pcie->gen from of_pci_get_max_link_speed() Date: Wed, 6 May 2026 09:45:37 -0700 Message-Id: <20260506164537.103196-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_094541_943896_6ADB09BA X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org After commit 03f920936977 ("PCI: controller: Validate max-link-speed"), pcie->gen stopped being assigned and as a result the established PCIe link would stop supporting Gen3 speeds on 2712 since pcie->gen is used to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen(). Whether the 'max-link-speed' property is not specified, or it exceeds Gen3, resort to the HW defaults. Link: https://github.com/raspberrypi/linux/issues/7343 Reported-by: Dom Cobley Reported-by: Phil Elwell Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed") Signed-off-by: Florian Fainelli Change-Id: Ic5431469dd7a6c8b391f84f27119dad876256880 --- Changes in v2: - utilize of_pci_get_max_link_speed() directly - also validate against exceeding Gen3 drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 714bcab97b60..08a0e7091ced 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -2072,8 +2072,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) return PTR_ERR(pcie->clk); ret = of_pci_get_max_link_speed(np); - if (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN) + if (ret < 0 || ret > 3) pcie->gen = 0; + else + pcie->gen = ret; pcie->ssc = of_property_read_bool(np, "brcm,enable-ssc"); -- 2.34.1