From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39E9FCD3436 for ; Fri, 8 May 2026 12:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sr914e8M5frO41Ll8HgmM3TR9EyIF1fwKLF1sY71UWM=; b=pfvrqC9Wzxv3xhwpDMMdo30gAr cT+jYRb4FGabv79CGn8nMaYyrXy66favTLtwd53KsjfcnP9sJi+2wZWz+7/NfwGqxPHaPRmYjwLrF 94wwg1L1sK0gmS1adB5OFNmSFiGl8m8fqZ/IVP4R4zRPICcPchiORo5E/8+DEFlTClroYUjKUDBFL TaDV4KUN+8yxKo/vvy6yFTmjxeGemLqVxvGmvpcIe4OskhmlUuC36Hyi3JUSpN1Dnc+EcRYlpZocS IruDs9gBkJaCaL7YVodar2c8CNVmcBkh3uIuH+JQi6YTXp/GqndS5pFaRChBQTikuiCn8gHouBJ42 fEX6fJpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLKQz-00000006Smz-3Geo; Fri, 08 May 2026 12:36:01 +0000 Received: from mail-westus2azon11012061.outbound.protection.outlook.com ([52.101.48.61] helo=MW6PR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLKQw-00000006SmY-3mWr for linux-arm-kernel@lists.infradead.org; Fri, 08 May 2026 12:36:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kI0Trk2t/3EgfZB/+TZLnNEGwix46U4fL7NExdr8fT6j8FHk0YrUsscm7iCuttUOEQP8INW7bUvE7yw30Cy2j/7vsD7sMF4SFFK1pNW7A+zeQbgqF9cfrd+3w9u4lZaDyAK0bacfyajhvQZWj/oHjHZQMXnFd8vi9EM6M42RWzSdp2PMsGEH/c3D5qa3YpGTRayH1bPalDd6CJfAJ7rKuSYuNhbC031YO1sLLXV6nWNZ2n90idLvDB8D/FwpgcmoMKfWQLMLANZIVhRxSjps782FVWkuDtW5mnXaZ5rrPdgpz5KuCfQnIwno88jocXD5fVd+hSznulqI92mXEjT0ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sr914e8M5frO41Ll8HgmM3TR9EyIF1fwKLF1sY71UWM=; b=Rseh/6n3k94+KKuuTFyq4U1tPZDuBgf1e7EpWACAfZabzkmNI54hdxCqfoeMrojp3PtmNSUIkZd+pPjLwys+oBXn8Uv2LoRpb/BEyiCPSGl2gtDHfV2qEimZ8IP6Yubz/YKRI87mWW+pNxYi9+1YBkjhTVhI2VAVeIYvzG8Rja5PK0LrgUQPQCuKnIFj6haE+bTWW/snVxY2mZUmY1QMTiszBYF5xY6cqIf2WvpXT9QXj0x3wt3Q+vFxhP1EMN+NwMZ+Lea3ZHlW/2/ZH2XxuRcDrtFevK6aI2rLwiKlvLO4v5ddhdXvegletfIxcM6zDhVTMjkqkHc3D+NzxZKHVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sr914e8M5frO41Ll8HgmM3TR9EyIF1fwKLF1sY71UWM=; b=tDJV9McRUwbaEssJnmyUijx195Ika8p45ZLI2yZSrNyJNU3Lsha93KIWrz1H4dNrI0onRlmMiNJGzFKOicFf65o5jCmbx/WiXfzWww4jiQiaeTaXxbmlyM286dJ8Fah7qgFVGpFEdxBNu9cVBrMk1+iiMr+aCIvPvOFeaDGtujg8o1+ZTRX65NQoXpYKINlo+aIygv+qpKmsmE8b+3JwC+7HDdb/wtPoTuqRCOTYMrkZSHBc0iVp4EwqZvZXOffGl1IxEHdqzj857ikB/vNZXe0AQlNQ+1uwoU94z1sS8iXvWt53pFV1ioXrNiF6f4g+Je3eW0r+tdlQ6Ms8V0JUag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by DS2PR12MB9797.namprd12.prod.outlook.com (2603:10b6:8:2ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 12:35:51 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9891.017; Fri, 8 May 2026 12:35:51 +0000 Date: Fri, 8 May 2026 09:35:50 -0300 From: Jason Gunthorpe To: Pranjal Shrivastava Cc: Nicolin Chen , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Robin Murphy , Catalin Marinas , =?utf-8?Q?Miko=C5=82aj?= Lenczewski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3-sva: Enable Hardware Access and Hardware Dirty bits Message-ID: <20260508123550.GB9254@nvidia.com> References: <20260503135413.1108138-1-nicolinc@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BLAP220CA0030.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::35) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|DS2PR12MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: c2e80086-396a-4738-1ca0-08deacfe56f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: JG4c2tMzURrnl6+rM2haWg1BpM7tgSh/4Zu6euaRDIoM5HFlPwUIBnYS0gzcQfA1r9JjUT7g7RTu/KRx9TBbKsOwJW9/avAIkD0ZjbYN2ujo/F/oNxXG3a/y4KVrMwxsLToBoAybOtDyyB2oVR4mlZ3YwqN2ythKcZR11C+DKEZrcURO2rlLM2dZvQLhD4YEwxu+dxK5SVrB09FdFEb3tNtuPB4rBU2LPZ8Mw2KHV92sAhmlYjtAWDwwRGSZI50HO1FpWS8WQ05UhspLLlbM4b54UC9dNvMe/20p80BVBrkdmNMJdRcv6JTQ/oBvZ9x2ydIi96hdOCVVQsC2MHpq24qjvzt9EqDqoeDrS7dVHP+YSQOaMUrCtzoLvY8lBa4wHOrzcvXJfraN/B67x3O42+/onT6DEOBNmZ5gudJv3iQrIr5cUm4AvkcX0dkwBXDjoEjK/nQbm966B4BW9ZAApsHkg6fW3+QGaZFxMQq5wv+LKgAPr7hEjbzRfimuLjbLwfORcrYHFhdrWcXNO5AriycD8sGve4fPhXrf3qjAuXzsanadQTirl57+cJ/oe3NKXRq5rx5C5MFQhDdLGLePUJBAZkGTWqiTeu2v0Uk8Vm9b8uUbiVC95RyOkKXp8k/Bxzkf3PC5njjtWeNV4OHYeeIbnOOazsZVnb93XEBuILOA0lR3d9VB+5fPqIbJA06a X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6Eshh0fDezhBEAOufiqQzLU8yJ1969EeNtD7OYQ1pn+4asPRfL9xn+TFpIvL?= =?us-ascii?Q?tajnWUe0VSlJVBZDXpLaQbB5eyncd9AaYEKxQMPfMBdxRvFYpTxsVRTZkiep?= =?us-ascii?Q?udD3nUC/L/GdNihsXeLmeEaeAqRUSumuu4JAPLdrfJQjCoF6cfBzBQ7VMH9/?= =?us-ascii?Q?jTKLCqqKf89XdCqAleTmCrwG+NvFfiiLNnaCXFvTZQsxOE2b+X4QW7fgOud8?= =?us-ascii?Q?MMwHHtiKDIwZ8VmYEYND0dNTi6kbFb6y+hSm1xOyWR8qIfAG5xWqqHgV9k1Z?= =?us-ascii?Q?VHAXNlf8ByBApyBjy5KQjvFHdAVyFPAifq36dpwV0KfhkYYU1LGPcUkhNM9I?= =?us-ascii?Q?UklJb/ymrahNYSs6MeL9r07lq5GJEHhdwehmE0Pfy725JvlqelhK8JYtHnuo?= =?us-ascii?Q?otYVx9otn2OVW/aME1MSt+3d0P+1a+qluxaXaSlK4daVbBmfpq5wAbqGYRdf?= =?us-ascii?Q?yERu6RXoFtfol3SCRRLLqJTtn9eUoSF7I5V+VI6tiJ9jziEb3IGD1iFIS1bj?= =?us-ascii?Q?7TsR/BgMXC+1Bk9yM7qkBudGYCVyv19z/wyrS3i9Bb+SFAfDYi03J0eZz9Pz?= =?us-ascii?Q?R9Pw+HURBHr956yym5eb3JBxmlJ5CEy9BFoXFSlTMkYfC/Ig28m30k1RgSCM?= =?us-ascii?Q?rbydx5FpxIMiqVarUZSQ4F1O0A/SZQOCeeQxbesPSS2Nf0hfIXlm2Z95P/LI?= =?us-ascii?Q?JVivBvEN44RL8RLjxWj/3051LV0VbQ5zZudeQWj8wAk44g+i9azHa8hD5q/3?= =?us-ascii?Q?0+9V85DIu8PELIg7d7mtn6cfb+N4+Antshn1QRoXC3TAfm9ynlMeGFLbaYAB?= =?us-ascii?Q?N6lA7teLJY7TVjFdokfMM1V5XTMK2rc1iD4+mVp489i3SCdkB1k3W6OXpAN/?= =?us-ascii?Q?Z/YwIplr9c96FKbhiaLqCTC4ZEcAmT+vNpPWUuvdjGZu/uVo3Gxq3hCz4xCu?= =?us-ascii?Q?wbGwWfQWBoqtUndIRpNERnlBFz9DwRg5RNRgZWqMiPRQJPz+/dTsfGyL4HYF?= =?us-ascii?Q?ljdlk/aCh0RBjCtkUGrdx1cGYxgL97ikOYT0vo1hm+LW0NmHIv62AYr+a/Hh?= =?us-ascii?Q?MhmgUu/1jwzEXfZcCHMSJ78lOrVxlpQsU8+EjS8kmeMo5jUyszDLlYCjQhM7?= =?us-ascii?Q?o8BC3cqF3ouMuNmOuYg6oyLlRu9QFgng5lrdPbecgHX/LJmVI93TysfamhIF?= =?us-ascii?Q?4UFS2vMUJnk/Hm7c4bpbjsPx3gBfRXKQT+v/3DdiTBaOJVM+eSrUslpFAqE4?= =?us-ascii?Q?yb8a7O3BjP3dWgxq9yDcEHG4NhN4rzY0BWVzXM0g7zwpof9xZQR8gGShWpYT?= =?us-ascii?Q?pGDUBUmwE7GdqlH3o99YMZGZOHeBHufym2lNaC+llwKJWL0cCZP7ALLCL+H0?= =?us-ascii?Q?TOjgJt04uL1PjMSNfZtU3DGGyB5lKm+P8oa5Ot5srGw1NOKUd6dhnfd4dwpB?= =?us-ascii?Q?FdC2uETDWoOGv81kpSdUPb9aR26FHBv4W9ZleAJJTAsmuiiHRGqQH2wQ/7Eu?= =?us-ascii?Q?t91EjWpZe4fLX/1oWssybNWhwmQcSKjOqr8gZLvxgR89QrkFqSG3gDbLHQVi?= =?us-ascii?Q?fptasAdcS54zHH1B7LyJt8Swh/69hBZMnyJFvTIruKdZx6Tsk2CRa1GwOimw?= =?us-ascii?Q?a+DZZ0iJRvLE1HEsd6CMktRUbfT66/VL3xEgTIPts2sazDqA85CEr/lRnb9Y?= =?us-ascii?Q?pOuvfib1ersxemFqLI9REgIcDXMqj3VZvIl/AgUwwNBgCbB/?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2e80086-396a-4738-1ca0-08deacfe56f3 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 12:35:51.5748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w2nr9WZ0ih4OVBJeqjVMQthOecmBujbgOriA/pTZENbH3rzu9rkpolh+epxjhAZW X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9797 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260508_053558_941181_D12D37F7 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2026 at 10:30:14PM +0000, Pranjal Shrivastava wrote: > > @@ -92,6 +92,16 @@ void arm_smmu_make_sva_cd(struct arm_smmu_cd *target, > > > > target->data[1] = cpu_to_le64(virt_to_phys(mm->pgd) & > > CTXDESC_CD_1_TTB0_MASK); > > + > > + /* > > + * Enable Hardware Access and Dirty updates (DBM) if supported. > > + * This is safe to enable by default, as PTE_WRITE and PTE_DBM > > + * share the same bit. > > + */ > > + if (master->smmu->features & ARM_SMMU_FEAT_HA) > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HA); > > + if (master->smmu->features & ARM_SMMU_FEAT_HD) > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HD); > > IIUC, we should be setting these if IO_PGTABLE_QUIRK_ARM_HD is present? SVA does not use IO_PGTABLE at all, and it directly constructs its own CD. No relation between those two flows. Jason