From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85618CD3436 for ; Fri, 8 May 2026 15:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ABTsrxKI7wvHYsDhlFaaebOEdb12GJNVTckm+uz0E1s=; b=24BDnJin0+h8lhqIQxDId3U+XS cRVW6iB1TLM0p5vTCAgDmyw03S6TtPVzso8KK/vojFiu+ZA7lFka1NN/9AcdO2N9hUTBvzhEPcPw9 kdX2PDZ741Nn4oZ6VkvTX8V5LOmtZaP6juLy+jsJ+/SZoPiQmvpXYJZciqWkQdnTGiXc+sMoav86d EGhCKnHULEXueedgpFrqy3q0Jr5aKGrzSr7Uv4PNhvzeRCKZg9afPV4WKz7SgHHhHmr50F8sQIDpq g+SO6RFgBI5H4XSKjrWH3dSjJBeWyWCDo71HnX/zLmU05pFiuSMruikxtH/M6/R1V4qra9Mjs4G22 8nlcnmKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLNDD-00000006rKq-0hbd; Fri, 08 May 2026 15:34:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLND8-00000006rFn-2Coz for linux-arm-kernel@bombadil.infradead.org; Fri, 08 May 2026 15:33:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=ABTsrxKI7wvHYsDhlFaaebOEdb12GJNVTckm+uz0E1s=; b=WO93PFiwQbCvnNeMdMqlhkVI0x 08/ICKQKE+xHorsTNUwnOIFaniux4jPcLM4gGXFFvsgqkkYM3oaUllCpGNXWKE3dEJyt5gJOWYWQz ROYaWYRA/42XLB6zNfQtO2YRx4quT1cPSFrecsJSseX2AQPCP92u9JATdvUkBjArXBnazNPz2ZzB3 pMeqXRq6DlpR2lmU1creI17hJKtIEXoOQxVYL7hfa6M1FTmj0PJxFkq89KaAxmzbEDzs+aIRXb9ft P74k7SNbNaSXCQqGBy8P70QVQtcF7jeh7yptiqFnGqv8xIMhF+07u8Ym9CljRh6KcSGOB/NPeFOjd uGX3UmiQ==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLND5-00000006iLU-1F5Z for linux-arm-kernel@lists.infradead.org; Fri, 08 May 2026 15:33:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9981F35A1; Fri, 8 May 2026 08:33:44 -0700 (PDT) Received: from pluto.fritz.box (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C70A3F836; Fri, 8 May 2026 08:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1778254430; bh=kM+U8v3f2McW8OM5ONalrhlXqiBSrlQSwzAp9yyXSgY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fxsUPOFghTDuToJOqTOpKu4knl7XZGgMLInPrcTVOQcChZ64SAp5uO+NuHmz9yhuc dn8mHWAVYwVBGU9Wr4TlBt6ADjNRMDVBvpi/onU6pOvNGbpzAMMzBx4AabhsmoKfUb /iwszYNeKqYioM0MiuhtZVvJLNL3q6TbM/CvuWoU= From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: sudeep.holla@arm.com, philip.radford@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@foss.st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, geert+renesas@glider.be, kuninori.morimoto.gx@renesas.com, marek.vasut+renesas@gmail.com, Cristian Marussi , Peng Fan Subject: [PATCH v4 07/15] firmware: arm_scmi: Make clock rates allocation dynamic Date: Fri, 8 May 2026 16:32:52 +0100 Message-ID: <20260508153300.2224715-8-cristian.marussi@arm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260508153300.2224715-1-cristian.marussi@arm.com> References: <20260508153300.2224715-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260508_163351_993750_32824F73 X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Leveraging SCMI Clock protocol dynamic discovery capabilities, move away from the static per-clock rates allocation model in favour of a dynamic runtime allocation based on effectively discovered resources. No functional change. Reviewed-by: Peng Fan Signed-off-by: Cristian Marussi --- v2 --> v3 - collected Review-by tags --- drivers/firmware/arm_scmi/clock.c | 19 ++++++++++++++++--- include/linux/scmi_protocol.h | 1 - 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c index 467b13a3a18f..c9b62edce4fd 100644 --- a/drivers/firmware/arm_scmi/clock.c +++ b/drivers/firmware/arm_scmi/clock.c @@ -161,7 +161,7 @@ struct scmi_clock_desc { u32 id; bool rate_discrete; unsigned int num_rates; - u64 rates[SCMI_MAX_NUM_RATES]; + u64 *rates; #define RATE_MIN 0 #define RATE_MAX 1 #define RATE_STEP 2 @@ -480,6 +480,18 @@ iter_clk_describe_update_state(struct scmi_iterator_state *st, QUIRK_OUT_OF_SPEC_TRIPLET); } + if (!st->max_resources) { + int num_rates = st->num_returned + st->num_remaining; + + p->clkd->rates = devm_kcalloc(p->dev, num_rates, + sizeof(*p->clkd->rates), GFP_KERNEL); + if (!p->clkd->rates) + return -ENOMEM; + + /* max_resources is used by the iterators to control bounds */ + st->max_resources = st->num_returned + st->num_remaining; + } + return 0; } @@ -493,6 +505,8 @@ iter_clk_describe_process_response(const struct scmi_protocol_handle *ph, p->clkd->rates[st->desc_index + st->loop_idx] = RATE_TO_U64(r->rate[st->loop_idx]); + + /* Count only effectively discovered rates */ p->clkd->num_rates++; return 0; @@ -515,8 +529,7 @@ scmi_clock_describe_rates_get(const struct scmi_protocol_handle *ph, u32 clk_id, .dev = ph->dev, }; - iter = ph->hops->iter_response_init(ph, &ops, SCMI_MAX_NUM_RATES, - CLOCK_DESCRIBE_RATES, + iter = ph->hops->iter_response_init(ph, &ops, 0, CLOCK_DESCRIBE_RATES, sizeof(struct scmi_msg_clock_describe_rates), &cpriv); if (IS_ERR(iter)) diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index 19834f85f5d3..0824a7dc4aae 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -15,7 +15,6 @@ #define SCMI_MAX_STR_SIZE 64 #define SCMI_SHORT_NAME_MAX_SIZE 16 -#define SCMI_MAX_NUM_RATES 16 /** * struct scmi_revision_info - version information structure -- 2.53.0