From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7A63CD4F24 for ; Tue, 12 May 2026 17:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VZBLTK2DdwywAhDF0XTPjOVZtq1ja7uZBlKESzPWNGI=; b=q90cZTcpgb0wSvc244KJI7SE8L tG3QaS4f5TrgLSZmk8SNfjeYkcWxt/iA3yqYFzXTrq876jekVRa4zIGoyx+XfIUo8pey9GxLwTpap cVPV2Ik6pXAQpFN9emeDxuccQYj5EmSvjehNGXIiFOtt9/VPlMc+O8fazT/q0LtHBNpfHHoN6DSB6 ug+XXW9PxAmz5ntX6mg/36P0sI4XXZOnXnfyCZNKmMlbTCmPg528bbTmbLeKAe0qkPuNKEXek6x3G 7F08mam7jyOypNgwj1I7hdLzncStByuJmmNAzDj1crRv81rp4U9Qg0NoMbVGnLJjaj3cpuFa2Hh2C Gd9mkxzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMqXD-0000000HTcW-212u; Tue, 12 May 2026 17:04:43 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMqXB-0000000HTc3-2pQY; Tue, 12 May 2026 17:04:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C54E760139; Tue, 12 May 2026 17:04:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5208EC2BCB0; Tue, 12 May 2026 17:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778605480; bh=9Vq8ijFk8qJn7DB2+1iE5j4p/FmaoDocX6KgE6Vblx8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ckw8o3o0c0PfAJEyLSntxYwVU4AbfEuak91RBXrwRvyzNAIe4jv8elNEjpfjPY0PC MkPhOUg9mXjl6MShmhGCSrJ1Wi/YbhNZMV3OMkrZet37w7P7c78VHtD1BGnMduHl3w Tfmm5P5b4C7uOR4xgLVhKFhG4y+fiIzmQsbSbfBFORbEv6M6VS4q5qdE8n9xOg7185 EfetoI9BoCOmRvpEw9cIDscSQ9sDtGLuvMyEGuMv9xXcpM4MH3RfGamDSrXuarfIWb B+x8jICCR3r04yE5fHgTYsCHm293bLNlNn46JSSWtoyneqS57vFmlHFeOUhd9JC/Zs Zp9b3Kve5z4jA== Date: Tue, 12 May 2026 18:04:26 +0100 From: Jonathan Cameron To: Roman Vivchar Cc: Andy Shevchenko , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Sen Chu , Sean Wang , Macpaul Lin , Lee Jones , Srinivas Kandagatla , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Ben Grisdale Subject: Re: [PATCH v2 05/16] iio: adc: mediatek: add mt6323 PMIC AUXADC driver Message-ID: <20260512180426.04677461@jic23-huawei> In-Reply-To: References: <20260512-mt6323-v2-0-3efcba579e88@protonmail.com> <20260512-mt6323-v2-5-3efcba579e88@protonmail.com> <20260512142932.5c6801d1@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 May 2026 14:34:55 +0000 Roman Vivchar wrote: > On Tuesday, May 12th, 2026 at 4:29 PM, Jonathan Cameron wrote: > > > On Tue, 12 May 2026 08:18:19 +0300 > > Roman Vivchar via B4 Relay wrote: > > ... > > > > +#define VOLTAGE_FULL_RANGE 1800 > > Probably better to have this inline - however if you do keep it > > prefix t he define VOLTAGE_FULL_RANGE sounds too generic! > > > > > +#define AUXADC_PRECISE 32768 > > I'd put that inline. Little benefit it in having it up here... > > There was a mention about magic values in the v1 for the thermal patch [1]. > Andy, would it be better to use an inline style or a #define here? > If the former, I'll rename the first constant to something like > AUXADC_VOLTAGE_FULL_RANGE. FWIW that isn't a magic value - it's 2**resolution and the one is a voltage in mV. Those aren't normally the ones people care about defines for - those apply when they are weird and wonderful things not related directly to physical quantities. Jonathan > > [1]: https://lore.kernel.org/linux-mediatek/afmnUG8dG0N0HpV6@ashevche-desk.local/ > > Best regards, > Roman