From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68714CD4F57 for ; Mon, 18 May 2026 19:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=29OmGxotXpQtQ8RYOjbQxdOif6EH1gz/kJ3dPWnQUVk=; b=LcIIvT2KGX/MSpHUARFkTM4gsh 5EQOL53Z/DS7AL3W+gampm5nQDoUMYbSmN/ikbT7Qec9z0knbZkO3IYZ4e2TEhju39zCUHlFDxru4 7WeNzaZDaFLa9RiZi0TAyJujH5UMHv9Jjjcea9UlMwkhvllaSfnHifYDBFTHhqTjLO2r5bVjV+piE 2OepwVPYoiBmEu9pvfHL4jwzUKc+uhgxcmUHJQkTbMX04a1jJxwtTEOU+veFvifdZApzEM0wn8kMi vNdg04k1TtMZ/R/m0hrOPYmg9STQey79gpnzbEk8Q+GkhGhoC2yYrECNgSyuWEt9qizLusD16LuTz wqdRGIvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wP3xV-0000000GmZb-3dxP; Mon, 18 May 2026 19:49:01 +0000 Received: from smtp.forwardemail.net ([121.127.44.73]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wP3xK-0000000GmAH-0El2 for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2026 19:48:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1779133729; bh=29OmGxotXpQtQ8RYOjbQxdOif6EH1gz/kJ3dPWnQUVk=; b=vXfwRLdxbDuzgx9D4jsXj6de/fq56FNucbMBODRrdv2+dq91wDnV9/Rts6e1Rr3lZowXkaNvl 8ckIyD80ySE5I+PgW+MuQ8e6jrXwuJ+XraFZ8isQkMnPa94SpuG8+ltMl1wBo+4o8WtN/roTnBO r2n7sg8PL4lXh6HmPcY0B1YqL2xZt69QZMqKIgKEP0vbaqcNj4U+BLlAQVOYMFXXElRr3yfQ7tf UdKQlbHoM6SjSYjd5/wEJS9hUFojwk8ofUjgHqNy9JlkuqDv0PhJ0xT6NiW0kMd32wqRRNO5zxP bOloAeW7axDmYl2WmZnlHWUsYCYLhuEaQV816s5mYENA== X-Forward-Email-ID: 6a0b6d13b74b0ebd362eef32 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 2.8.12 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Neil Armstrong , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman , linux-rockchip@lists.infradead.org Subject: [PATCH 10/13] drm/meson: dw-hdmi: Use dev_err_probe() to report errors Date: Mon, 18 May 2026 19:47:38 +0000 Message-ID: <20260518194744.2483580-11-jonas@kwiboo.se> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518194744.2483580-1-jonas@kwiboo.se> References: <20260518194744.2483580-1-jonas@kwiboo.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260518_124850_386351_1E863443 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Change to use dev_err_probe() to report bind() errors consistently. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 65 +++++++++++++-------------- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index d0cf2042d41c..1dd59196ff7f 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -650,10 +650,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, DRM_DEBUG_DRIVER("\n"); match = of_device_get_match_data(dev); - if (!match) { - dev_err(dev, "failed to get match data\n"); - return -ENODEV; - } + if (!match) + return dev_err_probe(dev, -ENODEV, + "Failed to get match data\n"); meson_dw_hdmi = devm_kzalloc(dev, sizeof(*meson_dw_hdmi), GFP_KERNEL); @@ -667,50 +666,45 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, ret = devm_regulator_get_enable_optional(dev, "hdmi"); if (ret < 0 && ret != -ENODEV) - return ret; + return dev_err_probe(dev, ret, + "Failed to get/enable hdmi regulator\n"); meson_dw_hdmi->hdmitx_apb = devm_reset_control_get_exclusive(dev, "hdmitx_apb"); - if (IS_ERR(meson_dw_hdmi->hdmitx_apb)) { - dev_err(dev, "Failed to get hdmitx_apb reset\n"); - return PTR_ERR(meson_dw_hdmi->hdmitx_apb); - } + if (IS_ERR(meson_dw_hdmi->hdmitx_apb)) + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_apb), + "Failed to get hdmitx_apb reset\n"); meson_dw_hdmi->hdmitx_ctrl = devm_reset_control_get_exclusive(dev, "hdmitx"); - if (IS_ERR(meson_dw_hdmi->hdmitx_ctrl)) { - dev_err(dev, "Failed to get hdmitx reset\n"); - return PTR_ERR(meson_dw_hdmi->hdmitx_ctrl); - } + if (IS_ERR(meson_dw_hdmi->hdmitx_ctrl)) + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_ctrl), + "Failed to get hdmitx reset\n"); meson_dw_hdmi->hdmitx_phy = devm_reset_control_get_exclusive(dev, "hdmitx_phy"); - if (IS_ERR(meson_dw_hdmi->hdmitx_phy)) { - dev_err(dev, "Failed to get hdmitx_phy reset\n"); - return PTR_ERR(meson_dw_hdmi->hdmitx_phy); - } + if (IS_ERR(meson_dw_hdmi->hdmitx_phy)) + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_phy), + "Failed to get hdmitx_phy reset\n"); meson_dw_hdmi->hdmitx = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(meson_dw_hdmi->hdmitx)) return PTR_ERR(meson_dw_hdmi->hdmitx); clk = devm_clk_get_enabled(dev, "isfr"); - if (IS_ERR(clk)) { - dev_err(dev, "Unable to get isfr pclk\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "Failed to get isfr pclk\n"); clk = devm_clk_get_enabled(dev, "iahb"); - if (IS_ERR(clk)) { - dev_err(dev, "Unable to get iahb pclk\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "Failed to get iahb pclk\n"); clk = devm_clk_get_enabled(dev, "venci"); - if (IS_ERR(clk)) { - dev_err(dev, "Unable to get venci pclk\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "Failed to get venci pclk\n"); dw_plat_data->regm = devm_regmap_init(dev, NULL, meson_dw_hdmi, &meson_dw_hdmi_regmap_config); @@ -724,10 +718,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq, dw_hdmi_top_thread_irq, IRQF_SHARED, "dw_hdmi_top_irq", meson_dw_hdmi); - if (ret) { - dev_err(dev, "Failed to request hdmi top irq\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to request hdmi top irq\n"); meson_dw_hdmi_init(meson_dw_hdmi); @@ -752,14 +745,16 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, meson_dw_hdmi->hdmi = dw_hdmi_probe(pdev, &meson_dw_hdmi->dw_plat_data); if (IS_ERR(meson_dw_hdmi->hdmi)) { devm_free_irq(dev, irq, meson_dw_hdmi); - return PTR_ERR(meson_dw_hdmi->hdmi); + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmi), + "Failed to probe dw-hdmi bridge\n"); } meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(dev->of_node); if (!meson_dw_hdmi->bridge) { devm_free_irq(dev, irq, meson_dw_hdmi); dw_hdmi_remove(meson_dw_hdmi->hdmi); - return -ENODEV; + return dev_err_probe(dev, -ENODEV, + "Failed to find dw-hdmi bridge\n"); } DRM_DEBUG_DRIVER("HDMI controller initialized\n"); -- 2.54.0