From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEDE5CD4F3D for ; Wed, 20 May 2026 13:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mUsifWX6aK2jxqZvUw8q1yQUjx3vnN/cEOO8Ykzq3n4=; b=fvOOju5RWQKhbOFJ+SFegHUILX BPbGkoSsbwqk+3GwRzoBI3TKTYF5hImaa6sxim+i66XnfYTTfeq9Fs36QlrLCzNrqtSNH2Nm6jqL1 /qB+iKeS3Q5ecLseJlFsug3Wpi6LblpPIXmL90jb5ou+Wos+utpUvq48Tf2/mNT4MyU8yw/b+xP1E 7wg55LNzrXDZ7r0RHPrCID+LiTsFAY29dRZWV02uFbbGWRDH7F/8O6mPqzsFpFooSmxKROe6wHp3b 4kC6wWc/sHf1S4lfpkYulAWHGAIwJPaBvQ5kn4mXUOU4iYMOf9obGqXO+Of6EoSnrGepfAP2MJ5Sc pP3x7F/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPgiX-00000004eFn-245T; Wed, 20 May 2026 13:12:09 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPgiU-00000004eEa-3Pxg for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2026 13:12:07 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-452169ae568so3123647f8f.3 for ; Wed, 20 May 2026 06:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779282725; x=1779887525; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mUsifWX6aK2jxqZvUw8q1yQUjx3vnN/cEOO8Ykzq3n4=; b=TlIuVGhTGVsvdr8CEpjeD3UYlf2sPabc0Ft7IIwxu125bdhTatVij/cq3U+dBpaxcY NcaDnbTGOzZMSUYOEk34dlI0pZTM9/8Jaaz9+Iz9CU/opsc3ZNuPkmuZpsMMdECycZP/ ewjRqNnn19PE4AEDdPgyXP2Ig5H2Xj8Y7JHmZP9wqT3jPAKV8vNdCXaR9aiRCywx2329 fGrpjqNd7koSIPp2VMmAgqjkzRPWKA8+6PYakIOfa5uEuJOJkJhvjN5rrZkzsthu09WF PvEhwu8CoMvZRlBRmVUHTa/wHZ6pc2+HtxTcfVPyXtHGMeHaTMPXPkWCvksL4hT0NdxS C2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779282725; x=1779887525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mUsifWX6aK2jxqZvUw8q1yQUjx3vnN/cEOO8Ykzq3n4=; b=RYdp5CLJL/J5976SweT15mukc7ea+FEwo3hJHi7yXRs84DN7m+s0FHzVMJlRNm5GPj WfsmxdJSCcPWkbRgi6CJN1OvCFHbXyKIbHjkTDbaTz4dAOPOcLpdQMOiIC96xFnTs6Im DbSkrxicydM2UKNfES0uKl/eG6zxB/6hO++bJQPAMBSJrFHeouJV1iFcmVA95ho9brFG tRTd8VWhk0jFZXatT5wxC+gSXcjkJUWZOt25RjfR5WJW68/cWMBNokIqlsWQRaIQWZxw k5/tyLia290dpNNpczYdrx92/jEy3GSshUhOwqLHi0oUH9SgTak8DyMviU+QKpWt8uwK YS2A== X-Forwarded-Encrypted: i=1; AFNElJ/LJEQc68TAUh3TpWtesjWssqNBJ8ycBbks1WQtKHKCpDocimMMBPdoPFAiwmjzdpEgMilNvnCC/1xqbrGPool9@lists.infradead.org X-Gm-Message-State: AOJu0YwMWfI7zhZU0IzC09ODmtkuMpa2O+0X4AYDbNfz/1+htsbZajWr RSlWHOCWTxuWJbKE6KDurK5SuJQdSPDEzO6pBAN+0NBbXDcayRk+hx/s X-Gm-Gg: Acq92OGvM5Up9n+DeGuHSfsQSfDsYFCfmA4aoxfL+COj5zE8j1L/dMQr0mw9J9cloHg uIIGk4qwEydzfg1lL2ncToDYSVsnsxoYodaw5UeEVrI4XMPs4JmWMCv3dhPUnfPzyfikS2ljkn0 FWwfBaW+x7m0rjoxD0EJm0Ar8PubHbKQ0rnuj8cQj0xk+W5Fy82IK1wKsUJAxIoIulonWyBlg9A K5PK4NGadoM82+K6VvwaFRQO66Fynnkxa2/aUtQv/DhzAmxeHHhy4bTGEb0RFVvR/QqNEsI89He iJiRMeunYB+2fFiSna7J7XRGAmtIPwb++bZAJoT71B9mysivKBBTh5a3Bi4RX/tv1/xaULlkOZj a9SGlfwClJYudZkk6G+oC+AgzAuQbS7Uj/BQoJI4tmovUyXqgOLeZ2fclCbrveHHn0stdlen3WY cceK7JNgBGYiKCys785ATV8e9mmbNYaI2WJUXwa5jaM8utqiKkhJmldoo6zRL+G3tT X-Received: by 2002:a05:6000:1844:b0:45e:98ed:bde5 with SMTP id ffacd0b85a97d-45e98edbeb5mr3627217f8f.24.1779282724547; Wed, 20 May 2026 06:12:04 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe13a7sm56345921f8f.29.2026.05.20.06.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:12:04 -0700 (PDT) Date: Wed, 20 May 2026 14:12:02 +0100 From: David Laight To: Rosen Penev Cc: linux-sound@vger.kernel.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: Re: [PATCH] ASoC: mediatek: mt2701: fix snprintf bounds Message-ID: <20260520141202.1803aa7d@pumpkin> In-Reply-To: <20260519010440.629290-1-rosenp@gmail.com> References: <20260519010440.629290-1-rosenp@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260520_061206_876081_2649E792 X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 18 May 2026 18:04:40 -0700 Rosen Penev wrote: > For whatever reason, GCC is unable to figure out that i2s_num is a > single digit number, with MT2701_BASE_CLK_NUM being the maximum value it > represents. Add a min() call to help it out and fix W=1 errors regarding > snprintf bounds. > > Signed-off-by: Rosen Penev > --- > sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c b/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c > index 5a2bcf027b4f..43157f218409 100644 > --- a/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c > +++ b/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c > @@ -25,6 +25,7 @@ static const char *const base_clks[] = { > int mt2701_init_clock(struct mtk_base_afe *afe) > { > struct mt2701_afe_private *afe_priv = afe->platform_priv; > + int i2s_num; > int i; > > for (i = 0; i < MT2701_BASE_CLK_NUM; i++) { > @@ -35,8 +36,9 @@ int mt2701_init_clock(struct mtk_base_afe *afe) > } > } > > + i2s_num = min(MT2701_BASE_CLK_NUM, afe_priv->soc->i2s_num); To me that is backwards, like an 'if' put the variable before the limit. > /* Get I2S related clocks */ > - for (i = 0; i < afe_priv->soc->i2s_num; i++) { > + for (i = 0; i < i2s_num; i++) { Caching the limit also stops the compiler having to read it every iteration. -- David > struct mt2701_i2s_path *i2s_path = &afe_priv->i2s_path[i]; > struct clk *i2s_ck; > char name[13];