From: Aviv Bakal <avivb@amazon.com>
To: <robin.murphy@arm.com>, <will@kernel.org>, <mark.rutland@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <avivb@amazon.com>,
<zeev@amazon.com>, <blakgeof@amazon.com>
Subject: [PATCH v3 0/2] perf/arm-cmn: Add workarounds for CMN-S3 on Graviton5
Date: Sun, 24 May 2026 18:38:46 +0300 [thread overview]
Message-ID: <20260524153848.16334-1-avivb@amazon.com> (raw)
In-Reply-To: <20260504133923.23373-1-avivb@amazon.com>
This series adds support for Graviton5's customised CMN-S3 which has
zeroed discovery registers.
Robin, I understand moving driver state into the core perf header isn't
ideal, but I couldn't find another way to grow the struct. The v2
submission failed the kernel test robot build on i386 (COMPILE_TEST) due
to arm_cmn_hw_event exceeding the static_assert against the 'target'
field offset when CMN_MAX_DIMENSION is increased beyond 12.
Patch 1 moves struct arm_cmn_hw_event into the hw_perf_event union to
resolve this. I'd appreciate your feedback on this approach, or any
alternative you'd suggest.
Patch 2 adds the Graviton5 workarounds themselves (unchanged from v2
except for the DTC logid fix below).
Changes since v2:
- Revert DTC logical ID assignment back to xp->logid (per Robin's
review)
- Add patch 1/2 to move arm_cmn_hw_event into hw_perf_event union
to resolve 32-bit build failure
Aviv Bakal (2):
perf/arm-cmn: Move struct arm_cmn_hw_event into struct hw_perf_event
perf/arm-cmn: Add workarounds for CMN-S3 on Graviton5
drivers/perf/arm-cmn.c | 55 +++++++++++++++++++++-----------------
include/linux/perf_event.h | 22 +++++++++++++++
2 files changed, 52 insertions(+), 25 deletions(-)
--
2.47.3
next prev parent reply other threads:[~2026-05-24 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 15:51 [PATCH] perf/arm-cmn: Add workarounds for CMN-S3 on Graviton5 Aviv Bakal
2026-05-04 13:39 ` [PATCH v2] " Aviv Bakal
2026-05-05 2:31 ` kernel test robot
2026-05-21 16:02 ` Robin Murphy
2026-05-24 15:38 ` Aviv Bakal [this message]
2026-05-24 15:38 ` [PATCH v3 1/2] perf/arm-cmn: Move struct arm_cmn_hw_event into struct hw_perf_event Aviv Bakal
2026-05-24 15:38 ` [PATCH v3 2/2] perf/arm-cmn: Add workarounds for CMN-S3 on Graviton5 Aviv Bakal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260524153848.16334-1-avivb@amazon.com \
--to=avivb@amazon.com \
--cc=blakgeof@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=zeev@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox