Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Nishanth Menon <nm@ti.com>
Cc: Vitor Soares <ivitro@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Vitor Soares <vitor.soares@toradex.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 06/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI
Date: Fri, 29 May 2026 18:02:27 +0200	[thread overview]
Message-ID: <20260529160227.GA6917@francesco-nb> (raw)
In-Reply-To: <20260529155345.z6ht5adzhwafdvx5@voting>

On Fri, May 29, 2026 at 10:53:45AM -0500, Nishanth Menon wrote:
> On 17:11-20260522, Vitor Soares wrote:
> > +	touchscreen@41 {
> > +		compatible = "ilitek,ili2132";
> > +		reg = <0x41>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_dsi1_int>, <&pinctrl_i2s_2_bclk_gpio>;
> > +		/* Verdin GPIO_9_DSI (SODIMM 17) - TOUCH_INT# */
> > +		interrupt-parent = <&main_gpio1>;
> > +		interrupts = <49 IRQ_TYPE_EDGE_RISING>;
> 
> https://lore.kernel.org/r/20260521152550.A928B1F000E9@smtp.kernel.org
> https://lore.kernel.org/r/20260522140245.472651F000E9@smtp.kernel.org
> Sashiko comment would probably be good to explain - I see the same in
> v3.

The interrupt pin of the ilitek,ili2132 touch controller is a very short
pulse, the net name TOUCH_INT# is on the board side and it is generic,
not specific on the touch controller used.

Both falling and edge would work fine.

The reason for using rising is that for the way the HW is designed the
interrupt signal is not that "clean", and triggering on the falling edge
produce some spurious interrupt. Those spurious interrupts are handled
nicely by the driver, but they pollute the kernel logs for no reason.


Nishanth: in general do you want an explicit answer to every comment made my
sashiko?

Francesco



  reply	other threads:[~2026-05-29 16:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 16:11 [PATCH v3 00/11] arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Vitor Soares
2026-05-22 16:11 ` [PATCH v3 01/11] arm64: dts: ti: k3-am62-verdin: Add Toradex DSI to LVDS adapter with 10.1" display Vitor Soares
2026-05-22 16:11 ` [PATCH v3 02/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS Vitor Soares
2026-05-22 16:11 ` [PATCH v3 03/11] dt-bindings: vendor-prefixes: Add Riverdi Vitor Soares
2026-05-22 16:11 ` [PATCH v3 04/11] dt-bindings: display: panel-lvds: Add Riverdi RVT70HSLNWCA0 and RVT101HVLNWC00 Vitor Soares
2026-05-22 16:11 ` [PATCH v3 05/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI Vitor Soares
2026-05-22 16:11 ` [PATCH v3 06/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI Vitor Soares
2026-05-29 15:53   ` Nishanth Menon
2026-05-29 16:02     ` Francesco Dolcini [this message]
2026-05-29 16:14       ` Nishanth Menon
2026-05-22 16:11 ` [PATCH v3 07/11] arm64: dts: ti: k3-am62-verdin: Add NAU8822 Bridge Tied Load Vitor Soares
2026-05-22 16:11 ` [PATCH v3 08/11] arm64: dts: ti: k3-am62-verdin: Reserve UART_4 for Cortex-M4F Vitor Soares
2026-05-22 16:11 ` [PATCH v3 09/11] arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras Vitor Soares
2026-05-22 16:11 ` [PATCH v3 10/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Verdin Mezzanine CAN Vitor Soares
2026-05-22 16:11 ` [PATCH v3 11/11] arm64: dts: ti: k3-am62-verdin: Add Mezzanine with Toradex Display 10.1" LVDS Vitor Soares
2026-05-22 17:05 ` [PATCH v3 00/11] arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Francesco Dolcini
2026-05-26 14:53 ` (subset) " Neil Armstrong
2026-05-28 11:40   ` Nishanth Menon
2026-05-29 13:41     ` Neil Armstrong
2026-05-29 13:45 ` Neil Armstrong
2026-05-29 20:08 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529160227.GA6917@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ivitro@gmail.com \
    --cc=jesszhan0024@gmail.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nm@ti.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    --cc=vitor.soares@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox