Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	 Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Abraham I <kishon@kernel.org>, Roger Quadros <rogerq@kernel.org>,
	 Devarsh Thakkar <devarsht@ti.com>, Swamil Jain <s-jain1@ti.com>,
	 linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: soc: ti: ti,j721e-system-controller: Relax the bindings
Date: Sat, 30 May 2026 13:40:22 +0200	[thread overview]
Message-ID: <20260530-kind-asparagus-vicugna-b710fb@quoll> (raw)
In-Reply-To: <20260528-ti-main-conf-v1-4-a54ac5c8d081@ideasonboard.com>

On Thu, May 28, 2026 at 03:53:45PM +0300, Tomi Valkeinen wrote:
> The ti,j721e-system-controller binding specifies a specific schema for
> each child node. For example, any clock node under the system controller
> node must be a ti,am654-serdes-ctrl.
> 
> To be able to use the same system-controller binding for more SoCs,
> relax the bindings by making both clock-controller and clock accept any

NAK, you cannot relax bindings.

> kind of child node.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
>  .../devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml      | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
> index f3bd0be3b279..56712ebdd01b 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
> @@ -53,9 +53,8 @@ patternProperties:
>  
>    "^clock-controller@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#

No, child nodes cannot be generic (see also writing bindings). You must
have $ref or use the compatible style.

Best regards,
Krzysztof



  reply	other threads:[~2026-05-30 11:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 12:53 [PATCH 0/6] arm64: ti: Use syscon for the Control Module Tomi Valkeinen
2026-05-28 12:53 ` [PATCH 1/6] arm64: dts: ti: j784s4/j742s2: Rename pcieN-ctrl nodes to pcie-ctrl Tomi Valkeinen
2026-05-28 12:53 ` [PATCH 2/6] arm64: dts: ti: k3-am62*: Rename 'clock-controller' to 'clock' Tomi Valkeinen
2026-05-28 12:53 ` [PATCH 3/6] arm64: dts: ti: k3-am62-main: Rename 'oldi-io-controller' to 'dss-oldi-io-ctrl' Tomi Valkeinen
2026-05-28 12:53 ` [PATCH 4/6] dt-bindings: soc: ti: ti,j721e-system-controller: Relax the bindings Tomi Valkeinen
2026-05-30 11:40   ` Krzysztof Kozlowski [this message]
2026-05-28 12:53 ` [PATCH 5/6] dt-bindings: soc: ti: ti,j721e-system-controller: Add more compatibles Tomi Valkeinen
2026-05-30 11:39   ` Krzysztof Kozlowski
2026-05-28 12:53 ` [PATCH 6/6] arm64: dts: ti: Use syscon and simple-mfd for the main conf region Tomi Valkeinen
2026-05-28 22:59 ` [PATCH 0/6] arm64: ti: Use syscon for the Control Module Andrew Davis
2026-06-12 10:06   ` Tomi Valkeinen
2026-06-26 11:42   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530-kind-asparagus-vicugna-b710fb@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-jain1@ti.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox