From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BDF9CD6E4A for ; Tue, 2 Jun 2026 05:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OqMWFZd9Lh6luW5CeI848QHyRFF7wsnQ7DaiCYPSL9Y=; b=zHIJDsw0O5xuDMRQK5Ak2H0OU4 xCX3NV7L5C6HgxKW8YisCwXEbdu6LrNjgcLlviNCkClnAXlhvuDESNV1MHXOR7WxFbW6a93gqs1qo fCfUKgeRFkx79Hwe9Q/CAhJ5LRK2KsD14JO+XK5ZiSsw15zv1pPpyp6xh/K/ekcZ9QGgYK8tacWFm U6nRDwcPcF1zVOgigab1XjUl1peuuoX2t60RXsGlJ5KLJ5MkcumGxghjSfAq1s2mjDKDh1ieIM2WS alcQNxhesxSymur5iU0G/cpttvXLDYC9XvQPRfBKxilQCHqYkcRy5Lt2JBbXTrDiE8bSLo+17nqPE Vku1HxBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUHQ5-0000000CJep-1XNn; Tue, 02 Jun 2026 05:12:05 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUHQ1-0000000CJeR-1Juy for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2026 05:12:04 +0000 Received: from francesco-nb (93-35-44-150.ip53.fastwebnet.it [93.35.44.150]) by mail11.truemail.it (Postfix) with ESMTPA id 1B9531F995; Tue, 2 Jun 2026 07:11:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1780377117; bh=OqMWFZd9Lh6luW5CeI848QHyRFF7wsnQ7DaiCYPSL9Y=; h=From:To:Subject; b=EuyAaD33iam5wEgPz3B0xxsCuCn8h90PG0NaCsDppKjEHbv7BFaezyA039ledRFC9 MyIz2AagOJx82b1IT61YdAZxnjke7CB1L5JFzeSIiUVMwkHI+1S+fBLDPyap5zbZYy kBxyhPWBeDcNijtGYDaVFtSee8RGrs1axpHZFZyXpZiLblOPaqXM+PeXwLgw7Jd7CE /yvtMsZRlzIqz/FDe6YPSPX1SWMmnlQFj+kUcPVCQYViJt7OtfxtSerVjhfp5wYrVI 8vcuHjvUjUseC3KUFMfsdVE+7IL056HU1d3lo5sceRLuv5Mvw7giHI0p8/mrsN0Bjy M16Xbf3o0QNGg== Date: Tue, 2 Jun 2026 07:11:54 +0200 From: Francesco Dolcini To: Frank Li Cc: Franz Schnyder , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Francesco Dolcini , Franz Schnyder , =?iso-8859-1?Q?Jo=E3o_Paulo_Gon=E7alves?= , Emanuele Ghidoli , Francesco Dolcini , Antoine Gouby , Ernest Van Hoecke Subject: Re: [PATCH v4 2/3] arm64: dts: freescale: add Aquila iMX95 support Message-ID: <20260602051154.GB4108@francesco-nb> References: <20260521-add-aquila-imx95-v4-0-5a7f86c824f5@toradex.com> <20260521-add-aquila-imx95-v4-2-5a7f86c824f5@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260601_221202_381680_D6799E8B X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 01, 2026 at 03:45:50PM -0400, Frank Li wrote: > On Thu, May 21, 2026 at 07:11:05PM +0200, Franz Schnyder wrote: > > From: João Paulo Gonçalves > > > > Add support for the Toradex Aquila iMX95 and its development carrier > > board. > > > > The module consists of an NXP i.MX95 family SoC, up to 16GB LPDDR5 RAM, > > up to 128GB of storage, a USB 3.2 OTG and USB 2.0 Host, a Gigabit > > Ethernet PHY, a 10 Gigabit Ethernet interface, an I2C EEPROM and > > Temperature Sensor, an RX8130 RTC, one Quad lane CSI interface, one Quad > > lane DSI or CSI interface, one LVDS interface (one or two channels), and > > some optional addons: DisplayPort (through a DSI-DP bridge), TPM 2.0, > > and a WiFi/BT module. > > > > Link: https://www.toradex.com/computer-on-modules/aquila-arm-family/nxp-imx95 > > Link: https://www.toradex.com/products/carrier-board/aquila-development-board-kit > > Signed-off-by: João Paulo Gonçalves > > Co-developed-by: Emanuele Ghidoli > > Signed-off-by: Emanuele Ghidoli > > Co-developed-by: Francesco Dolcini > > Signed-off-by: Francesco Dolcini > > Co-developed-by: Antoine Gouby > > Signed-off-by: Antoine Gouby > > Co-developed-by: Ernest Van Hoecke > > Signed-off-by: Ernest Van Hoecke > > Co-developed-by: Franz Schnyder > > Signed-off-by: Franz Schnyder > > --- > ... > > + > > + carrier_eeprom: eeprom@57 { > > + compatible = "st,24c02", "atmel,24c02"; > > st,24c02 is not documented. Do not use checkpatch to check a DT file, you have the DT validator for that. st,24c02 is perfectly valid, check Documentation/devicetree/bindings/eeprom/at24.yaml > > + > > + /* Aquila GPIO_08 */ > > + pinctrl_gpio_8: gpio8grp { > > + fsl,pins = ; /* Aquila C24 */ > > + }; > > Please fix checkpatch worning, it exceed 100 char. It is wanted to improve read-ability. Can you keep it like that? Please see Linus option on checkpatch, https://lore.kernel.org/all/CAHk-=wiwpTUr8keTinnPU8kTN9dpYgDtwM4wONRF_j=1gvo3MQ@mail.gmail.com/ Francesco