From: Rob Herring <robh@kernel.org>
To: Ninad Naik <ninadnaik07@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, me@brighamcampbell.com,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org
Subject: Re: [PATCH] regulator: dt-bindings: mt6311: Convert to DT schema
Date: Wed, 3 Jun 2026 20:47:13 -0500 [thread overview]
Message-ID: <20260604014713.GA2331501-robh@kernel.org> (raw)
In-Reply-To: <20260531165712.729635-1-ninadnaik07@gmail.com>
On Sun, May 31, 2026 at 10:27:12PM +0530, Ninad Naik wrote:
> Convert mediatek,mt6311 to DT schema.
>
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
> .../regulator/mediatek,mt6311-regulator.yaml | 72 +++++++++++++++++++
> .../bindings/regulator/mt6311-regulator.txt | 35 ---------
> 2 files changed, 72 insertions(+), 35 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6311-regulator.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/mt6311-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6311-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6311-regulator.yaml
> new file mode 100644
> index 000000000000..a51db46b0f41
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6311-regulator.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6311-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6311 Regulator
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +
> +description: |
Don't need '|' if no formatting.
> + The MediaTek MT6311 is an I2C power management IC that provides one step-down
> + converter and one low-dropout regulator. The regulators are named VDVFS and
> + VBIASN, respectively.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6311-regulator
> +
> + reg:
> + description: I2C slave address.
> + maxItems: 1
> +
> + regulators:
> + type: object
> + description: List of regulators provided by this controller.
> +
> + patternProperties:
> + "^(VDVFS|VBIASN)$":
> + type: object
> + $ref: regulator.yaml#
> + description: |
> + Regulator nodes.
Drop. That's obvious with the $ref.
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mt6311: pmic@6b {
Drop unused label.
> + compatible = "mediatek,mt6311-regulator";
> + reg = <0x6b>;
> +
> + regulators {
> + mt6311_vcpu_reg: VDVFS {
Drop unused label.
> + regulator-name = "VDVFS";
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <1400000>;
> + regulator-ramp-delay = <10000>;
> + };
> +
> + mt6311_ldo_reg: VBIASN {
Drop unused label.
> + regulator-name = "VBIASN";
> + regulator-min-microvolt = <200000>;
> + regulator-max-microvolt = <800000>;
> + };
> + };
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt
> deleted file mode 100644
> index 84d544d8c1b1..000000000000
> --- a/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Mediatek MT6311 Regulator
> -
> -Required properties:
> -- compatible: "mediatek,mt6311-regulator"
> -- reg: I2C slave address, usually 0x6b.
> -- regulators: List of regulators provided by this controller. It is named
> - to VDVFS and VBIASN.
> - The definition for each of these nodes is defined using the standard binding
> - for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
> -
> -The valid names for regulators are:
> -BUCK:
> - VDVFS
> -LDO:
> - VBIASN
> -
> -Example:
> - mt6311: pmic@6b {
> - compatible = "mediatek,mt6311-regulator";
> - reg = <0x6b>;
> -
> - regulators {
> - mt6311_vcpu_reg: VDVFS {
> - regulator-name = "VDVFS";
> - regulator-min-microvolt = < 600000>;
> - regulator-max-microvolt = <1400000>;
> - regulator-ramp-delay = <10000>;
> - };
> - mt6311_ldo_reg: VBIASN {
> - regulator-name = "VBIASN";
> - regulator-min-microvolt = <200000>;
> - regulator-max-microvolt = <800000>;
> - };
> - };
> - };
> --
> 2.54.0
>
>
prev parent reply other threads:[~2026-06-04 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 16:57 [PATCH] regulator: dt-bindings: mt6311: Convert to DT schema Ninad Naik
2026-06-04 1:47 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604014713.GA2331501-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=me@brighamcampbell.com \
--cc=ninadnaik07@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox