From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55971CD8C92 for ; Mon, 8 Jun 2026 07:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2c67zNsS0HvgzZNh71DbxgcmS8tcATdydWycpSmMb/E=; b=nHWX2AZpSaankw8CoZt1OTUdFK +l3DDu8/EgrbP0z5hiakaPvEZSQ2hb/4+A7U/g3nH+JdiVuf7sBg4IMer2Z+4OGkXVsYM6OfzemzK LiSL7JpaGjguTRAt4L8rT6a/oMazNkM+W9ZYpsPLNM4zH1K+hiwuDoygUni1spuam+UO2eyX6a/BR q6mHS8F6uP+8FzaFwMsdu2Y/KdG3XU9nDsUM0cm9nthckDnM9x8YYXjfrJwxweBfGnFd6gwgxLFtb 367a2LOiL4wFuBVjoaN6xbqbYZRL1rgJ/0E87vDzCl/3wqjWIx0Iq7r95TOsOKiUI8JIhuPTh47sz o9dIDTLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUs1-000000031Np-2Lil; Mon, 08 Jun 2026 07:58:05 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUrz-000000031Ng-3RQs; Mon, 08 Jun 2026 07:58:03 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D350D6001D; Mon, 8 Jun 2026 07:58:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90BDF1F00893; Mon, 8 Jun 2026 07:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780905482; bh=2c67zNsS0HvgzZNh71DbxgcmS8tcATdydWycpSmMb/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hT/m1biDqcx4HHvNJoG2hykcnOUtT84VJfuAbUwLAIKu4Hnk+ZXo5P2QkdZjY2wXJ LdNNSwOMzQPatplpQzEha26AG7OPbQVz3klo+T5aEl0HwCxAddaCbz5ZRIfKNxWzWz 0vFCGwQAfOg8jMP1XJXLNMehOB7TVWR2I+ND/wvs8voq9X0rTemT/UcfmaEzCpggbT ke4FGNYQv+Slne1BYStrCVIXlSI/HB0utqa8HXEaYSjB8gMD0B52zJEKzgRj9Lrrvr CvB3tA/oX8qHrsCCqC/hu4kEihVSQ4qi0YlZmRTVFoGqGs0eZ8i73O1P83/zNi0U/q hlCpcmnqLyiDA== Date: Mon, 8 Jun 2026 09:57:58 +0200 From: Krzysztof Kozlowski To: Ricardo Pardini Cc: Heiner Kallweit , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: net: add Realtek r8169 family PCIe Ethernet Message-ID: <20260608-armored-ultra-uakari-ef1d77@quoll> References: <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-0-8a8857b39daf@pardini.net> <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-1-8a8857b39daf@pardini.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-1-8a8857b39daf@pardini.net> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 05, 2026 at 01:49:08PM +0200, Ricardo Pardini wrote: > Add a binding for fixed/soldered Realtek PCIe Ethernet controllers > driven by the r8169 driver (RTL8125/8126/8127/8168 and variants). > > The "pciVVVV,DDDD" compatibles are the Open Firmware PCI Bus Binding > spelling, auto-derived from PCI-SIG vendor/device IDs, but they still > need a binding when used in a board DT - analogous to "usbVVVV,PPPP" > compatibles documented in their own bindings (e.g. microchip,lan95xx) > so board DTs attaching properties (fixed MAC, nvmem cell, ...) to > these PCI function nodes can be validated. > > Suggested-by: Sebastian Reichel > Signed-off-by: Ricardo Pardini > --- > .../devicetree/bindings/net/realtek,r8169.yaml | 54 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/realtek,r8169.yaml b/Documentation/devicetree/bindings/net/realtek,r8169.yaml > new file mode 100644 > index 0000000000000..6923211ff4c93 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek,r8169.yaml r8169 but no r8169 devices at all. This must match the device name, so most likely: realtek,rtl8168.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/realtek,r8169.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek r8169 family PCIe Ethernet Controllers rtl8169? 8168? There is no r8169, is there? > + > +maintainers: > + - Heiner Kallweit > + > +description: > + PCI function node properties for fixed/soldered Realtek Ethernet > + controllers driven by the r8169 driver. Describe hardware, not drivers. > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + enum: > + - pci10ec,8125 # RTL8125 2.5GbE > + - pci10ec,8126 # RTL8126 5GbE > + - pci10ec,8127 # RTL8127 > + - pci10ec,8161 # RTL8168 variant > + - pci10ec,8162 # RTL8168 variant > + - pci10ec,8168 # RTL8168/8111 GbE > + > + reg: > + maxItems: 1 > + > + local-mac-address: true > + mac-address: true > + nvmem-cells: true > + nvmem-cell-names: true Drop all above > + > +required: > + - compatible > + - reg > + > +additionalProperties: false uneavaluatedProperties instead Best regards, Krzysztof